Dmitry VerkhoturovandUmputun
ddcb2c7b5f
The store tests stored timestamps with time.Local in their fixtures and asserted equality against returned values that the engine round-trips through UTC. assert.Equal compares zone identity, so on UTC machines (CI, most cloud envs) Local==UTC and the tests passed; on a developer machine in any other timezone (here BST, UTC+1) TestService_Put, TestService_List, TestBoltDB_InfoPost, TestBoltDB_InfoList and several others would fail with same wall-clock numbers but mismatched zones. Replace time.Local with time.UTC across store/comment_test.go, store/formatter_test.go, store/service/service_test.go, store/engine/bolt_test.go, store/engine/engine_test.go. Production code is untouched.
56 lines
1.5 KiB
Go
56 lines
1.5 KiB
Go
package engine
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/umputun/remark42/backend/app/store"
|
|
)
|
|
|
|
func TestEngine_sortComments(t *testing.T) {
|
|
cc := []store.Comment{
|
|
{ID: "1", Score: 5, Controversy: 1, Timestamp: time.Date(2018, 2, 5, 10, 1, 0, 0, time.UTC)},
|
|
{ID: "2", Score: 4, Controversy: 2, Timestamp: time.Date(2018, 2, 5, 10, 2, 0, 0, time.UTC)},
|
|
{ID: "3", Score: 6, Controversy: 3, Timestamp: time.Date(2018, 2, 5, 10, 3, 0, 0, time.UTC)},
|
|
{ID: "4", Score: 6, Controversy: 1, Timestamp: time.Date(2018, 2, 5, 10, 4, 0, 0, time.UTC)},
|
|
}
|
|
|
|
SortComments(cc, "+time")
|
|
assert.Equal(t, "1", cc[0].ID)
|
|
assert.Equal(t, "2", cc[1].ID)
|
|
assert.Equal(t, "3", cc[2].ID)
|
|
assert.Equal(t, "4", cc[3].ID)
|
|
|
|
SortComments(cc, "-time")
|
|
assert.Equal(t, "4", cc[0].ID)
|
|
assert.Equal(t, "3", cc[1].ID)
|
|
assert.Equal(t, "2", cc[2].ID)
|
|
assert.Equal(t, "1", cc[3].ID)
|
|
|
|
SortComments(cc, "score")
|
|
assert.Equal(t, "2", cc[0].ID)
|
|
assert.Equal(t, "1", cc[1].ID)
|
|
assert.Equal(t, "3", cc[2].ID)
|
|
assert.Equal(t, "4", cc[3].ID)
|
|
|
|
SortComments(cc, "-score")
|
|
assert.Equal(t, "3", cc[0].ID)
|
|
assert.Equal(t, "4", cc[1].ID)
|
|
assert.Equal(t, "1", cc[2].ID)
|
|
assert.Equal(t, "2", cc[3].ID)
|
|
|
|
SortComments(cc, "controversy")
|
|
assert.Equal(t, "1", cc[0].ID)
|
|
assert.Equal(t, "4", cc[1].ID)
|
|
assert.Equal(t, "2", cc[2].ID)
|
|
assert.Equal(t, "3", cc[3].ID)
|
|
|
|
SortComments(cc, "-controversy")
|
|
assert.Equal(t, "3", cc[0].ID)
|
|
assert.Equal(t, "2", cc[1].ID)
|
|
assert.Equal(t, "1", cc[2].ID)
|
|
assert.Equal(t, "4", cc[3].ID)
|
|
}
|