Dmitry VerkhoturovandUmputun
385ea800a4
Previous behaviour is preserved for query parameters way of requesting
the subscription. The new behaviour with the possibility to confirm
the email right away without a separate /email/confirm call is enabled
only with request params sent in the request body, which was not a thing
before 27fc339e, which was merged just now and is not part
of any tagged version yet.
1544 lines
63 KiB
Go
1544 lines
63 KiB
Go
package api
|
|
|
|
import (
|
|
"bytes"
|
|
"compress/gzip"
|
|
"context"
|
|
"encoding/base64"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"mime/multipart"
|
|
"net/http"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/go-chi/render"
|
|
"github.com/go-pkgz/auth/token"
|
|
"github.com/go-pkgz/lgr"
|
|
R "github.com/go-pkgz/rest"
|
|
"github.com/golang-jwt/jwt"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/umputun/remark42/backend/app/notify"
|
|
"github.com/umputun/remark42/backend/app/store"
|
|
"github.com/umputun/remark42/backend/app/store/image"
|
|
)
|
|
|
|
// gopher png for test, from https://golang.org/src/image/png/example_test.go
|
|
const gopher = `iVBORw0KGgoAAAANSUhEUgAAAEsAAAA8CAAAAAALAhhPAAAFfUlEQVRYw62XeWwUVRzHf2+OPbo9d7tsWyiyaZti6eWGAhISoIGKECEKCAiJJkYTiUgTMYSIosYYBBIUIxoSPIINEBDi2VhwkQrVsj1ESgu9doHWdrul7ba73WNm3vOPtsseM9MdwvvrzTs+8/t95ze/33sI5BqiabU6m9En8oNjduLnAEDLUsQXFF8tQ5oxK3vmnNmDSMtrncks9Hhtt/qeWZapHb1ha3UqYSWVl2ZmpWgaXMXGohQAvmeop3bjTRtv6SgaK/Pb9/bFzUrYslbFAmHPp+3WhAYdr+7GN/YnpN46Opv55VDsJkoEpMrY/vO2BIYQ6LLvm0ThY3MzDzzeSJeeWNyTkgnIE5ePKsvKlcg/0T9QMzXalwXMlj54z4c0rh/mzEfr+FgWEz2w6uk8dkzFAgcARAgNp1ZYef8bH2AgvuStbc2/i6CiWGj98y2tw2l4FAXKkQBIf+exyRnteY83LfEwDQAYCoK+P6bxkZm/0966LxcAAILHB56kgD95PPxltuYcMtFTWw/FKkY/6Opf3GGd9ZF+Qp6mzJxzuRSractOmJrH1u8XTvWFHINNkLQLMR+XHXvfPPHw967raE1xxwtA36IMRfkAAG29/7mLuQcb2WOnsJReZGfpiHsSBX81cvMKywYZHhX5hFPtOqPGWZCXnhWGAu6lX91ElKXSalcLXu3UaOXVay57ZSe5f6Gpx7J2MXAsi7EqSp09b/MirKSyJfnfEEgeDjl8FgDAfvewP03zZ+AJ0m9aFRM8eEHBDRKjfcreDXnZdQuAxXpT2NRJ7xl3UkLBhuVGU16gZiGOgZmrSbRdqkILuL/yYoSXHHkl9KXgqNu3PB8oRg0geC5vFmLjad6mUyTKLmF3OtraWDIfACyXqmephaDABawfpi6tqqBZytfQMqOz6S09iWXhktrRaB8Xz4Yi/8gyABDm5NVe6qq/3VzPrcjELWrebVuyY2T7ar4zQyybUCtsQ5Es1FGaZVrRVQwAgHGW2ZCRZshI5bGQi7HesyE972pOSeMM0dSktlzxRdrlqb3Osa6CCS8IJoQQQgBAbTAa5l5epO34rJszibJI8rxLfGzcp1dRosutGeb2VDNgqYrwTiPNsLxXiPi3dz7LiS1WBRBDBOnqEjyy3aQb+/bLiJzz9dIkscVBBLxMfSEac7kO4Fpkngi0ruNBeSOal+u8jgOuqPz12nryMLCniEjtOOOmpt+KEIqsEdocJjYXwrh9OZqWJQyPCTo67LNS/TdxLAv6R5ZNK9npEjbYdT33gRo4o5oTqR34R+OmaSzDBWsAIPhuRcgyoteNi9gF0KzNYWVItPf2TLoXEg+7isNC7uJkgo1iQWOfRSP9NR11RtbZZ3OMG/VhL6jvx+J1m87+RCfJChAtEBQkSBX2PnSiihc/Twh3j0h7qdYQAoRVsRGmq7HU2QRbaxVGa1D6nIOqaIWRjyRZpHMQKWKpZM5feA+lzC4ZFultV8S6T0mzQGhQohi5I8iw+CsqBSxhFMuwyLgSwbghGb0AiIKkSDmGZVmJSiKihsiyOAUs70UkywooYP0bii9GdH4sfr1UNysd3fUyLLMQN+rsmo3grHl9VNJHbbwxoa47Vw5gupIqrZcjPh9R4Nye3nRDk199V+aetmvVtDRE8/+cbgAAgMIWGb3UA0MGLE9SCbWX670TDy1y98c3D27eppUjsZ6fql3jcd5rUe7+ZIlLNQny3Rd+E5Tct3WVhTM5RBCEdiEK0b6B+/ca2gYU393nFj/n1AygRQxPIUA043M42u85+z2SnssKrPl8Mx76NL3E6eXc3be7OD+H4WHbJkKI8AU8irbITQjZ+0hQcPEgId/Fn/pl9crKH02+5o2b9T/eMx7pKoskYgAAAABJRU5ErkJggg==`
|
|
|
|
func gopherPNG() io.Reader { return base64.NewDecoder(base64.StdEncoding, strings.NewReader(gopher)) }
|
|
|
|
func TestRest_Create(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
resp, err := post(t, ts.URL+"/api/v1/comment",
|
|
`{"text": "test 123", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`)
|
|
assert.NoError(t, err)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(b))
|
|
assert.NoError(t, resp.Body.Close())
|
|
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
loc := c["locator"].(map[string]interface{})
|
|
assert.Equal(t, "remark42", loc["site"])
|
|
assert.Equal(t, "https://radio-t.com/blah1", loc["url"])
|
|
assert.True(t, len(c["id"].(string)) > 8)
|
|
}
|
|
|
|
// based on issue https://github.com/umputun/remark42/issues/1292
|
|
func TestRest_CreateFilteredCode(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
resp, err := post(t, ts.URL+"/api/v1/comment",
|
|
`{"text": "`+"`foo<bar>`"+`", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`)
|
|
assert.NoError(t, err)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(b))
|
|
assert.NoError(t, resp.Body.Close())
|
|
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
loc := c["locator"].(map[string]interface{})
|
|
assert.Equal(t, "remark42", loc["site"])
|
|
assert.Equal(t, "https://radio-t.com/blah1", loc["url"])
|
|
assert.Equal(t, "`foo<bar>`", c["orig"])
|
|
assert.Contains(t, c["text"], "foo")
|
|
assert.Contains(t, c["text"], "bar")
|
|
assert.True(t, len(c["id"].(string)) > 8)
|
|
}
|
|
|
|
func TestRest_CreateOldPost(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
// make old, but not too old comment
|
|
old := store.Comment{Text: "test test old", ParentID: "", Timestamp: time.Now().AddDate(0, 0, -5),
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}, User: store.User{ID: "u1"}}
|
|
_, err := srv.DataService.Create(old)
|
|
assert.NoError(t, err)
|
|
|
|
comments, err := srv.DataService.Find(store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}, "time", store.User{})
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 1, len(comments))
|
|
|
|
// try to add new comment to the same old post
|
|
resp, err := post(t, ts.URL+"/api/v1/comment",
|
|
`{"text": "test 123", "locator":{"site": "remark42","url": "https://radio-t.com/blah1"}}`)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
|
|
assert.NoError(t, srv.DataService.DeleteAll("remark42"))
|
|
// make too old comment
|
|
old = store.Comment{Text: "test test old", ParentID: "", Timestamp: time.Now().AddDate(0, 0, -15),
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}, User: store.User{ID: "u1"}}
|
|
_, err = srv.DataService.Create(old)
|
|
assert.NoError(t, err)
|
|
|
|
resp, err = post(t, ts.URL+"/api/v1/comment",
|
|
`{"text": "test 123", "locator":{"site": "remark42","url": "https://radio-t.com/blah1"}}`)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusForbidden, resp.StatusCode)
|
|
}
|
|
|
|
func TestRest_CreateTooBig(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
longComment := fmt.Sprintf(`{"text": "%4001s", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`, "Щ")
|
|
|
|
resp, err := post(t, ts.URL+"/api/v1/comment", longComment)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "comment text exceeded max allowed size 4000 (4001)", c["error"])
|
|
assert.Equal(t, "invalid comment", c["details"])
|
|
|
|
veryLongComment := fmt.Sprintf(`{"text": "%70000s", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`, "Щ")
|
|
resp, err = post(t, ts.URL+"/api/v1/comment", veryLongComment)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
|
|
b, err = io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
c = R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "http: request body too large", c["error"])
|
|
assert.Equal(t, "can't bind comment", c["details"])
|
|
}
|
|
|
|
func TestRest_CreateWithRestrictedWord(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
badComment := `{"text": "What the duck is that?", "locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`
|
|
|
|
resp, err := post(t, ts.URL+"/api/v1/comment", badComment)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "comment contains restricted words", c["error"])
|
|
assert.Equal(t, "invalid comment", c["details"])
|
|
}
|
|
|
|
func TestRest_CreateRejected(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
body := `{"text": "test 123", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`
|
|
|
|
// try to create without auth
|
|
resp, err := http.Post(ts.URL+"/api/v1/comment", "", strings.NewReader(body))
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusUnauthorized, resp.StatusCode)
|
|
|
|
// try with wrong aud
|
|
client := &http.Client{Timeout: 5 * time.Second}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest("POST", ts.URL+"/api/v1/comment", strings.NewReader(body))
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devTokenBadAud)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusForbidden, resp.StatusCode, "reject wrong aud")
|
|
}
|
|
|
|
func TestRest_CreateWithWrongImage(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
// create comment
|
|
resp, err := post(t, ts.URL+"/api/v1/comment", fmt.Sprintf(`{"text": "", "locator":{"url": "https://radio-t.com/blah1", "site": "radio-t"}}`, srv.RemarkURL))
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
assert.Contains(t,
|
|
string(b),
|
|
"{\"code\":20,\"details\":\"can't load picture from the comment\","+
|
|
"\"error\":\"can't get image file for dev_user/bad_picture: can't get image stats for dev_user/bad_picture: stat ",
|
|
)
|
|
assert.Contains(t,
|
|
string(b),
|
|
"/pics-remark42/staging/dev_user/62/bad_picture: no such file or directory\"}\n",
|
|
)
|
|
}
|
|
|
|
func TestRest_CreateWithLazyImage(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
body := `{"text": "test 123 ", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`
|
|
// create comment
|
|
resp, err := post(t, ts.URL+"/api/v1/comment", body)
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
c := store.Comment{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, c.Text, "<p>test 123 <img src=\"http://example.com/image.png\" alt=\"\" loading=\"lazy\"/></p>\n")
|
|
}
|
|
|
|
func TestRest_CreateAndGet(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
// create comment
|
|
resp, err := post(t, ts.URL+"/api/v1/comment",
|
|
`{"text": "**test** *123*\n\n http://radio-t.com", "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`)
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(b, &c)
|
|
assert.NoError(t, err)
|
|
|
|
id := c["id"].(string)
|
|
|
|
// get created comment by id as admin
|
|
res, code := getWithAdminAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah1", ts.URL, id))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
comment := store.Comment{}
|
|
err = json.Unmarshal([]byte(res), &comment)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "<p><strong>test</strong> <em>123</em></p>\n\n<p><a href=\"http://radio-t.com\" rel=\"nofollow\">http://radio-t.com</a></p>\n", comment.Text)
|
|
assert.Equal(t, "**test** *123*\n\n http://radio-t.com", comment.Orig)
|
|
assert.Equal(t, store.User{Name: "admin", ID: "admin", Admin: true, Blocked: false,
|
|
IP: "dbc7c999343f003f189f70aaf52cc04443f90790"},
|
|
comment.User)
|
|
|
|
// get created comment by id as non-admin
|
|
res, code = getWithDevAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah1", ts.URL, id))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
comment = store.Comment{}
|
|
err = json.Unmarshal([]byte(res), &comment)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "admin", ID: "admin", Admin: true, Blocked: false, IP: ""}, comment.User, "no ip")
|
|
}
|
|
|
|
func TestRest_Update(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "test test #1", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
id := addComment(t, c1, ts)
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+id+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"text":"updated text", "summary":"my edit"}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err := io.ReadAll(b.Body)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, b.StatusCode, string(body))
|
|
assert.NoError(t, b.Body.Close())
|
|
|
|
// comments returned by update
|
|
c2 := store.Comment{}
|
|
err = json.Unmarshal(body, &c2)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, id, c2.ID)
|
|
assert.Equal(t, "<p>updated text</p>\n", c2.Text)
|
|
assert.Equal(t, "updated text", c2.Orig)
|
|
assert.Equal(t, "my edit", c2.Edit.Summary)
|
|
assert.True(t, time.Since(c2.Edit.Timestamp) < 1*time.Second)
|
|
|
|
// read updated comment
|
|
res, code := getWithAdminAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah1", ts.URL, id))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
c3 := store.Comment{}
|
|
err = json.Unmarshal([]byte(res), &c3)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, c2, c3, "same as response from update")
|
|
}
|
|
|
|
func TestRest_UpdateDelete(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "test test #1", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
id := addComment(t, c1, ts)
|
|
|
|
// check multi count updated
|
|
resp, err := post(t, ts.URL+"/api/v1/counts?site=remark42", `["https://radio-t.com/blah1","https://radio-t.com/blah2"]`)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
bb, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
j := []store.PostInfo{}
|
|
err = json.Unmarshal(bb, &j)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []store.PostInfo{{URL: "https://radio-t.com/blah1", Count: 1},
|
|
{URL: "https://radio-t.com/blah2", Count: 0}}, j)
|
|
|
|
// delete a comment
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+id+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"delete": true, "summary":"removed by user"}`))
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err := io.ReadAll(b.Body)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, b.StatusCode, string(body))
|
|
assert.NoError(t, b.Body.Close())
|
|
|
|
// comments returned by update
|
|
c2 := store.Comment{}
|
|
err = json.Unmarshal(body, &c2)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, id, c2.ID)
|
|
assert.True(t, c2.Deleted)
|
|
|
|
// read updated comment
|
|
res, code := getWithDevAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah1", ts.URL, id))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
c3 := store.Comment{}
|
|
err = json.Unmarshal([]byte(res), &c3)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "", c3.Text)
|
|
assert.Equal(t, "", c3.Orig)
|
|
assert.True(t, c3.Deleted)
|
|
|
|
// check multi count updated
|
|
resp, err = post(t, ts.URL+"/api/v1/counts?site=remark42", `["https://radio-t.com/blah1","https://radio-t.com/blah2"]`)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
bb, err = io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
j = []store.PostInfo{}
|
|
err = json.Unmarshal(bb, &j)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, []store.PostInfo{{URL: "https://radio-t.com/blah1", Count: 0},
|
|
{URL: "https://radio-t.com/blah2", Count: 0}}, j)
|
|
}
|
|
|
|
func TestRest_DeleteChildThenParent(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
p := store.Comment{Text: "test test #1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
idP := addComment(t, p, ts)
|
|
|
|
c1 := store.Comment{Text: "test test #1", ParentID: idP,
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
idC1 := addComment(t, c1, ts)
|
|
|
|
c2 := store.Comment{Text: "test test #1", ParentID: idP,
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
idC2 := addComment(t, c2, ts)
|
|
|
|
// check multi count equals two
|
|
resp, err := post(t, ts.URL+"/api/v1/counts?site=remark42", `["https://radio-t.com/blah1"]`)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
bb, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
j := []store.PostInfo{}
|
|
err = json.Unmarshal(bb, &j)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []store.PostInfo{{URL: "https://radio-t.com/blah1", Count: 3}}, j)
|
|
|
|
// update a parent comment fails after child is created
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+idP+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"text": "updated text", "summary":"updated by user"}`))
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err := io.ReadAll(b.Body)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, b.StatusCode, string(body))
|
|
assert.NoError(t, b.Body.Close())
|
|
|
|
// delete first child comment
|
|
req, err = http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+idC1+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"delete": true, "summary":"removed by user"}`))
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(b.Body)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, b.StatusCode, string(body))
|
|
assert.NoError(t, b.Body.Close())
|
|
|
|
// delete a parent comment, fails as one comment child still present
|
|
defer client.CloseIdleConnections()
|
|
req, err = http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+idP+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"delete": true, "summary":"removed by user"}`))
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(b.Body)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, b.StatusCode, string(body))
|
|
assert.NoError(t, b.Body.Close())
|
|
|
|
// delete second child comment, as an admin to check both deletion methods
|
|
req, err = http.NewRequest(http.MethodDelete,
|
|
fmt.Sprintf("%s/api/v1/admin/comment/%s?site=remark42&url=https://radio-t.com/blah1", ts.URL, idC2), http.NoBody)
|
|
require.NoError(t, err)
|
|
requireAdminOnly(t, req)
|
|
resp, err = sendReq(t, req, adminUmputunToken)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
|
|
// delete a parent comment, shouldn't fail after children are deleted
|
|
defer client.CloseIdleConnections()
|
|
req, err = http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+idP+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"delete": true, "summary":"removed by user"}`))
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(b.Body)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, b.StatusCode, string(body))
|
|
assert.NoError(t, b.Body.Close())
|
|
|
|
// check multi count decremented to zero
|
|
resp, err = post(t, ts.URL+"/api/v1/counts?site=remark42", `["https://radio-t.com/blah1"]`)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
bb, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
j = []store.PostInfo{}
|
|
err = json.Unmarshal(bb, &j)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []store.PostInfo{{URL: "https://radio-t.com/blah1", Count: 0}}, j)
|
|
}
|
|
|
|
func TestRest_UpdateNotOwner(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "test test #1", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}, User: store.User{ID: "xyz"}}
|
|
id1, err := srv.DataService.Create(c1)
|
|
assert.NoError(t, err)
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+id1+
|
|
"?site=remark42&url=https://radio-t.com/blah1", strings.NewReader(`{"text":"updated text", "summary":"my edit"}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err := io.ReadAll(b.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, b.Body.Close())
|
|
assert.Equal(t, http.StatusForbidden, b.StatusCode, string(body), "update from non-owner")
|
|
assert.Equal(t, `{"code":3,"details":"can not edit comments for other users","error":"rejected"}`+"\n", string(body))
|
|
|
|
req, err = http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+id1+
|
|
"?site=remark42&url=https://radio-t.com/blah1", strings.NewReader(`ERRR "text":"updated text", "summary":"my"}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, b.Body.Close())
|
|
assert.Equal(t, http.StatusBadRequest, b.StatusCode, string(body), "update is not json")
|
|
}
|
|
|
|
func TestRest_UpdateWrongAud(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "test test #1", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
id := addComment(t, c1, ts)
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+id+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"text":"updated text", "summary":"my edit"}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devTokenBadAud)
|
|
b, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, b.Body.Close())
|
|
assert.Equal(t, http.StatusForbidden, b.StatusCode, "reject update with wrong aut in jwt")
|
|
}
|
|
|
|
func TestRest_UpdateWithRestrictedWords(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "What the quack is that?", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah1"}}
|
|
id := addComment(t, c1, ts)
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut, ts.URL+"/api/v1/comment/"+id+"?site=remark42&url=https://radio-t.com/blah1",
|
|
strings.NewReader(`{"text":"What the duck is that?", "summary":"my edit"}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
b, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err := io.ReadAll(b.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, b.Body.Close())
|
|
c := R.JSON{}
|
|
err = json.Unmarshal(body, &c)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusBadRequest, b.StatusCode, string(body))
|
|
assert.Equal(t, "comment contains restricted words", c["error"])
|
|
assert.Equal(t, "invalid comment", c["details"])
|
|
}
|
|
|
|
func TestRest_Vote(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "test test #1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah"}}
|
|
c2 := store.Comment{Text: "test test #2", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah"}}
|
|
|
|
id1 := addComment(t, c1, ts)
|
|
addComment(t, c2, ts)
|
|
|
|
vote := func(val int) int {
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut,
|
|
fmt.Sprintf("%s/api/v1/vote/%s?site=remark42&url=https://radio-t.com/blah&vote=%d", ts.URL, id1, val), http.NoBody)
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
return resp.StatusCode
|
|
}
|
|
|
|
assert.Equal(t, http.StatusOK, vote(1), "first vote allowed")
|
|
assert.Equal(t, http.StatusBadRequest, vote(1), "second vote rejected")
|
|
body, code := getWithDevAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
cr := store.Comment{}
|
|
err := json.Unmarshal([]byte(body), &cr)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 1, cr.Score)
|
|
assert.Equal(t, 1, cr.Vote)
|
|
assert.Equal(t, map[string]bool(nil), cr.Votes, "hidden")
|
|
assert.Equal(t, map[string]store.VotedIPInfo(nil), cr.VotedIPs, "hidden")
|
|
|
|
assert.Equal(t, http.StatusOK, vote(-1), "opposite vote allowed")
|
|
body, code = getWithDevAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
cr = store.Comment{}
|
|
err = json.Unmarshal([]byte(body), &cr)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 0, cr.Score)
|
|
assert.Equal(t, 0, cr.Vote)
|
|
|
|
assert.Equal(t, http.StatusOK, vote(-1), "opposite vote allowed one more time")
|
|
body, code = getWithDevAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
cr = store.Comment{}
|
|
err = json.Unmarshal([]byte(body), &cr)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, -1, cr.Score)
|
|
assert.Equal(t, -1, cr.Vote)
|
|
|
|
assert.Equal(t, http.StatusBadRequest, vote(-1), "dbl vote not allowed")
|
|
body, code = getWithDevAuth(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
cr = store.Comment{}
|
|
err = json.Unmarshal([]byte(body), &cr)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, -1, cr.Score)
|
|
assert.Equal(t, -1, cr.Vote)
|
|
|
|
body, code = get(t, fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1))
|
|
assert.Equal(t, http.StatusOK, code)
|
|
cr = store.Comment{}
|
|
err = json.Unmarshal([]byte(body), &cr)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, -1, cr.Score)
|
|
assert.Equal(t, 0, cr.Vote, "no vote info for not authed user")
|
|
assert.Equal(t, map[string]bool(nil), cr.Votes, "hidden")
|
|
assert.Equal(t, map[string]store.VotedIPInfo(nil), cr.VotedIPs, "hidden")
|
|
|
|
req, err := http.NewRequest("GET",
|
|
fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1), http.NoBody)
|
|
assert.NoError(t, err)
|
|
resp, err := sendReq(t, req, adminUmputunToken)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
cr = store.Comment{}
|
|
err = json.NewDecoder(resp.Body).Decode(&cr)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, -1, cr.Score)
|
|
assert.Equal(t, 0, cr.Vote, "no vote info for different user")
|
|
assert.Equal(t, map[string]bool(nil), cr.Votes, "hidden")
|
|
assert.Equal(t, map[string]store.VotedIPInfo(nil), cr.VotedIPs, "hidden")
|
|
}
|
|
|
|
func TestRest_AnonVote(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
c1 := store.Comment{Text: "test test #1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah"}}
|
|
c2 := store.Comment{Text: "test test #2", ParentID: "p1",
|
|
Locator: store.Locator{SiteID: "remark42", URL: "https://radio-t.com/blah"}}
|
|
|
|
id1 := addComment(t, c1, ts)
|
|
addComment(t, c2, ts)
|
|
|
|
vote := func(val int) int {
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPut,
|
|
fmt.Sprintf("%s/api/v1/vote/%s?site=remark42&url=https://radio-t.com/blah&vote=%d", ts.URL, id1, val), http.NoBody)
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", anonToken)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
return resp.StatusCode
|
|
}
|
|
|
|
getWithAnonAuth := func(url string) (body string, code int) {
|
|
client := &http.Client{Timeout: 5 * time.Second}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest("GET", url, http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", anonToken)
|
|
r, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
defer r.Body.Close()
|
|
b, err := io.ReadAll(r.Body)
|
|
assert.NoError(t, err)
|
|
return string(b), r.StatusCode
|
|
}
|
|
|
|
assert.Equal(t, http.StatusForbidden, vote(1), "vote is disallowed with anonVote false")
|
|
srv.privRest.anonVote = true
|
|
assert.Equal(t, http.StatusOK, vote(1), "first vote allowed")
|
|
assert.Equal(t, http.StatusBadRequest, vote(1), "second vote rejected")
|
|
body, code := getWithAnonAuth(fmt.Sprintf("%s/api/v1/id/%s?site=remark42&url=https://radio-t.com/blah", ts.URL, id1))
|
|
|
|
assert.Equal(t, http.StatusOK, code)
|
|
cr := store.Comment{}
|
|
err := json.Unmarshal([]byte(body), &cr)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 1, cr.Score)
|
|
assert.Equal(t, 1, cr.Vote)
|
|
assert.Equal(t, map[string]bool(nil), cr.Votes)
|
|
assert.Equal(t, map[string]store.VotedIPInfo(nil), cr.VotedIPs)
|
|
}
|
|
|
|
func TestRest_EmailAndTelegram(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
srv.privRest.telegramService = &mockTelegram{site: "remark42"}
|
|
|
|
// issue good token
|
|
claims := token.Claims{
|
|
Handshake: &token.Handshake{ID: "dev::good@example.com"},
|
|
StandardClaims: jwt.StandardClaims{
|
|
Audience: "remark42",
|
|
ExpiresAt: time.Now().Add(10 * time.Minute).Unix(),
|
|
NotBefore: time.Now().Add(-1 * time.Minute).Unix(),
|
|
Issuer: "remark42",
|
|
},
|
|
}
|
|
tkn, err := srv.Authenticator.TokenService().Token(claims)
|
|
require.NoError(t, err)
|
|
goodToken := tkn
|
|
|
|
var testData = []struct {
|
|
description string
|
|
url string
|
|
method string
|
|
responseCode int
|
|
noAuth bool
|
|
cookieEmail string
|
|
body string
|
|
}{
|
|
{description: "issue delete request without auth", url: "/api/v1/email", method: http.MethodDelete, responseCode: http.StatusUnauthorized, noAuth: true},
|
|
{description: "issue delete request without site_id", url: "/api/v1/email", method: http.MethodDelete, responseCode: http.StatusBadRequest},
|
|
{description: "delete non-existent user email", url: "/api/v1/email?site=remark42", method: http.MethodDelete, responseCode: http.StatusOK},
|
|
{description: "set user email, token not set", url: "/api/v1/email/confirm", method: http.MethodPost, responseCode: http.StatusBadRequest, body: `{"site":"remark42"}`},
|
|
{description: "set user email, token not set, old query param", url: "/api/v1/email/confirm?site=remark42", method: http.MethodPost, responseCode: http.StatusBadRequest},
|
|
{description: "send email confirmation without address", url: "/api/v1/email/subscribe", method: http.MethodPost, responseCode: http.StatusBadRequest, body: `{"site":"remark42"}`},
|
|
{description: "send email confirmation without address, old query param", url: "/api/v1/email/subscribe?site=remark42", method: http.MethodPost, responseCode: http.StatusBadRequest},
|
|
{description: "send email confirmation", url: "/api/v1/email/subscribe", method: http.MethodPost, responseCode: http.StatusOK, body: `{"site":"remark42","address":"good@example.com"}`},
|
|
{description: "send email confirmation, old query param", url: "/api/v1/email/subscribe?site=remark42&address=good@example.com", method: http.MethodPost, responseCode: http.StatusOK},
|
|
{description: "set user email, token is good", url: "/api/v1/email/confirm", method: http.MethodPost, responseCode: http.StatusOK, cookieEmail: "good@example.com", body: fmt.Sprintf(`{"site":"remark42","token":%q}`, goodToken)},
|
|
{description: "set user email, token is good, old query param", url: fmt.Sprintf("/api/v1/email/confirm?site=remark42&tkn=%s", goodToken), method: http.MethodPost, responseCode: http.StatusOK, cookieEmail: "good@example.com"},
|
|
{description: "send confirmation with same address", url: "/api/v1/email/subscribe?site=remark42&address=good@example.com", method: http.MethodPost, responseCode: http.StatusConflict},
|
|
{description: "get user email", url: "/api/v1/email?site=remark42", method: http.MethodGet, responseCode: http.StatusOK},
|
|
{description: "delete user email", url: "/api/v1/email?site=remark42", method: http.MethodDelete, responseCode: http.StatusOK},
|
|
{description: "send another confirmation", url: "/api/v1/email/subscribe?site=remark42&address=good@example.com", method: http.MethodPost, responseCode: http.StatusOK},
|
|
{description: "set user email, token is good", url: "/api/v1/email/confirm", method: http.MethodPost, responseCode: http.StatusOK, cookieEmail: "good@example.com", body: fmt.Sprintf(`{"site":"remark42","token":%q}`, goodToken)},
|
|
{description: "set user email, token is good, old query param", url: fmt.Sprintf("/api/v1/email/confirm?site=remark42&tkn=%s", goodToken), method: http.MethodPost, responseCode: http.StatusOK, cookieEmail: "good@example.com"},
|
|
{description: "unsubscribe user, no token", url: "/email/unsubscribe.html?site=remark42", method: http.MethodPost, responseCode: http.StatusBadRequest},
|
|
{description: "unsubscribe user, wrong token", url: "/email/unsubscribe.html?site=remark42&tkn=jwt", method: http.MethodGet, responseCode: http.StatusForbidden},
|
|
{description: "unsubscribe user, good token", url: fmt.Sprintf("/email/unsubscribe.html?site=remark42&tkn=%s", goodToken), method: http.MethodPost, responseCode: http.StatusOK},
|
|
{description: "unsubscribe user second time, good token", url: fmt.Sprintf("/email/unsubscribe.html?site=remark42&tkn=%s", goodToken), method: http.MethodPost, responseCode: http.StatusConflict},
|
|
{description: "issue delete request without auth", url: "/api/v1/telegram", method: http.MethodDelete, responseCode: http.StatusUnauthorized, noAuth: true},
|
|
{description: "issue delete request without site_id", url: "/api/v1/telegram", method: http.MethodDelete, responseCode: http.StatusBadRequest},
|
|
{description: "delete non-existent user telegram", url: "/api/v1/telegram?site=remark42", method: http.MethodDelete, responseCode: http.StatusOK},
|
|
{description: "send telegram confirmation, no siteID", url: "/api/v1/telegram/subscribe", method: http.MethodGet, responseCode: http.StatusBadRequest},
|
|
{description: "send telegram confirmation", url: "/api/v1/telegram/subscribe?site=remark42", method: http.MethodGet, responseCode: http.StatusOK},
|
|
{description: "set user telegram, token is good", url: "/api/v1/telegram/subscribe?site=remark42&tkn=good_token", method: http.MethodGet, responseCode: http.StatusOK},
|
|
{description: "send confirmation with same address", url: "/api/v1/telegram/subscribe?site=remark42", method: http.MethodGet, responseCode: http.StatusConflict},
|
|
{description: "delete user telegram", url: "/api/v1/telegram?site=remark42", method: http.MethodDelete, responseCode: http.StatusOK},
|
|
{description: "send another confirmation", url: "/api/v1/telegram/subscribe?site=remark42", method: http.MethodGet, responseCode: http.StatusOK},
|
|
{description: "set user telegram, token is good", url: "/api/v1/telegram/subscribe?site=remark42&tkn=good_token", method: http.MethodGet, responseCode: http.StatusOK},
|
|
}
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
for _, x := range testData {
|
|
x := x
|
|
t.Run(x.description, func(t *testing.T) {
|
|
reqBody := io.NopCloser(strings.NewReader(x.body))
|
|
if x.body == "" {
|
|
reqBody = http.NoBody
|
|
}
|
|
req, err := http.NewRequest(x.method, ts.URL+x.url, reqBody)
|
|
require.NoError(t, err)
|
|
if !x.noAuth {
|
|
req.Header.Add("X-JWT", devToken)
|
|
}
|
|
resp, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
// read User.Email from the token in the cookie
|
|
for _, c := range resp.Cookies() {
|
|
if c.Name == "JWT" {
|
|
claims, err := srv.Authenticator.TokenService().Parse(c.Value)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, x.cookieEmail, claims.User.Email, "cookie email check failed")
|
|
}
|
|
}
|
|
assert.Equal(t, x.responseCode, resp.StatusCode, string(body))
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestRest_EmailNotification(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
mockDestination := ¬ify.MockDest{}
|
|
srv.privRest.notifyService = notify.NewService(srv.DataService, 1, mockDestination)
|
|
defer srv.privRest.notifyService.Close()
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
|
|
// create new comment from dev user
|
|
req, err := http.NewRequest("POST", ts.URL+"/api/v1/comment", strings.NewReader(
|
|
`{"text": "test 123",
|
|
"user": {"name": "dev::good@example.com"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
parentComment := store.Comment{}
|
|
require.NoError(t, render.DecodeJSON(strings.NewReader(string(body)), &parentComment))
|
|
// wait for mock notification Submit to kick off
|
|
time.Sleep(time.Millisecond * 30)
|
|
require.Equal(t, 1, len(mockDestination.Get()))
|
|
assert.Empty(t, mockDestination.Get()[0].Emails)
|
|
|
|
// create child comment from another user, email notification only to admin expected
|
|
req, err = http.NewRequest("POST", ts.URL+"/api/v1/comment", strings.NewReader(fmt.Sprintf(
|
|
`{"text": "test 456",
|
|
"pid": %q,
|
|
"user": {"name": "other_user"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`, parentComment.ID)))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", anonToken)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
// wait for mock notification Submit to kick off
|
|
time.Sleep(time.Millisecond * 30)
|
|
require.Equal(t, 2, len(mockDestination.Get()))
|
|
assert.Empty(t, mockDestination.Get()[1].Emails)
|
|
|
|
// send confirmation token for email
|
|
req, err = http.NewRequest(
|
|
http.MethodPost,
|
|
ts.URL+"/api/v1/email/subscribe",
|
|
io.NopCloser(strings.NewReader(`{"site": "remark42", "address": "good@example.com"}`)),
|
|
)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
// wait for mock notification Submit to kick off
|
|
time.Sleep(time.Millisecond * 30)
|
|
require.Equal(t, 1, len(mockDestination.GetVerify()))
|
|
assert.Equal(t, "good@example.com", mockDestination.GetVerify()[0].Email)
|
|
verificationToken := mockDestination.GetVerify()[0].Token
|
|
|
|
// get user information to verify lack of the subscription
|
|
req, err = http.NewRequest(
|
|
http.MethodGet,
|
|
ts.URL+"/api/v1/user?site=remark42",
|
|
http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var clearUser store.User
|
|
err = json.Unmarshal(body, &clearUser)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "developer one", ID: "dev", EmailSubscription: false,
|
|
Picture: "http://example.com/pic.png", IP: "127.0.0.1", SiteID: "remark42"}, clearUser)
|
|
|
|
// verify email
|
|
req, err = http.NewRequest(
|
|
http.MethodPost,
|
|
ts.URL+"/api/v1/email/confirm",
|
|
io.NopCloser(strings.NewReader(fmt.Sprintf(`{"site": "remark42", "token": %q}`, verificationToken))),
|
|
)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
|
|
// get user information to verify the subscription
|
|
req, err = http.NewRequest(
|
|
http.MethodGet,
|
|
ts.URL+"/api/v1/user?site=remark42",
|
|
http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var subscribedUser store.User
|
|
err = json.Unmarshal(body, &subscribedUser)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "developer one", ID: "dev", EmailSubscription: true,
|
|
Picture: "http://example.com/pic.png", IP: "127.0.0.1", SiteID: "remark42"}, subscribedUser)
|
|
|
|
// create child comment from another user, email notification expected
|
|
req, err = http.NewRequest("POST", ts.URL+"/api/v1/comment", strings.NewReader(fmt.Sprintf(
|
|
`{"text": "test 789",
|
|
"pid": %q,
|
|
"user": {"name": "other_user"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`, parentComment.ID)))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", anonToken)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
// wait for mock notification Submit to kick off
|
|
time.Sleep(time.Millisecond * 30)
|
|
require.Equal(t, 3, len(mockDestination.Get()))
|
|
assert.Equal(t, []string{"good@example.com"}, mockDestination.Get()[2].Emails)
|
|
|
|
// delete user's email
|
|
req, err = http.NewRequest(http.MethodDelete, ts.URL+"/api/v1/email?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
|
|
// create child comment from another user, no email notification
|
|
req, err = http.NewRequest("POST", ts.URL+"/api/v1/comment", strings.NewReader(
|
|
`{"text": "test 321",
|
|
"user": {"name": "other_user"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
// wait for mock notification Submit to kick off
|
|
time.Sleep(time.Millisecond * 30)
|
|
require.Equal(t, 4, len(mockDestination.Get()))
|
|
assert.Empty(t, mockDestination.Get()[3].Emails)
|
|
|
|
// confirm email via subscribe call with query params, old behavior, email notification is expected
|
|
req, err = http.NewRequest(
|
|
http.MethodPost,
|
|
ts.URL+"/api/v1/email/subscribe?site=remark42&address=good@example.com",
|
|
http.NoBody,
|
|
)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", emailUserToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
// wait for mock notification Submit to kick off
|
|
time.Sleep(time.Millisecond * 30)
|
|
require.Equal(t, 2, len(mockDestination.GetVerify()), "verification email was sent")
|
|
|
|
// get email user information to verify there is no subscription yet
|
|
req, err = http.NewRequest(
|
|
http.MethodGet,
|
|
ts.URL+"/api/v1/user?site=remark42",
|
|
http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", emailUserToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var unsubscribedEmailUser store.User
|
|
err = json.Unmarshal(body, &unsubscribedEmailUser)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "good@example.com test user", ID: "email_f5dfe9d2e6bd75fc74ea5fabf273b45b5baeb195", EmailSubscription: false,
|
|
Picture: "http://example.com/pic.png", IP: "127.0.0.1", SiteID: "remark42"}, unsubscribedEmailUser)
|
|
|
|
// confirm email via subscribe call, no email notification is expected
|
|
req, err = http.NewRequest(
|
|
http.MethodPost,
|
|
ts.URL+"/api/v1/email/subscribe",
|
|
io.NopCloser(strings.NewReader(`{"site": "remark42", "address": "good@example.com"}`)),
|
|
)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", emailUserToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
// wait for mock notification Submit to kick off
|
|
time.Sleep(time.Millisecond * 30)
|
|
require.Equal(t, 2, len(mockDestination.GetVerify()), "no new verification email was sent")
|
|
|
|
// get email user information to verify the subscription happened without the confirmation call
|
|
req, err = http.NewRequest(
|
|
http.MethodGet,
|
|
ts.URL+"/api/v1/user?site=remark42",
|
|
http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", emailUserToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var subscribedEmailUser store.User
|
|
err = json.Unmarshal(body, &subscribedEmailUser)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "good@example.com test user", ID: "email_f5dfe9d2e6bd75fc74ea5fabf273b45b5baeb195", EmailSubscription: true,
|
|
Picture: "http://example.com/pic.png", IP: "127.0.0.1", SiteID: "remark42"}, subscribedEmailUser)
|
|
}
|
|
|
|
func TestRest_TelegramNotification(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
mockDestination := ¬ify.MockDest{}
|
|
srv.privRest.notifyService = notify.NewService(srv.DataService, 1, mockDestination)
|
|
defer srv.privRest.notifyService.Close()
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
|
|
// create new comment from dev user
|
|
req, err := http.NewRequest("POST", ts.URL+"/api/v1/comment", strings.NewReader(
|
|
`{"text": "test 123",
|
|
"user": {"name": "dev::good@example.com"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
parentComment := store.Comment{}
|
|
require.NoError(t, render.DecodeJSON(strings.NewReader(string(body)), &parentComment))
|
|
// wait for mock notification Submit to kick off
|
|
time.Sleep(time.Millisecond * 30)
|
|
require.Equal(t, 1, len(mockDestination.Get()))
|
|
assert.Empty(t, mockDestination.Get()[0].Telegrams)
|
|
|
|
// create child comment from another user, telegram notification only to admin expected
|
|
req, err = http.NewRequest("POST", ts.URL+"/api/v1/comment", strings.NewReader(fmt.Sprintf(
|
|
`{"text": "test 456",
|
|
"pid": %q,
|
|
"user": {"name": "other_user"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`, parentComment.ID)))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", anonToken)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
// wait for mock notification Submit to kick off
|
|
time.Sleep(time.Millisecond * 30)
|
|
require.Equal(t, 2, len(mockDestination.Get()))
|
|
assert.Empty(t, mockDestination.Get()[1].Telegrams)
|
|
|
|
// subscribe to telegram while the telegram destination is absent
|
|
req, err = http.NewRequest(http.MethodGet, ts.URL+"/api/v1/telegram/subscribe?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusInternalServerError, resp.StatusCode, string(body))
|
|
assert.Equal(t, `{"code":17,"details":"telegram notifications are not enabled","error":"not enabled"}`+"\n", string(body))
|
|
|
|
mockTlgrm := &mockTelegram{notVerified: true, site: "unknown_site"}
|
|
srv.privRest.telegramService = mockTlgrm
|
|
// send confirmation token for telegram
|
|
req, err = http.NewRequest(http.MethodGet, ts.URL+"/api/v1/telegram/subscribe?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var subscribeRequest struct {
|
|
Bot string `json:"bot"`
|
|
Token string `json:"token"`
|
|
}
|
|
err = json.Unmarshal(body, &subscribeRequest)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "botUsername", subscribeRequest.Bot)
|
|
|
|
// verify telegram, unsuccessfully because of not verified
|
|
req, err = http.NewRequest(http.MethodGet, ts.URL+fmt.Sprintf("/api/v1/telegram/subscribe?site=remark42&tkn=%s", subscribeRequest.Token), http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusInternalServerError, resp.StatusCode, string(body))
|
|
require.Equal(t, `{"code":0,"details":"can't set telegram for user","error":"not verified"}`+"\n", string(body))
|
|
|
|
mockTlgrm.notVerified = false
|
|
|
|
// verify telegram, unsuccessfully because of unknown site
|
|
req, err = http.NewRequest(http.MethodGet, ts.URL+fmt.Sprintf("/api/v1/telegram/subscribe?site=remark42&tkn=%s", subscribeRequest.Token), http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusBadRequest, resp.StatusCode, string(body))
|
|
require.Equal(t, `{"code":0,"details":"can't set telegram for user","error":"site \"unknown_site\" not found"}`+"\n", string(body))
|
|
|
|
mockTlgrm.site = "remark42"
|
|
// verify telegram, successfully
|
|
req, err = http.NewRequest(http.MethodGet, ts.URL+fmt.Sprintf("/api/v1/telegram/subscribe?site=remark42&tkn=%s", subscribeRequest.Token), http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var subscribeResult struct {
|
|
Address string `json:"address"`
|
|
Updated bool `json:"updated"`
|
|
}
|
|
err = json.Unmarshal(body, &subscribeResult)
|
|
assert.NoError(t, err)
|
|
assert.True(t, subscribeResult.Updated)
|
|
|
|
// get user information to verify the subscription
|
|
req, err = http.NewRequest(http.MethodGet, ts.URL+"/api/v1/user?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
var user store.User
|
|
err = json.Unmarshal(body, &user)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "developer one", ID: "dev",
|
|
Picture: "http://example.com/pic.png", IP: "127.0.0.1", SiteID: "remark42"}, user)
|
|
|
|
// create child comment from another user, telegram notification expected
|
|
req, err = http.NewRequest("POST", ts.URL+"/api/v1/comment", strings.NewReader(fmt.Sprintf(
|
|
`{"text": "test 789",
|
|
"pid": %q,
|
|
"user": {"name": "other_user"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`, parentComment.ID)))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", anonToken)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
// wait for mock notification Submit to kick off
|
|
time.Sleep(time.Millisecond * 30)
|
|
require.Equal(t, 3, len(mockDestination.Get()))
|
|
assert.Equal(t, []string{"good_telegram"}, mockDestination.Get()[2].Telegrams)
|
|
|
|
// delete user's telegram
|
|
req, err = http.NewRequest(http.MethodDelete, ts.URL+"/api/v1/telegram?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode, string(body))
|
|
|
|
// create child comment from another user, no telegram notification
|
|
req, err = http.NewRequest("POST", ts.URL+"/api/v1/comment", strings.NewReader(
|
|
`{"text": "test 321",
|
|
"user": {"name": "other_user"},
|
|
"locator":{"url": "https://radio-t.com/blah1",
|
|
"site": "remark42"}}`))
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
body, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(body))
|
|
// wait for mock notification Submit to kick off
|
|
time.Sleep(time.Millisecond * 30)
|
|
require.Equal(t, 4, len(mockDestination.Get()))
|
|
assert.Empty(t, mockDestination.Get()[3].Telegrams)
|
|
}
|
|
|
|
func TestRest_UserAllData(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
// write 3 comments
|
|
user := store.User{ID: "dev", Name: "user name 1"}
|
|
c1 := store.Comment{User: user, Text: "test test #1", Locator: store.Locator{SiteID: "remark42",
|
|
URL: "https://radio-t.com/blah1"}, Timestamp: time.Date(2018, 5, 27, 1, 14, 10, 0, time.Local)}
|
|
c2 := store.Comment{User: user, Text: "test test #2", ParentID: "p1", Locator: store.Locator{SiteID: "remark42",
|
|
URL: "https://radio-t.com/blah1"}, Timestamp: time.Date(2018, 5, 27, 1, 14, 20, 0, time.Local)}
|
|
c3 := store.Comment{User: user, Text: "test test #3", ParentID: "p1", Locator: store.Locator{SiteID: "remark42",
|
|
URL: "https://radio-t.com/blah1"}, Timestamp: time.Date(2018, 5, 27, 1, 14, 25, 0, time.Local)}
|
|
_, err := srv.DataService.Create(c1)
|
|
require.NoError(t, err, "%+v", err)
|
|
_, err = srv.DataService.Create(c2)
|
|
require.NoError(t, err)
|
|
_, err = srv.DataService.Create(c3)
|
|
require.NoError(t, err)
|
|
|
|
client := &http.Client{Timeout: 1 * time.Second}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest("GET", ts.URL+"/api/v1/userdata?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
require.Equal(t, "application/gzip", resp.Header.Get("Content-Type"))
|
|
|
|
ungzReader, err := gzip.NewReader(resp.Body)
|
|
assert.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
ungzBody, err := io.ReadAll(ungzReader)
|
|
assert.NoError(t, err)
|
|
strUungzBody := string(ungzBody)
|
|
assert.True(t, strings.HasPrefix(strUungzBody,
|
|
`{"info": {"name":"developer one","id":"dev","picture":"http://example.com/pic.png","ip":"127.0.0.1","admin":false,"site_id":"remark42"}, "comments":[{`))
|
|
assert.Equal(t, 3, strings.Count(strUungzBody, `"text":`), "3 comments inside")
|
|
|
|
parsed := struct {
|
|
Info store.User `json:"info"`
|
|
Comments []store.Comment `json:"comments"`
|
|
}{}
|
|
|
|
err = json.Unmarshal(ungzBody, &parsed)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, store.User{Name: "developer one", ID: "dev",
|
|
Picture: "http://example.com/pic.png", IP: "127.0.0.1", SiteID: "remark42"}, parsed.Info)
|
|
assert.Equal(t, 3, len(parsed.Comments))
|
|
|
|
req, err = http.NewRequest("GET", ts.URL+"/api/v1/userdata?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
resp, err = client.Do(req)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusUnauthorized, resp.StatusCode)
|
|
}
|
|
|
|
func TestRest_UserAllDataManyComments(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
user := store.User{ID: "dev", Name: "user name 1"}
|
|
c := store.Comment{User: user, Text: "test test #1", Locator: store.Locator{SiteID: "remark42",
|
|
URL: "https://radio-t.com/blah1"}, Timestamp: time.Date(2018, 5, 27, 1, 14, 10, 0, time.Local)}
|
|
|
|
for i := 0; i < 51; i++ {
|
|
c.ID = fmt.Sprintf("id-%03d", i)
|
|
c.Timestamp = c.Timestamp.Add(time.Second)
|
|
_, err := srv.DataService.Create(c)
|
|
require.NoError(t, err)
|
|
}
|
|
client := &http.Client{Timeout: 1 * time.Second}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest("GET", ts.URL+"/api/v1/userdata?site=remark42", http.NoBody)
|
|
require.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
require.Equal(t, http.StatusOK, resp.StatusCode)
|
|
require.Equal(t, "application/gzip", resp.Header.Get("Content-Type"))
|
|
|
|
ungzReader, err := gzip.NewReader(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
ungzBody, err := io.ReadAll(ungzReader)
|
|
assert.NoError(t, err)
|
|
strUngzBody := string(ungzBody)
|
|
assert.True(t, strings.HasPrefix(strUngzBody,
|
|
`{"info": {"name":"developer one","id":"dev","picture":"http://example.com/pic.png","ip":"127.0.0.1","admin":false,"site_id":"remark42"}, "comments":[{`))
|
|
assert.Equal(t, 51, strings.Count(strUngzBody, `"text":`), "51 comments inside")
|
|
}
|
|
|
|
func TestRest_DeleteMe(t *testing.T) {
|
|
ts, srv, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPost, fmt.Sprintf("%s/api/v1/deleteme?site=remark42", ts.URL), http.NoBody)
|
|
assert.NoError(t, err)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
body, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, resp.Body.Close())
|
|
assert.NoError(t, err)
|
|
|
|
m := map[string]string{}
|
|
err = json.Unmarshal(body, &m)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "remark42", m["site"])
|
|
assert.Equal(t, "dev", m["user_id"])
|
|
|
|
tkn := m["token"]
|
|
claims, err := srv.Authenticator.TokenService().Parse(tkn)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "dev", claims.User.ID)
|
|
assert.Equal(t, "https://demo.remark42.com/web/deleteme.html?token="+tkn, m["link"])
|
|
|
|
req, err = http.NewRequest(http.MethodPost, fmt.Sprintf("%s/api/v1/deleteme?site=remark42", ts.URL), http.NoBody)
|
|
assert.NoError(t, err)
|
|
resp, err = client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusUnauthorized, resp.StatusCode)
|
|
assert.NoError(t, resp.Body.Close())
|
|
}
|
|
|
|
func TestRest_SavePictureCtrl(t *testing.T) {
|
|
ts, _, teardown := startupT(t)
|
|
defer teardown()
|
|
|
|
// save picture
|
|
savePic := func(name string) (id string) {
|
|
bodyBuf := &bytes.Buffer{}
|
|
bodyWriter := multipart.NewWriter(bodyBuf)
|
|
fileWriter, err := bodyWriter.CreateFormFile("file", name)
|
|
require.NoError(t, err)
|
|
_, err = io.Copy(fileWriter, gopherPNG())
|
|
require.NoError(t, err)
|
|
contentType := bodyWriter.FormDataContentType()
|
|
require.NoError(t, bodyWriter.Close())
|
|
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPost, fmt.Sprintf("%s/api/v1/picture", ts.URL), bodyBuf)
|
|
require.NoError(t, err)
|
|
req.Header.Add("Content-Type", contentType)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
body, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
|
|
m := map[string]string{}
|
|
err = json.Unmarshal(body, &m)
|
|
assert.NoError(t, err)
|
|
assert.True(t, m["id"] != "")
|
|
return m["id"]
|
|
}
|
|
|
|
id := savePic("picture.png")
|
|
resp, err := http.Get(fmt.Sprintf("%s/api/v1/picture/%s", ts.URL, id))
|
|
require.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
body, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, 1462, len(body))
|
|
assert.Equal(t, "image/png", resp.Header.Get("Content-Type"))
|
|
|
|
id = savePic("picture.gif")
|
|
resp, err = http.Get(fmt.Sprintf("%s/api/v1/picture/%s", ts.URL, id))
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
assert.Equal(t, "image/png", resp.Header.Get("Content-Type"))
|
|
|
|
id = savePic("picture.jpg")
|
|
resp, err = http.Get(fmt.Sprintf("%s/api/v1/picture/%s", ts.URL, id))
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
assert.Equal(t, "image/png", resp.Header.Get("Content-Type"))
|
|
|
|
id = savePic("picture.blah")
|
|
resp, err = http.Get(fmt.Sprintf("%s/api/v1/picture/%s", ts.URL, id))
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
assert.Equal(t, "image/png", resp.Header.Get("Content-Type"))
|
|
|
|
resp, err = http.Get(fmt.Sprintf("%s/api/v1/picture/blah/pic.blah", ts.URL))
|
|
require.NoError(t, err)
|
|
require.NoError(t, resp.Body.Close())
|
|
assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
|
|
}
|
|
|
|
func TestRest_CreateWithPictures(t *testing.T) {
|
|
ts, svc, teardown := startupT(t)
|
|
defer func() {
|
|
teardown()
|
|
assert.NoError(t, os.RemoveAll("/tmp/remark42"))
|
|
}()
|
|
lgr.Setup(lgr.Debug, lgr.CallerFile, lgr.CallerFunc)
|
|
|
|
imageService := image.NewService(&image.FileSystem{
|
|
Staging: "/tmp/remark42/images.staging",
|
|
Location: "/tmp/remark42/images",
|
|
}, image.ServiceParams{
|
|
EditDuration: 100 * time.Millisecond,
|
|
MaxSize: 2000,
|
|
ImageAPI: svc.RemarkURL + "/api/v1/picture/",
|
|
ProxyAPI: svc.RemarkURL + "/api/v1/img",
|
|
})
|
|
defer imageService.Close(context.Background())
|
|
|
|
svc.privRest.imageService = imageService
|
|
svc.ImageService = imageService
|
|
|
|
dataService := svc.DataService
|
|
dataService.ImageService = svc.ImageService
|
|
svc.privRest.dataService = dataService
|
|
|
|
uploadPicture := func(file string) (id string) {
|
|
bodyBuf := &bytes.Buffer{}
|
|
bodyWriter := multipart.NewWriter(bodyBuf)
|
|
fileWriter, err := bodyWriter.CreateFormFile("file", file)
|
|
require.NoError(t, err)
|
|
_, err = io.Copy(fileWriter, gopherPNG())
|
|
require.NoError(t, err)
|
|
contentType := bodyWriter.FormDataContentType()
|
|
require.NoError(t, bodyWriter.Close())
|
|
client := http.Client{}
|
|
defer client.CloseIdleConnections()
|
|
req, err := http.NewRequest(http.MethodPost, fmt.Sprintf("%s/api/v1/picture", ts.URL), bodyBuf)
|
|
require.NoError(t, err)
|
|
req.Header.Add("Content-Type", contentType)
|
|
req.Header.Add("X-JWT", devToken)
|
|
resp, err := client.Do(req)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusOK, resp.StatusCode)
|
|
|
|
body, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
m := map[string]string{}
|
|
err = json.Unmarshal(body, &m)
|
|
assert.NoError(t, err)
|
|
return m["id"]
|
|
}
|
|
|
|
var ids [3]string
|
|
|
|
for i := range ids {
|
|
ids[i] = uploadPicture(fmt.Sprintf("pic%d.png", i))
|
|
}
|
|
|
|
text := fmt.Sprintf(`text 123  *xxx*  `, svc.RemarkURL, ids[0], svc.RemarkURL, ids[1], svc.RemarkURL, ids[2])
|
|
body := fmt.Sprintf(`{"text": %q, "locator":{"url": "https://radio-t.com/blah1", "site": "remark42"}}`, text)
|
|
|
|
resp, err := post(t, ts.URL+"/api/v1/comment", body)
|
|
assert.NoError(t, err)
|
|
b, err := io.ReadAll(resp.Body)
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, resp.Body.Close())
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode, string(b))
|
|
|
|
for i := range ids {
|
|
_, err = os.Stat("/tmp/remark42/images/" + ids[i])
|
|
assert.Error(t, err, "picture %d not moved from staging yet", i)
|
|
}
|
|
|
|
time.Sleep(1500 * time.Millisecond)
|
|
|
|
for i := range ids {
|
|
_, err = os.Stat("/tmp/remark42/images/" + ids[i])
|
|
assert.NoError(t, err, "picture %d moved from staging and available in permanent location", i)
|
|
}
|
|
}
|
|
|
|
type mockTelegram struct {
|
|
notVerified bool
|
|
site string
|
|
}
|
|
|
|
func (m *mockTelegram) AddToken(string, string, string, time.Time) {}
|
|
|
|
func (m *mockTelegram) GetBotUsername() string {
|
|
return "botUsername"
|
|
}
|
|
|
|
func (m *mockTelegram) CheckToken(string, string) (telegram, site string, err error) {
|
|
if m.notVerified {
|
|
return "", "", fmt.Errorf("not verified")
|
|
}
|
|
return "good_telegram", m.site, nil
|
|
}
|