* improve TestServer* reliability * improve TestService_UserReplies reliability * increase timeout for Test_Main * improve TestRest_CreateWithPictures readability and reliability * introduce random port to REST over SSL tests * tinker TestRest_InfoStreamSince to have more slack before failure * finalize test errors check unification * simplify prepServerApp in cmd package tests * improve TestRest_InfoStreamCancel reliability
124 lines
3.9 KiB
Go
124 lines
3.9 KiB
Go
package notify
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/go-chi/chi"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/umputun/remark/backend/app/store"
|
|
)
|
|
|
|
func TestTelegram_New(t *testing.T) {
|
|
|
|
ts := mockTelegramServer()
|
|
defer ts.Close()
|
|
|
|
tb, err := NewTelegram("good-token", "remark_test", 2*time.Second, ts.URL+"/")
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, tb)
|
|
assert.Equal(t, "@remark_test", tb.channelID, "@ added")
|
|
|
|
st := time.Now()
|
|
_, err = NewTelegram("bad-resp", "remark_test", 2*time.Second, ts.URL+"/")
|
|
assert.EqualError(t, err, "unexpected telegram response {OK:false Result:{FirstName:comments_test ID:707381019 IsBot:false UserName:remark42_test_bot}}")
|
|
assert.True(t, time.Since(st) >= 250*5*time.Millisecond)
|
|
|
|
_, err = NewTelegram("non-json-resp", "remark_test", 2*time.Second, ts.URL+"/")
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "can't decode response:")
|
|
|
|
_, err = NewTelegram("404", "remark_test", 2*time.Second, ts.URL+"/")
|
|
assert.EqualError(t, err, "unexpected telegram status code 404")
|
|
|
|
_, err = NewTelegram("no-such-thing", "remark_test", 2*time.Second, "http://127.0.0.1:4321/")
|
|
assert.EqualError(t, err, "can't initialize telegram notifications: Get http://127.0.0.1:4321/no-such-thing/getMe: dial tcp 127.0.0.1:4321: connect: connection refused")
|
|
|
|
_, err = NewTelegram("good-token", "remark_test", 2*time.Second, "")
|
|
assert.Error(t, err, "empty api url not allowed")
|
|
|
|
_, err = NewTelegram("good-token", "remark_test", 0, ts.URL+"/")
|
|
assert.NoError(t, err, "0 timeout allowed as default")
|
|
|
|
tb, err = NewTelegram("good-token", "1234567890", 2*time.Second, ts.URL+"/")
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, tb)
|
|
assert.Equal(t, "1234567890", tb.channelID, "no @ prefix")
|
|
}
|
|
|
|
func TestTelegram_Send(t *testing.T) {
|
|
ts := mockTelegramServer()
|
|
defer ts.Close()
|
|
|
|
tb, err := NewTelegram("good-token", "remark_test", 2*time.Second, ts.URL+"/")
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, tb)
|
|
c := store.Comment{Text: "some text", ParentID: "1", ID: "999"}
|
|
c.User.Name = "from"
|
|
cp := store.Comment{Text: "some parent text"}
|
|
cp.User.Name = "to"
|
|
|
|
err = tb.Send(context.TODO(), Request{Comment: c, parent: cp})
|
|
assert.NoError(t, err)
|
|
c.PostTitle = "test title"
|
|
err = tb.Send(context.TODO(), Request{Comment: c, parent: cp})
|
|
assert.NoError(t, err)
|
|
|
|
tb, err = NewTelegram("non-json-resp", "remark_test", 2*time.Second, ts.URL+"/")
|
|
assert.Error(t, err, "should failed")
|
|
err = tb.Send(context.TODO(), Request{Comment: c, parent: cp})
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "unexpected telegram status code 404", "send on broken tg")
|
|
|
|
assert.Equal(t, "telegram: @remark_test", tb.String())
|
|
require.NoError(t, tb.Send(context.TODO(), Request{}), "Empty Comment doesn't send anything")
|
|
}
|
|
|
|
func mockTelegramServer() *httptest.Server {
|
|
router := chi.NewRouter()
|
|
router.Get("/good-token/getMe", func(w http.ResponseWriter, r *http.Request) {
|
|
s := `{"ok": true,
|
|
"result": {
|
|
"first_name": "comments_test",
|
|
"id": 707381019,
|
|
"is_bot": true,
|
|
"username": "remark42_test_bot"
|
|
}}`
|
|
_, _ = w.Write([]byte(s))
|
|
})
|
|
router.Get("/bad-resp/getMe", func(w http.ResponseWriter, r *http.Request) {
|
|
s := `{"ok": false,
|
|
"result": {
|
|
"first_name": "comments_test",
|
|
"id": 707381019,
|
|
"is_bot": false,
|
|
"username": "remark42_test_bot"
|
|
}}`
|
|
_, _ = w.Write([]byte(s))
|
|
})
|
|
router.Get("/non-json-resp/getMe", func(w http.ResponseWriter, r *http.Request) {
|
|
s := `"ok": false,
|
|
"result": {
|
|
"first_name": "comments_test",
|
|
"id": 707381019,
|
|
"is_bot": false,
|
|
"username": "remark42_test_bot"
|
|
`
|
|
_, _ = w.Write([]byte(s))
|
|
})
|
|
router.Get("/404/getMe", func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(404)
|
|
})
|
|
|
|
router.Post("/good-token/sendMessage", func(w http.ResponseWriter, r *http.Request) {
|
|
_, _ = w.Write([]byte(`{"ok": true}`))
|
|
})
|
|
|
|
return httptest.NewServer(router)
|
|
}
|