* Require node 20 and record every place the version is pinned The declared floor was >=18 while CI, Docker and both .nvmrc files had been on 20 since the pnpm 8 to 10 migration, and transitive dependencies now require 20.18.1. The docs had drifted further still, telling contributors to install Node 16 and PNPM 8. * Set the node floor to the strictest dependency and keep one checklist undici needs >=20.18.1, so a bare >=20 advertised support for 20.0 to 20.18.0, which fail dependency engine checks. frontend/CLAUDE.md already carried a pinning checklist, so the new entries fold into it rather than starting a rival list in the root file. * Keep the node floor at the major, not a patch version engines.node states the major we support. Individual dev dependencies can be stricter within it, and chasing those patch floors into engines and the docs would turn every lockfile refresh into a docs change.
5.8 KiB
Remark42 Development Guidelines
Build/Test/Lint Commands
- Backend:
- Run server:
make rundev - Build:
make backend - Race test:
make race_test
- Run server:
- Backend Testing:
- Run all tests:
cd backend/app && go test -timeout=60s -count 1 ./... - Run single test:
cd backend/app && go test -run TestName ./path/to/package - IMPORTANT: Run example tests:
cd backend/_example/memory_store && go test -race ./... && go build -race ./...
- Run all tests:
- Frontend:
- Development:
cd frontend && pnpm dev:app - Tests:
cd frontend && pnpm test
- Development:
- Lint:
- Backend:
cd backend && golangci-lint run - IMPORTANT: Example lint:
cd backend/_example/memory_store && golangci-lint run --config ../../.golangci.yml - Frontend:
cd frontend && pnpm lint - Before committing: Always run tests and linter on both main backend AND examples
- Backend:
- Go module changes:
- Any change to
backend/go.modorbackend/go.sumrequiresgo mod tidyinbackend/_example/memory_storein the same commit. That covers dependency bumps, adding or removing a dependency, and changing thegodirective, not only version updates. - Only
go mod tidythere, notgo mod vendor: the example's vendor directory is gitignored (.gitignore:26), so its output is never committed, while a stale local copy silently becomes what the example resolves against. - The example module replaces
github.com/umputun/remark42/backendwith../../, so it carries the backend's dependencies as indirect entries. Leaving them stale fails thetest examplesCI step withgo: updates to go.mod needed; to update it: go mod tidy. - This applies to Dependabot pull requests too: the bot updates
backend/only, so its Go module PRs need the example tidied before they can go green.
- Any change to
Release Procedure
Remark42 uses two tags for each release:
vX.Y.Z- product release tag used by GitHub releases, GoReleaser binary artifacts, and Docker image publishing.backend/vX.Y.Z- nested Go module tag forgithub.com/umputun/remark42/backend.
Release flow:
- Create the GitHub release for
vX.Y.Zwith titleVersion X.Y.Z. The GitHub release must exist before thevX.Y.Ztag reaches the remote;gh release create vX.Y.Zsatisfies this because it creates and pushes the tag. - The
vX.Y.Ztag triggers GoReleaser, which builds and uploads binary artifacts to the existing release. - Create and push the matching backend module tag pointing at the same commit:
git fetch origin --tags
git tag backend/vX.Y.Z vX.Y.Z
git push origin backend/vX.Y.Z
GoReleaser must ignore backend/* tags in .goreleaser.yml so release notes and current-tag detection use only product tags. Docker image publishing stays separate and is handled by the existing Docker workflow.
For local artifact runs, install GoReleaser, Go 1.25, Node 20+, PNPM 10, and Perl, then use make release. The target runs a snapshot/no-publish GoReleaser build, leaves local artifacts and metadata in dist/, and cleans generated frontend embed files after GoReleaser exits. Do not run raw goreleaser release for local artifacts unless you also run ./scripts/cleanup-release-assets.sh afterward.
Milestones and Issue Labels
Milestones — one vX.Y.Z milestone per release. Assign every merged PR, and every issue closed by a code change, to the milestone of the release it shipped in.
- Decide which release a PR belongs to by whether its merge commit is contained in a release tag — not by comparing dates (a tag can be cut from an earlier commit, or moved).
git fetch --tags, thengit tag --contains <merge_sha> | grep '^v' | sort -V | head -1is its release. If no release tag contains it yet, it belongs to the next (unreleased) version's milestone — create it if missing (gh api repos/umputun/remark42/milestones -f title="vX.Y.Z"). - An issue gets a milestone only when it was closed by a code change (a linked closing PR/commit); take the milestone from that PR/commit (via the commit-in-tag rule). Issues closed as
duplicate/invalid/wontfix/answered get no milestone. - Find unassigned:
gh pr list --state merged --search "no:milestone",gh issue list --state closed --search "no:milestone". Assign withgh pr edit N --milestone "vX.Y.Z"/gh issue edit N --milestone "vX.Y.Z".
Issue labels — classify each issue with a type and an area (add priority when relevant):
- Type:
bug,enhancement,question,documentation,discussion - Area:
backend,frontend,site,CI,design,localization - Priority:
important,minor,some day - Contribution:
help wanted,good-first-issue - Resolution (on close, when applicable):
duplicate,invalid,wontfix,no-action-needed - PR auto-labels (applied by Dependabot/Actions, not manual PRs):
dependencies,go,javascript,github_actions
Code Style
- Backend: Formatting with golangci-lint, strict error handling
- Frontend: TypeScript with ESLint, Stylelint and Prettier
- Imports: Group stdlib, external packages, then internal packages
- CSS: All components use CSS Modules (
component.module.css). Class naming: BEM block =.root, elements = camelCase, modifiers = camelCase. Useclsxfor conditional class composition.raw-content.cssis the only global CSS file (syntax highlighting utility). Root wrapper keeps bare.dark/.lighttheme class — 8+ module CSS files depend on:global(.dark)ancestor.comment_highlightinguses:global()for imperativeclassListusage in root.tsx
Key Backend Packages
- Web/API:
github.com/go-pkgz/routegroup,github.com/go-pkgz/rest - Auth:
github.com/go-pkgz/auth/v2 - Logging:
github.com/go-pkgz/lgr - Testing:
github.com/stretchr/testify - Notifications:
github.com/go-pkgz/notify
Repository Structure
- Backend: Go server using BoltDB for storage
- Frontend: Preact/Redux-based UI with iframe embedding