From 1bef610416f70782e668ad3e84e8ecb2d5d309f9 Mon Sep 17 00:00:00 2001 From: Andy Grover Date: Wed, 2 Dec 2020 10:11:22 -0800 Subject: [PATCH] scoutfs: Don't destroy sroot unless srch_search_xattrs() was called Until then, sroot is uninitialized so it's not safe to call destroy_rb_root(). Signed-off-by: Andy Grover --- kmod/src/ioctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kmod/src/ioctl.c b/kmod/src/ioctl.c index 34d75200..7b1bb620 100644 --- a/kmod/src/ioctl.c +++ b/kmod/src/ioctl.c @@ -836,8 +836,10 @@ static long scoutfs_ioc_search_xattrs(struct file *file, unsigned long arg) ret = -EFAULT; else ret = 0; -out: + scoutfs_srch_destroy_rb_root(&sroot); + +out: kfree(name); return ret ?: total; }