mirrors/scoutfs
1
0
Fork 0
mirror of https://github.com/versity/scoutfs.git synced 2026-09-28 18:55:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update xattrs to use the item cache

Browse Source 
Update the xattrs to use the item cache.  Because we now have large keys
we can store the xattr at its full name instead of having to deal with
hashing the name and addressing collisions.

Now that we don't have the find xattr ioctls we don't need to maintain
backrefs.

We also add support for large xattrs that span multiple items.  The key
footer and value header give us the metadata we need to iterate over the
items that make up an xattr.

Signed-off-by: Zach Brown <zab@versity.com>
This commit is contained in:
Zach Brown
2017-04-18 13:44:54 -07:00
parent 64bc145e3c
commit 54e07470f1
6 changed files with 304 additions and 456 deletions
Download Patch File Download Diff File Expand all files Collapse all files
kmod/src/trans.c
+15 -16
View File
@@ -219,28 +219,27 @@ int scoutfs_file_fsync(struct file *file, loff_t start, loff_t end,
}
/*
* I think the holder that creates the most dirty item data is
* symlinking which can create an inode, the three dirent items with a
* full file name, and a symlink item with a full path.
* The holder that creates the most dirty item data is adding a full
* size xattr. The largest xattr can have a 255 byte name and 64KB
* value.
*
* XXX Assuming the worst case here too aggressively limits the number
* of concurrent holders that can work without being blocked when they
* know they'll dirty much less. We may want to have callers pass in
* their item, key, and val budgets if that's not too fragile.
*
* XXX fix to use real backref and symlink items, placeholders for now
*/
#define HOLD_WORST_ITEMS 5
#define HOLD_WORST_KEYS (sizeof(struct scoutfs_inode_key) + \
sizeof(struct scoutfs_dirent_key) + SCOUTFS_NAME_LEN +\
sizeof(struct scoutfs_readdir_key) + \
sizeof(struct scoutfs_readdir_key) + \
sizeof(struct scoutfs_inode_key))
#define HOLD_WORST_VALS (sizeof(struct scoutfs_inode) + \
sizeof(struct scoutfs_dirent) + \
sizeof(struct scoutfs_dirent) + SCOUTFS_NAME_LEN + \
sizeof(struct scoutfs_dirent) + SCOUTFS_NAME_LEN + \
SCOUTFS_SYMLINK_MAX_SIZE)
#define HOLD_WORST_ITEMS \
SCOUTFS_XATTR_MAX_PARTS
#define HOLD_WORST_KEYS \
(SCOUTFS_XATTR_MAX_PARTS * \
(sizeof(struct scoutfs_xattr_key) + \
SCOUTFS_XATTR_MAX_NAME_LEN + \
sizeof(struct scoutfs_xattr_key_footer)))
#define HOLD_WORST_VALS \
(sizeof(struct scoutfs_xattr_val_header) + \
SCOUTFS_XATTR_MAX_SIZE)
/*
* We're able to hold the transaction if the current dirty item bytes