mirrors/scoutfs
1
0
Fork 0
mirror of https://github.com/versity/scoutfs.git synced 2026-09-28 18:55:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

scoutfs: commit trans before premature enospc

Browse Source 
File data allocations come from radix allocators which are populated by
the server before each client transation.  It's possible to fully
consume the data allocator within one transaction if the number of dirty
metadata blocks is kept low.  This could result in premature ENOSPC.

This was happening to the archive-light-cycle test.  If the transactions
performed by previous tests lined up just right then the creation of the
initial test files could see ENOSPC and cause all sorts of nonsense in
the rest of the test, culminating in cmp commands stuck in offline
waits.

This introduces high and low data allocator water marks for
transactions.  The server tries to fill data allocators for each
transaction to the high water mark and the client forces the commit of a
transaction if its data allocator falls below the low water mark.

The archive-light-cycle test now passes easily and we see the
trans_commit_data_alloc_low counter increasing during the test.

Signed-off-by: Zach Brown <zab@versity.com>
This commit is contained in:
Zach Brown
2020-04-22 16:08:03 -07:00
committed by Zach Brown
parent 7da8ddb8a1
commit 9ad86d4d29
8 changed files with 41 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
kmod/src/data.c
+10
View File
@@ -2017,6 +2017,16 @@ void scoutfs_data_get_btrees(struct super_block *sb,
up_read(&datinf->alloc_rwsem);
}
/*
* This isn't serializing with allocators so it can be a bit racey.
*/
u64 scoutfs_data_alloc_free_bytes(struct super_block *sb)
{
DECLARE_DATA_INFO(sb, datinf);
return scoutfs_radix_root_free_bytes(sb, &datinf->data_avail);
}
int scoutfs_data_setup(struct super_block *sb)
{
struct scoutfs_sb_info *sbi = SCOUTFS_SB(sb);