mirror of
https://github.com/versity/scoutfs.git
synced 2025-12-23 05:25:18 +00:00
1b4d291bf7
As we update xattrs we need to update any existing old items with the contents of the new xattr that uses those items. The loop that updated existing items only took the old xattr size into account and assumed that the new xattr would use those items. If the new xattr size used fewer parts then the attempt to update all the old parts that weren't covered by the new size would go very wrong. The length of the region in the new xattr would be negative so it'd try to use the max part length. Worse, it'd copy these max part length regions outside the input new xattr buffer. Typically this would land in addressible memory and copy garbage into the unused old items before they were later deleted. However, it could access so far outside the input buffer that it could cross a page boudary into inaccessible memory and fault. We saw this in the field while trying to repeatedly incrementally shrink a large xattr. This fixes the loop that updates overlapping items between the new and old xattr to start with the smaller of their two item counts. Now it will only update items that are actually used by both xattrs and will only safely access the new xattr input buffer. Signed-off-by: Zach Brown <zab@versity.com>
20 lines
978 B
Plaintext
20 lines
978 B
Plaintext
=== XATTR_ flag combinations
|
|
dumb_setxattr -p /mnt/test/test/simple-xattr-unit/file -n user.test -v val -c -r
|
|
returned -1 errno 22 (Invalid argument)
|
|
dumb_setxattr -p /mnt/test/test/simple-xattr-unit/file -n user.test -v val -r
|
|
returned -1 errno 61 (No data available)
|
|
dumb_setxattr -p /mnt/test/test/simple-xattr-unit/file -n user.test -v val -c
|
|
returned 0
|
|
dumb_setxattr -p /mnt/test/test/simple-xattr-unit/file -n user.test -v val -c
|
|
returned -1 errno 17 (File exists)
|
|
dumb_setxattr -p /mnt/test/test/simple-xattr-unit/file -n user.test -v val -r
|
|
returned 0
|
|
=== bad lengths
|
|
setfattr: /mnt/test/test/simple-xattr-unit/file: Operation not supported
|
|
setfattr: /mnt/test/test/simple-xattr-unit/file: Numerical result out of range
|
|
setfattr: /mnt/test/test/simple-xattr-unit/file: Numerical result out of range
|
|
setfattr: /mnt/test/test/simple-xattr-unit/file: Argument list too long
|
|
=== good length boundaries
|
|
=== 500 random lengths
|
|
=== alternate val size between interesting sizes
|