mirror of
https://github.com/versity/scoutfs.git
synced 2026-04-18 12:35:03 +00:00
79fbaa6481
Our dir methods were trusting dentry args. The vfs code paths use i_mutex to protect dentries across revalidate or lookup and method calls. But that doesn't protect methods running in other mounts. Multiple nodes can interleave the initial lookup or revalidate then actual method call. Rename got this right. It is very paranoid about verifying inputs after acquiring all the locks it needs. We extend this pattern to the rest of the methods that need to use the mapping of name to inode (and our hash and pos) in dentries. Once we acquire the parent dir lock we verify that the dentry is still current, returning -EEXIST or -ENOENT as appropriate. Along these lines, we tighten up dentry info correctness a bit by updating our dentry info (recording lock coverage and hash/pos) for negative dentries produced by lookup or as the result of unlink. Signed-off-by: Zach Brown <zab@versity.com>