mirror of
https://github.com/versity/scoutfs.git
synced 2026-04-30 18:05:43 +00:00
533f309aec
In el9.6, the kernel VFS no longer goes through xattr handlers to
retreive ACLs, but instead calls the FS drivers' .get_{inode_}acl
method. In the initial compat version we hooked up to .get_acl given
the identical name that was used in the past.
However, this results in caching issues, as was encountered by customers
and exposed in the added test case `basic-acl-consistency`. The result
is that some group ACL entries may appear randomly missing. Dropping
caches may temporarily fix the issue.
The root cause of the issue is that the VFS now has 2 separate paths to
retreive ACL's from the FS driver, and, they have conflicting
implications for caching. `.get_acl` is purely meant for filesystems
like overlay/ecryptfs where no caching should ever go on as they are
fully passthrough only. Filesystems with dentries (i.e. all normal
filesystems should not expose this interface, and instead expose the
.get_inode_acl method. And indeed, in introducing the new interface, the
upstream kernel converts all but a few fs's to use .get_inode_acl().
The functional change in the driver is to detach KC_GET_ACL_DENTRY and
introduce KC_GET_INODE_ACL to handle the new (and required) interface.
KC_SET_ACL_DENTRY is detached due to it being a different changeset in
the kernel and we should separate these for good measure now.
Signed-off-by: Auke Kok <auke.kok@versity.com>
39 lines
1.6 KiB
C
39 lines
1.6 KiB
C
#ifndef _SCOUTFS_ACL_H_
|
|
#define _SCOUTFS_ACL_H_
|
|
|
|
#ifdef KC_SET_ACL_DENTRY
|
|
int scoutfs_set_acl(KC_VFS_NS_DEF
|
|
struct dentry *dentry, struct posix_acl *acl, int type);
|
|
#else
|
|
int scoutfs_set_acl(struct inode *inode, struct posix_acl *acl, int type);
|
|
#endif
|
|
#ifdef KC_GET_INODE_ACL
|
|
struct posix_acl *scoutfs_get_acl(struct inode *inode, int type, bool rcu);
|
|
#else
|
|
struct posix_acl *scoutfs_get_acl(struct inode *inode, int type);
|
|
#endif
|
|
struct posix_acl *scoutfs_get_acl_locked(struct inode *inode, int type, struct scoutfs_lock *lock);
|
|
int scoutfs_set_acl_locked(struct inode *inode, struct posix_acl *acl, int type,
|
|
struct scoutfs_lock *lock, struct list_head *ind_locks);
|
|
#ifdef KC_XATTR_STRUCT_XATTR_HANDLER
|
|
int scoutfs_acl_get_xattr(const struct xattr_handler *, struct dentry *dentry,
|
|
struct inode *inode, const char *name, void *value,
|
|
size_t size);
|
|
int scoutfs_acl_set_xattr(const struct xattr_handler *,
|
|
KC_VFS_NS_DEF
|
|
struct dentry *dentry,
|
|
struct inode *inode, const char *name, const void *value,
|
|
size_t size, int flags);
|
|
#else
|
|
int scoutfs_acl_get_xattr(struct dentry *dentry, const char *name, void *value, size_t size,
|
|
int type);
|
|
int scoutfs_acl_set_xattr(struct dentry *dentry, const char *name, const void *value, size_t size,
|
|
int flags, int type);
|
|
#endif
|
|
int scoutfs_acl_chmod_locked(struct inode *inode, struct iattr *attr,
|
|
struct scoutfs_lock *lock, struct list_head *ind_locks);
|
|
int scoutfs_init_acl_locked(struct inode *inode, struct inode *dir,
|
|
struct scoutfs_lock *lock, struct scoutfs_lock *dir_lock,
|
|
struct list_head *ind_locks);
|
|
#endif
|