From 0aa6689c3ac5496484c1631a8f60aeddc6ff8291 Mon Sep 17 00:00:00 2001 From: Gleb Chesnokov Date: Fri, 21 Aug 2026 13:39:13 +0300 Subject: [PATCH] scripts: Validate monitor intervals Reject zero and nonnumeric sampling intervals before entering the monitor loops, avoiding division errors and repeated failed sleep calls. --- scripts/monitor-interrupt-rate | 6 ++++++ scripts/monitor-memory-usage | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/monitor-interrupt-rate b/scripts/monitor-interrupt-rate index 7e81ed9a5..ee2e70be5 100755 --- a/scripts/monitor-interrupt-rate +++ b/scripts/monitor-interrupt-rate @@ -2,6 +2,12 @@ interval="${1:-5}" +if ! [[ "$interval" =~ ^0*[1-9][0-9]*$ ]]; then + echo "Error: interval must be a positive integer." >&2 + exit 1 +fi +interval="${interval#"${interval%%[!0]*}"}" + echo "Interrupts per second:" while true do diff --git a/scripts/monitor-memory-usage b/scripts/monitor-memory-usage index eabb74dba..09b5d33e2 100755 --- a/scripts/monitor-memory-usage +++ b/scripts/monitor-memory-usage @@ -50,10 +50,11 @@ do esac done -if [ "$#" != 0 ] || [ "${interval}" -le 0 ]; then +if [ "$#" != 0 ] || ! [[ "${interval}" =~ ^0*[1-9][0-9]*$ ]]; then usage exit 1 fi +interval="${interval#"${interval%%[!0]*}"}" ####################