From 1d98ab7e7a38f875e9c5e0e4b11add8b557af2b6 Mon Sep 17 00:00:00 2001 From: Vladislav Bolkhovitin Date: Wed, 12 Oct 2016 01:27:42 +0000 Subject: [PATCH 1/2] README.drbd: update to point to README.dlm for reservations sync Suggested-by: Curtis Maloney git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7008 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- scst/README.drbd | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scst/README.drbd b/scst/README.drbd index dbb6cc6a5..c187f73bb 100644 --- a/scst/README.drbd +++ b/scst/README.drbd @@ -21,6 +21,8 @@ settings for each DRBD block device exported via SCST: * Caching MUST be disabled: set the nv_cache parameter to 0 in scst.conf. * Write-through MUST be enabled: set the write_through parameter to 1 in scst.conf. +* If SCSI reservations are used, their sync between nodes must be enabled, + see README.dlm. DRBD Configuration ------------------ From 1f72d604cc7fa7bdfb63584e206fac9848d0ed0c Mon Sep 17 00:00:00 2001 From: Vladislav Bolkhovitin Date: Fri, 14 Oct 2016 01:30:17 +0000 Subject: [PATCH 2/2] iscsi-scst: fix false positive BUG_ON() It's false positive, because responses live in the parent request's list until last put for the parent. git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7009 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- iscsi-scst/kernel/iscsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/iscsi-scst/kernel/iscsi.c b/iscsi-scst/kernel/iscsi.c index def8bd7ea..53100ca00 100644 --- a/iscsi-scst/kernel/iscsi.c +++ b/iscsi-scst/kernel/iscsi.c @@ -579,7 +579,6 @@ void req_cmnd_release_force(struct iscsi_cmnd *req) sBUG_ON(req->cmd_req); sBUG_ON(req->main_rsp != NULL); sBUG_ON(!list_empty(&req->rx_ddigest_cmd_list)); - sBUG_ON(!list_empty(&req->rsp_cmd_list)); sBUG_ON(req->pending); cmnd_put(req);