From 1365d9b29da8370fa7d2c226c2ac5cc361811ac7 Mon Sep 17 00:00:00 2001
From: Bart Van Assche <bvanassche@acm.org>
Date: Mon, 19 Nov 2018 01:51:41 +0000
Subject: [PATCH] scripts/generate-release-archive: Fix shellcheck warnings and
 add -h to the tar command line

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/3.3.x@7814 d57e44dd-8a1f-0410-8b47-8ef2f437770f
---
 scripts/generate-release-archive | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/scripts/generate-release-archive b/scripts/generate-release-archive
index 45a737ac6..be6d04ebe 100755
--- a/scripts/generate-release-archive
+++ b/scripts/generate-release-archive
@@ -1,7 +1,7 @@
 #!/bin/bash
 
 usage() {
-    echo "Usage: $(basename $0) name version"
+    echo "Usage: $(basename "$0") name version"
 }
 
 if [ $# -lt 2 ]; then
@@ -14,12 +14,13 @@ name="$1"; shift
 version="$1"; shift
 files="$*"
 if [ -z "$files" ]; then
-    files=$($scriptdir/list-source-files)
+    read -d\\n -r -a files < <("$scriptdir/list-source-files")
     if [ -e build_mode ]; then
-	files="${files} build_mode"
+	files+=(build_mode)
     fi
 fi
 
-tar --owner=root --group=root --transform="s|^|$name-$version/|" \
-  -cjf $name-$version.tar.bz2 $files &&
-ls -l $name-$version.tar.bz2
+for f in "${files[@]}"; do echo "$f"; done | \
+    tar --owner=root --group=root --transform="s|^|$name-$version/|" \
+	-cjf "$name-$version.tar.bz2" -T- -h &&
+    ls -l "$name-$version.tar.bz2"