From 231218932b29d9bc89153219cf52e7ebce3bc759 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Wed, 6 May 2015 13:10:53 +0200 Subject: [PATCH] iscsi-scst: Tell Coverity when scst_aen is set This suppresses a Coverity complaint. Signed-off-by: Bart Van Assche --- iscsi-scst/kernel/iscsi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/iscsi-scst/kernel/iscsi.c b/iscsi-scst/kernel/iscsi.c index 95f2f1c02..f3df4c17b 100644 --- a/iscsi-scst/kernel/iscsi.c +++ b/iscsi-scst/kernel/iscsi.c @@ -454,6 +454,14 @@ void cmnd_done(struct iscsi_cmnd *cmnd) /* Order between above and below code is important! */ if ((cmnd->scst_cmd != NULL) || (cmnd->scst_aen != NULL)) { + /* + * Tell Coverity when cmnd->scst_cmd or scst_aen is set. + */ + if (cmnd->scst_state == ISCSI_CMD_STATE_AEN) + EXTRACHECKS_BUG_ON(!cmnd->scst_aen); + else + EXTRACHECKS_BUG_ON(!cmnd->scst_cmd); + switch (cmnd->scst_state) { case ISCSI_CMD_STATE_PROCESSED: TRACE_DBG("cmd %p PROCESSED", cmnd);