From 2df209ea5f832cc665bdff1652a754c86e3d96a9 Mon Sep 17 00:00:00 2001 From: Gleb Chesnokov Date: Wed, 5 Nov 2025 11:32:43 +0300 Subject: [PATCH] scstadmin: Fix precedence typo in error propagation Fix Perl precedence warnings: Possible precedence problem between ! and numeric gt (>) at SCST.pm line 980. Possible precedence problem between ! and numeric gt (>) at SCST.pm line 1223. Possible precedence problem between ! and numeric gt (>) at SCST.pm line 3847. --- scstadmin/scstadmin.sysfs/scst-1.0.0/lib/SCST/SCST.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scstadmin/scstadmin.sysfs/scst-1.0.0/lib/SCST/SCST.pm b/scstadmin/scstadmin.sysfs/scst-1.0.0/lib/SCST/SCST.pm index 0f5f9c826..af4738ddf 100644 --- a/scstadmin/scstadmin.sysfs/scst-1.0.0/lib/SCST/SCST.pm +++ b/scstadmin/scstadmin.sysfs/scst-1.0.0/lib/SCST/SCST.pm @@ -977,7 +977,7 @@ sub checkDriverDynamicAttributes { if (!defined($available)) { my $rc = $self->driverExists($driver); return SCST_C_DRV_NO_DRIVER if (!$rc); - return $rc if (!$rc > 1); + return $rc if ($rc > 1); return SCST_C_FATAL_ERROR; } @@ -1220,7 +1220,7 @@ sub checkTargetDynamicAttributes { if (!defined($available)) { my $rc = $self->driverExists($driver); return SCST_C_DRV_NO_DRIVER if (!$rc); - return $rc if (!$rc > 1); + return $rc if ($rc > 1); return SCST_C_FATAL_ERROR; } @@ -3844,7 +3844,7 @@ sub checkDeviceCreateAttributes { if (!defined($available)) { my $rc = $self->handlerExists($handler); return SCST_C_HND_NO_HANDLER if (!$rc); - return $rc if (!$rc > 1); + return $rc if ($rc > 1); return SCST_C_FATAL_ERROR; }