diff --git a/srpt/Testing.txt b/srpt/Testing.txt index 73cb1583e..6513ff7fc 100644 --- a/srpt/Testing.txt +++ b/srpt/Testing.txt @@ -6,7 +6,7 @@ At least the following tests must be run before releasing a new SRPT version: * Make sure that SRPT compiles and installs without triggering any compiler warning. Use the following command to compile and install SRPT: - for d in scst srpt; do make -C $d -s clean && make -C $d -s install; done + for d in scst srpt; do make -C $d -s clean && make -C $d -s install; done * Verify the output of run-regression-tests for kernel versions starting at 2.6.23 up to and including the latest released kernel. @@ -18,11 +18,11 @@ At least the following tests must be run before releasing a new SRPT version: * Verify that module loading and unloading works fine. * Verify that rejecting logins does not trigger a memory leak, e.g. as follows: - * Run the following command on the target system: - ${SCST_TRUNK}/scripts/monitor-memory-usage | tee memlog.txt - * Run the following command on the initiator system: + * Run the following command on the target system: + ${SCST_TRUNK}/scripts/monitor-memory-usage | tee memlog.txt + * Run the following command on the initiator system: target_id="$(/usr/sbin/ibsrpdm -c -d /dev/infiniband/umad0)" - for ((i=0;i<100000;i++)); do echo "$target_id" >/sys/class/infiniband_srp/srp-mlx4_0-1/add_target; done + for ((i=0;i<100000;i++)); do echo "$target_id" >/sys/class/infiniband_srp/srp-mlx4_0-1/add_target; done * Verify that the following I/O stress test does not report any errors even when left running for several hours: @@ -52,14 +52,14 @@ Index: srpt/src/ib_srpt.c --- srpt/src/ib_srpt.c (revision 2412) +++ srpt/src/ib_srpt.c (working copy) @@ -2411,7 +2411,7 @@ - ch->max_ti_iu_len = it_iu_len; - rsp->buf_fmt = __constant_cpu_to_be16(SRP_BUF_FORMAT_DIRECT - | SRP_BUF_FORMAT_INDIRECT); -- rsp->req_lim_delta = cpu_to_be32(ch->rq_size); -+ rsp->req_lim_delta = cpu_to_be32(ch->rq_size + 16); - atomic_set(&ch->req_lim, ch->rq_size); - - /* create cm reply */ + ch->max_ti_iu_len = it_iu_len; + rsp->buf_fmt = cpu_to_be16(SRP_BUF_FORMAT_DIRECT | + SRP_BUF_FORMAT_INDIRECT); +- rsp->req_lim_delta = cpu_to_be32(ch->rq_size); ++ rsp->req_lim_delta = cpu_to_be32(ch->rq_size + 16); + atomic_set(&ch->req_lim, ch->rq_size); + + /* create cm reply */ * Verify that a SCSI reset works properly by running the following command on an initiator system (note: with kernel version 2.6.37 and before the @@ -97,7 +97,7 @@ Index: srpt/src/ib_srpt.c dmesg -c echo "${target_id}" > /sys/class/infiniband_srp/srp-mlx4_0-1/add_target -* Test low memory conditions: load SRPT, reduce the amount of available +* Test low memory conditions: load SRPT, reduce the amount of available memory by creating a large file on a tmpfs file system and run a stress test on an initiator system. @@ -138,6 +138,3 @@ Index: srpt/src/ib_srpt.c - On the target, unload and reload the ib_srpt kernel module. - Verify that no kernel crash occurs on the target. - Repeat the above a few times. - -* Repeat the above tests for all three threading modes: thread=0, thread=1 - and thread=2.