diff --git a/www/contributing.html b/www/contributing.html index bddad8135..ffe550750 100644 --- a/www/contributing.html +++ b/www/contributing.html @@ -105,25 +105,6 @@ by pages, taken directly from dio->curr_user_address. Each such page should be referenced by page_cache_get(). That's all.
-At the moment, in scst_vdisk handler command execution function vdisk_do_job() is - overcomplicated and not very performance effective. It would be good to replace all those - ugly "switch" statements by choosing the handler for each SCSI command by indirect - function call on an array of function pointers.
- -I.e., there should be an array vdisk_exec_fns with 256 entries of function pointers:
- -void (*cmd_exec_fn) (struct scst_cmd *cmd)
- -Then vdisk_do_job() should look like
- -static int vdisk_do_job(struct scst_cmd *cmd)
- {
- return vdisk_exec_fns[cmd->cdb[0]](cmd);
- }
-
In the pass-through mode (i.e. using the pass-through device handlers like