From 49870b2348aebd94da7125db7a36136954ebc253 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Thu, 25 Nov 2021 00:37:08 +0000 Subject: [PATCH] scst_lib: Remove dead code Since block_shift is unsigned, it can never be negative. See also commit 1e95312e4999 ("Reenable block_shift calculation for tapes"). git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9605 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- scst/src/scst_lib.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/scst/src/scst_lib.c b/scst/src/scst_lib.c index ec22e0176..a3b7d207a 100644 --- a/scst/src/scst_lib.c +++ b/scst/src/scst_lib.c @@ -12491,8 +12491,6 @@ int scst_tape_generic_parse(struct scst_cmd *cmd) shift_left_overflows(cmd->data_len, block_shift) || shift_left_overflows(cmd->out_bufflen, block_shift); - EXTRACHECKS_BUG_ON(block_shift < 0); - BUILD_BUG_ON(sizeof(cmd->bufflen) != 4); BUILD_BUG_ON(sizeof(cmd->out_bufflen) != 4); if (unlikely(overflow)) {