From 4ad34f74d5f0aec2ccef4eed6690846095f55fa8 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Wed, 17 Jun 2015 00:30:16 +0000 Subject: [PATCH] fileio: Fix a potential buffer overflow Detected by Coverity. git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6384 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- usr/fileio/debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr/fileio/debug.c b/usr/fileio/debug.c index 8e93a70e1..296025302 100644 --- a/usr/fileio/debug.c +++ b/usr/fileio/debug.c @@ -52,11 +52,11 @@ int debug_print_prefix(unsigned long trace_flag, const char *prefix, time_t tt; time(&tt); localtime_r(&tt, &t); - i += snprintf(&trace_buf[i], TRACE_BUF_SIZE, "%d:%d:%d ", + i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, "%d:%d:%d ", t.tm_hour, t.tm_min, t.tm_sec); } if (trace_flag & TRACE_PID) - i += snprintf(&trace_buf[i], TRACE_BUF_SIZE, "[%d]: ", + i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, "[%d]: ", gettid()); if (prefix != NULL) i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, "%s:", prefix);