From 563e7c248c798d50a813dbc289125288ac10fba5 Mon Sep 17 00:00:00 2001 From: Vladislav Bolkhovitin Date: Sat, 5 Jan 2013 02:54:08 +0000 Subject: [PATCH] Avoid that scst_abort_cmd() triggers a false positive in Coverity Signed-off-by: Bart Van Assche git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4682 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- scst/src/scst_targ.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scst/src/scst_targ.c b/scst/src/scst_targ.c index 7141c133b..fc8b2851b 100644 --- a/scst/src/scst_targ.c +++ b/scst/src/scst_targ.c @@ -4799,6 +4799,13 @@ void scst_abort_cmd(struct scst_cmd *cmd, struct scst_mgmt_cmd *mcmd, TRACE_ENTRY(); + /* + * Help Coverity recognize that mcmd != NULL if + * call_dev_task_mgmt_fn_received == true. + */ + if (call_dev_task_mgmt_fn_received) + EXTRACHECKS_BUG_ON(!mcmd); + TRACE(TRACE_SCSI|TRACE_MGMT_DEBUG, "Aborting cmd %p (tag %llu, op %x)", cmd, (long long unsigned int)cmd->tag, cmd->cdb[0]);