From 56a29b3ca0848ae2d4d42f5d385c166857b2406c Mon Sep 17 00:00:00 2001 From: Vladislav Bolkhovitin Date: Mon, 27 Aug 2012 22:02:33 +0000 Subject: [PATCH] scst_lib: Remove two superfluous tests. Detected by smatch. Signed-off-by: Bart Van Assche git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4490 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- scst/src/scst_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scst/src/scst_lib.c b/scst/src/scst_lib.c index 3af37f1a6..17979082f 100644 --- a/scst/src/scst_lib.c +++ b/scst/src/scst_lib.c @@ -4160,7 +4160,7 @@ static int scst_alloc_add_tgt_dev(struct scst_session *sess, if (res != 0) goto out_pr_clear; - if (dev->handler && dev->handler->attach_tgt) { + if (dev->handler->attach_tgt) { TRACE_DBG("Calling dev handler's attach_tgt(%p)", tgt_dev); res = dev->handler->attach_tgt(tgt_dev); TRACE_DBG("%s", "Dev handler's attach_tgt() returned"); @@ -4191,7 +4191,7 @@ out: return res; out_detach: - if (dev->handler && dev->handler->detach_tgt) { + if (dev->handler->detach_tgt) { TRACE_DBG("Calling dev handler's detach_tgt(%p)", tgt_dev); dev->handler->detach_tgt(tgt_dev);