From 7ad87045dca287467dde7da5990a091ce1cf36bb Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Sat, 25 Feb 2017 01:54:58 +0000 Subject: [PATCH 1/2] scst_copy_mgr: Avoid that scst_cm_on_add_lun() triggers a kernel warning Avoid that the following warning is triggered: WARNING: CPU: 1 PID: 1282 at scst/src/scst_copy_mgr.c:2784 scst_cm_on_add_lun+0x141/0x1b0 [scst] Call Trace: dump_stack+0x86/0xc3 __warn+0xc1/0xe0 warn_slowpath_null+0x18/0x20 scst_cm_on_add_lun+0x141/0x1b0 [scst] scst_acg_add_lun+0x27f/0x370 [scst] __scst_process_luns_mgmt_store+0x589/0x5f0 [scst] scst_luns_mgmt_store_work_fn+0x22/0x30 [scst] scst_process_sysfs_works+0x7b/0x1c0 [scst] sysfs_work_thread_fn+0x11b/0x280 [scst] kthread+0x102/0x140 ret_from_fork+0x31/0x40 git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7098 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- scst/src/scst_copy_mgr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/scst/src/scst_copy_mgr.c b/scst/src/scst_copy_mgr.c index 3127dddea..2c633175b 100644 --- a/scst/src/scst_copy_mgr.c +++ b/scst/src/scst_copy_mgr.c @@ -2771,7 +2771,6 @@ int scst_cm_on_add_lun(struct scst_acg_dev *acg_dev, uint64_t lun, TRACE_ENTRY(); - scst_assert_activity_suspended(); lockdep_assert_held(&scst_mutex); if (acg_dev->acg != scst_cm_tgt->default_acg) From 19212e4f290c7ab2ffa9aed1b78384ed22f4abe4 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Sat, 25 Feb 2017 01:56:30 +0000 Subject: [PATCH 2/2] scst_copy_mgr: Avoid that scst_cm_check_access_acg() triggers a kernel warning Avoid that the following kernel warning is triggered: WARNING: CPU: 2 PID: 1761 at scst/src/scst_copy_mgr.c:2835 Call Trace: dump_stack+0x86/0xc3 __warn+0xc1/0xe0 warn_slowpath_null+0x18/0x20 scst_cm_check_access_acg+0x1c2/0x1d0 [scst] scst_cm_check_access+0x155/0x280 [scst] scst_cm_parse_id_tgt_descr+0x2e6/0x590 [scst] scst_cm_parse_descriptors+0x303/0xa60 [scst] scst_parse_descriptors+0x5b/0x130 [scst] scst_tgt_pre_exec+0x370/0x4a0 [scst] scst_process_active_cmd+0x455/0x770 [scst] scst_cmd_thread+0x1fb/0x690 [scst] kthread+0x102/0x140 ret_from_fork+0x31/0x40 git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7099 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- scst/src/scst_copy_mgr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/scst/src/scst_copy_mgr.c b/scst/src/scst_copy_mgr.c index 2c633175b..9dfb3d95c 100644 --- a/scst/src/scst_copy_mgr.c +++ b/scst/src/scst_copy_mgr.c @@ -2821,7 +2821,6 @@ static bool scst_cm_check_access_acg(const char *initiator_name, TRACE_ENTRY(); - scst_assert_activity_suspended(); lockdep_assert_held(&scst_mutex2); list_for_each_entry(acg_dev, &acg->acg_dev_list, acg_dev_list_entry) {