From 6432ad6263842ed55de3d1de4b3ff561109f34f9 Mon Sep 17 00:00:00 2001 From: Yan Burman Date: Thu, 3 Jul 2014 12:43:16 +0000 Subject: [PATCH] isert: Fix discovery over RDMA Commit r5655: isert: Handle login pdu reception in more robust way Broke discovery over RDMA. Fix it, as well as tidy up a few error prints in that area Signed-off-by: Yan Burman git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5660 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- iscsi-scst/kernel/isert-scst/isert_login.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/iscsi-scst/kernel/isert-scst/isert_login.c b/iscsi-scst/kernel/isert-scst/isert_login.c index 774dc72e6..fae0963e3 100644 --- a/iscsi-scst/kernel/isert-scst/isert_login.c +++ b/iscsi-scst/kernel/isert-scst/isert_login.c @@ -753,7 +753,7 @@ int isert_login_req_rx(struct iscsi_cmnd *login_req) TRACE_ENTRY(); if (!dev) { - PRINT_ERROR("Received PDU %p on invalid connection\n", + PRINT_ERROR("Received PDU %p on invalid connection", login_req); res = -EINVAL; goto out; @@ -761,6 +761,7 @@ int isert_login_req_rx(struct iscsi_cmnd *login_req) switch (dev->state) { case CS_INIT: + case CS_RSP_FINISHED: if (dev->login_req != NULL) { sBUG(); res = -EINVAL; @@ -775,9 +776,8 @@ int isert_login_req_rx(struct iscsi_cmnd *login_req) case CS_REQ_FINISHED: case CS_RSP_BHS: case CS_RSP_DATA: - case CS_RSP_FINISHED: - PRINT_WARNING("%s", - "Received login PDU while handling previous one\n"); + PRINT_WARNING("Received login PDU while handling previous one. State:%d", + dev->state); res = -EINVAL; goto out;