mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-22 05:01:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

qla2x00t-32gbit: Always check the qla2x00_wait_for_hba_online() return value

Browse Source 
This patch avoids that Coverity complains that the return value of
qla2x00_wait_for_hba_online() is not always checked.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8381 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Bart Van Assche
2019-05-27 22:08:26 +00:00
parent 9a9acef676
commit 6ab417a5ef
3 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
qla2x00t-32gbit/qla2x00-target/scst_qla2xxx.c
View File

@@ -1170,7 +1170,7 @@ static ssize_t sqa_abort_isp_store(struct kobject *kobj,
tgt->vha->vp_idx); tgt->vha->vp_idx);
set_bit(ISP_ABORT_NEEDED, &tgt->vha->dpc_flags); set_bit(ISP_ABORT_NEEDED, &tgt->vha->dpc_flags);
qla2x00_wait_for_hba_online(tgt->vha); WARN_ON_ONCE(qla2x00_wait_for_hba_online(tgt->vha) != QLA_SUCCESS);
return size; return size;
#endif #endif

3
qla2x00t-32gbit/qla_attr.c
View File

@@ -726,7 +726,8 @@ qla2x00_sysfs_write_reset(struct file *filp, struct kobject *kobj,
break; break;
} else { } else {
/* Make sure FC side is not in reset */ /* Make sure FC side is not in reset */
qla2x00_wait_for_hba_online(vha); WARN_ON_ONCE(qla2x00_wait_for_hba_online(vha) !=
QLA_SUCCESS);
/* Issue MPI reset */ /* Issue MPI reset */
scsi_block_requests(vha->host); scsi_block_requests(vha->host);

5
qla2x00t-32gbit/qla_target.c
View File

@@ -6692,7 +6692,8 @@ qlt_enable_vha(struct scsi_qla_host *vha)
} else { } else {
set_bit(ISP_ABORT_NEEDED, &base_vha->dpc_flags); set_bit(ISP_ABORT_NEEDED, &base_vha->dpc_flags);
qla2xxx_wake_dpc(base_vha); qla2xxx_wake_dpc(base_vha);
qla2x00_wait_for_hba_online(base_vha); WARN_ON_ONCE(qla2x00_wait_for_hba_online(base_vha) !=
QLA_SUCCESS);
} }
mutex_unlock(&ha->optrom_mutex); mutex_unlock(&ha->optrom_mutex);
} }
@@ -6723,7 +6724,7 @@ static void qlt_disable_vha(struct scsi_qla_host *vha)
set_bit(ISP_ABORT_NEEDED, &vha->dpc_flags); set_bit(ISP_ABORT_NEEDED, &vha->dpc_flags);
qla2xxx_wake_dpc(vha); qla2xxx_wake_dpc(vha);
qla2x00_wait_for_hba_online(vha); WARN_ON_ONCE(qla2x00_wait_for_hba_online(vha) != QLA_SUCCESS);
} }
/* /*