From 83a967d3a3112f177e8340fa6ecd1b5fed900c0f Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Sun, 14 Nov 2010 09:32:03 +0000 Subject: [PATCH] ib_srpt: Made sure that accessing sysfs entries during target creation is harmless. git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2703 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- srpt/src/ib_srpt.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/srpt/src/ib_srpt.c b/srpt/src/ib_srpt.c index f97fbbb40..de9b46f46 100644 --- a/srpt/src/ib_srpt.c +++ b/srpt/src/ib_srpt.c @@ -2140,6 +2140,9 @@ static int srpt_enable_target(struct scst_tgt *scst_tgt, bool enable) EXTRACHECKS_WARN_ON_ONCE(irqs_disabled()); + if (!sdev) + return -ENOENT; + TRACE_DBG("%s target %s", enable ? "Enabling" : "Disabling", sdev->device->name); @@ -2160,6 +2163,9 @@ static bool srpt_is_target_enabled(struct scst_tgt *scst_tgt) EXTRACHECKS_WARN_ON_ONCE(irqs_disabled()); + if (!sdev) + return false; + spin_lock_irq(&sdev->spinlock); res = sdev->enabled; spin_unlock_irq(&sdev->spinlock);