From 33f2f4a064ebab962c766be795aa0e5773dcf836 Mon Sep 17 00:00:00 2001
From: Bart Van Assche <bvanassche@acm.org>
Date: Tue, 23 Apr 2019 17:11:26 +0000
Subject: [PATCH] Makefiles: Only read the build_mode file if building inside
 the SCST tree

This patch avoids that the build_mode file is read when applying the
generate-kernel-patch output to the kernel tree and when building the
kernel tree.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8272 d57e44dd-8a1f-0410-8b47-8ef2f437770f
---
 fcst/Makefile_in-tree                   | 2 ++
 iscsi-scst/kernel/Makefile              | 2 ++
 iscsi-scst/kernel/isert-scst/Makefile   | 2 ++
 qla2x00t-32gbit/Makefile_in-tree        | 2 ++
 qla2x00t-32gbit/qla2x00-target/Makefile | 2 ++
 qla2x00t/qla2x00-target/Makefile        | 2 ++
 scst/src/Makefile                       | 2 ++
 scst/src/dev_handlers/Makefile          | 2 ++
 scst_local/Makefile                     | 2 ++
 srpt/src/Makefile                       | 2 ++
 10 files changed, 20 insertions(+)

diff --git a/fcst/Makefile_in-tree b/fcst/Makefile_in-tree
index c7028e58f..a5703d0cf 100644
--- a/fcst/Makefile_in-tree
+++ b/fcst/Makefile_in-tree
@@ -1,3 +1,4 @@
+ifneq ($(and $(KBUILD_EXTMOD),$(if $(findstring $(abspath $(srctree)),$(abspath $(KBUILD_EXTMOD))),,true)),)
 -include $(KBUILD_EXTMOD)/../build_mode
 
 echo := $(shell echo "fcst build mode: $(BUILD_MODE)" >& 2)
@@ -9,6 +10,7 @@ BUILD_MODE_CFLAGS_RELEASE = -DCONFIG_SCST_TRACING
 BUILD_MODE_CFLAGS_PERF =
 ccflags-y += -I$(KBUILD_EXTMOD)/../scst/include
 ccflags-y += $(BUILD_MODE_CFLAGS_$(BUILD_MODE))
+endif
 
 obj-$(CONFIG_FCST) += fcst.o
 
diff --git a/iscsi-scst/kernel/Makefile b/iscsi-scst/kernel/Makefile
index 6090e9dfe..85ad48733 100644
--- a/iscsi-scst/kernel/Makefile
+++ b/iscsi-scst/kernel/Makefile
@@ -27,6 +27,7 @@ ccflags-y += $(call cc-option,-Wextra) \
 ccflags-y += $(PRE_CFLAGS)
 #ccflags-y += -DCONFIG_SCST_ISCSI_DEBUG_DIGEST_FAILURES
 
+ifneq ($(and $(KBUILD_EXTMOD),$(if $(findstring $(abspath $(srctree)),$(abspath $(KBUILD_EXTMOD))),,true)),)
 -include $(KBUILD_EXTMOD)/../../build_mode
 
 echo := $(shell echo "iscsi-scst build mode: $(BUILD_MODE)" >& 2)
@@ -36,6 +37,7 @@ BUILD_MODE_CFLAGS_ = -DCONFIG_SCST_TRACING -DCONFIG_SCST_DEBUG \
 BUILD_MODE_CFLAGS_RELEASE = -DCONFIG_SCST_TRACING
 BUILD_MODE_CFLAGS_PERF =
 ccflags-y += $(BUILD_MODE_CFLAGS_$(BUILD_MODE))
+endif
 
 obj-m		+= iscsi-scst.o
 iscsi-scst-objs	:= iscsi.o nthread.o config.o digest.o \
diff --git a/iscsi-scst/kernel/isert-scst/Makefile b/iscsi-scst/kernel/isert-scst/Makefile
index 5ac04aaaa..a2b709c7b 100644
--- a/iscsi-scst/kernel/isert-scst/Makefile
+++ b/iscsi-scst/kernel/isert-scst/Makefile
@@ -26,6 +26,7 @@ ccflags-y += $(call cc-option,-Wextra) \
 	$(call cc-option,-Wno-old-style-declaration) \
 	-Wno-unused-parameter -Wno-missing-field-initializers
 
+ifneq ($(and $(KBUILD_EXTMOD),$(if $(findstring $(abspath $(srctree)),$(abspath $(KBUILD_EXTMOD))),,true)),)
 -include $(KBUILD_EXTMOD)/../../../build_mode
 
 echo := $(shell echo "isert-scst build mode: $(BUILD_MODE)" >& 2)
@@ -35,6 +36,7 @@ BUILD_MODE_CFLAGS_ = -DCONFIG_SCST_TRACING -DCONFIG_SCST_DEBUG \
 BUILD_MODE_CFLAGS_RELEASE = -DCONFIG_SCST_TRACING
 BUILD_MODE_CFLAGS_PERF =
 ccflags-y += $(BUILD_MODE_CFLAGS_$(BUILD_MODE))
+endif
 
 obj-m		+= isert-scst.o
 isert-scst-objs	:= isert.o isert_login.o \
diff --git a/qla2x00t-32gbit/Makefile_in-tree b/qla2x00t-32gbit/Makefile_in-tree
index 4890174ed..1437a63a5 100644
--- a/qla2x00t-32gbit/Makefile_in-tree
+++ b/qla2x00t-32gbit/Makefile_in-tree
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 
+ifneq ($(and $(KBUILD_EXTMOD),$(if $(findstring $(abspath $(srctree)),$(abspath $(KBUILD_EXTMOD))),,true)),)
 -include $(KBUILD_EXTMOD)/../build_mode
 
 echo := $(shell echo "qla2x00t-32gbit build mode: $(BUILD_MODE)" >& 2)
@@ -9,6 +10,7 @@ BUILD_MODE_CFLAGS_ = -DCONFIG_SCST_TRACING -DCONFIG_SCST_DEBUG \
 BUILD_MODE_CFLAGS_RELEASE = -DCONFIG_SCST_TRACING
 BUILD_MODE_CFLAGS_PERF =
 ccflags-y += $(BUILD_MODE_CFLAGS_$(BUILD_MODE))
+endif
 
 qla2xxx-y := qla_os.o qla_init.o qla_mbx.o qla_iocb.o qla_isr.o qla_gs.o \
 		qla_dbg.o qla_sup.o qla_attr.o qla_mid.o qla_dfs.o qla_bsg.o \
diff --git a/qla2x00t-32gbit/qla2x00-target/Makefile b/qla2x00t-32gbit/qla2x00-target/Makefile
index 17a3562f1..f3aacd5a6 100644
--- a/qla2x00t-32gbit/qla2x00-target/Makefile
+++ b/qla2x00t-32gbit/qla2x00-target/Makefile
@@ -65,6 +65,7 @@ ccflags-y += -W -Wno-unused-parameter -Wno-missing-field-initializers
 #ccflags-y += -DCONFIG_QLA_TGT_DEBUG_WORK_IN_THREAD
 #ccflags-y += -DCONFIG_QLA_TGT_DEBUG_SRR
 
+ifneq ($(and $(KBUILD_EXTMOD),$(if $(findstring $(abspath $(srctree)),$(abspath $(KBUILD_EXTMOD))),,true)),)
 -include $(KBUILD_EXTMOD)/../../build_mode
 
 echo := $(shell echo "qla2x00t-32gbit/target build mode: $(BUILD_MODE)" >& 2)
@@ -74,6 +75,7 @@ BUILD_MODE_CFLAGS_ = -DCONFIG_SCST_TRACING -DCONFIG_SCST_DEBUG \
 BUILD_MODE_CFLAGS_RELEASE = -DCONFIG_SCST_TRACING
 BUILD_MODE_CFLAGS_PERF =
 ccflags-y += $(BUILD_MODE_CFLAGS_$(BUILD_MODE))
+endif
 
 ifneq ($(BUILD_2X_MODULE),)
 ccflags-y += -DCONFIG_SCSI_QLA2XXX_TARGET=y
diff --git a/qla2x00t/qla2x00-target/Makefile b/qla2x00t/qla2x00-target/Makefile
index c5490598a..c71721545 100644
--- a/qla2x00t/qla2x00-target/Makefile
+++ b/qla2x00t/qla2x00-target/Makefile
@@ -64,6 +64,7 @@ ccflags-y += -W -Wno-unused-parameter -Wno-missing-field-initializers
 #ccflags-y += -DCONFIG_QLA_TGT_DEBUG_WORK_IN_THREAD
 #ccflags-y += -DCONFIG_QLA_TGT_DEBUG_SRR
 
+ifneq ($(and $(KBUILD_EXTMOD),$(if $(findstring $(abspath $(srctree)),$(abspath $(KBUILD_EXTMOD))),,true)),)
 -include $(KBUILD_EXTMOD)/../../build_mode
 
 echo := $(shell echo "qla2x00t build mode: $(BUILD_MODE)" >& 2)
@@ -73,6 +74,7 @@ BUILD_MODE_CFLAGS_ = -DCONFIG_SCST_TRACING -DCONFIG_SCST_DEBUG \
 BUILD_MODE_CFLAGS_RELEASE = -DCONFIG_SCST_TRACING
 BUILD_MODE_CFLAGS_PERF =
 ccflags-y += $(BUILD_MODE_CFLAGS_$(BUILD_MODE))
+endif
 
 ifneq ($(BUILD_2X_MODULE),)
 ccflags-y += -DCONFIG_SCSI_QLA2XXX_TARGET=y
diff --git a/scst/src/Makefile b/scst/src/Makefile
index b84bad3e8..8f550fda7 100644
--- a/scst/src/Makefile
+++ b/scst/src/Makefile
@@ -55,6 +55,7 @@ ccflags-y += -I$(KBUILD_EXTMOD)/../include $(call cc-option,-Wextra) \
 # enable it if you have strict security requirements.
 #ccflags-y += -DSCST_STRICT_SECURITY
 
+ifneq ($(and $(KBUILD_EXTMOD),$(if $(findstring $(abspath $(srctree)),$(abspath $(KBUILD_EXTMOD))),,true)),)
 -include $(KBUILD_EXTMOD)/../../build_mode
 
 echo := $(shell echo "scst build mode: $(BUILD_MODE)" >& 2)
@@ -64,6 +65,7 @@ BUILD_MODE_CFLAGS_ = -DCONFIG_SCST_TRACING -DCONFIG_SCST_DEBUG \
 BUILD_MODE_CFLAGS_RELEASE = -DCONFIG_SCST_TRACING
 BUILD_MODE_CFLAGS_PERF =
 ccflags-y += $(BUILD_MODE_CFLAGS_$(BUILD_MODE))
+endif
 
 obj-m := scst.o
 
diff --git a/scst/src/dev_handlers/Makefile b/scst/src/dev_handlers/Makefile
index afe961295..0327eb39d 100644
--- a/scst/src/dev_handlers/Makefile
+++ b/scst/src/dev_handlers/Makefile
@@ -35,6 +35,7 @@ ccflags-y += -I$(KBUILD_EXTMOD)/../include				\
 	-Wno-unused-parameter -Wno-missing-field-initializers -Wno-sign-compare
 #ccflags-y += -DCONFIG_DEBUG_EXT_COPY_REMAP
 
+ifneq ($(and $(KBUILD_EXTMOD),$(if $(findstring $(abspath $(srctree)),$(abspath $(KBUILD_EXTMOD))),,true)),)
 -include $(KBUILD_EXTMOD)/../../build_mode
 
 echo := $(shell echo "dev_handlers build mode: $(BUILD_MODE)" >& 2)
@@ -44,6 +45,7 @@ BUILD_MODE_CFLAGS_ = -DCONFIG_SCST_TRACING -DCONFIG_SCST_DEBUG \
 BUILD_MODE_CFLAGS_RELEASE = -DCONFIG_SCST_TRACING
 BUILD_MODE_CFLAGS_PERF =
 ccflags-y += $(BUILD_MODE_CFLAGS_$(BUILD_MODE))
+endif
 
 obj-m := scst_cdrom.o scst_changer.o scst_disk.o scst_modisk.o scst_tape.o \
 	scst_vdisk.o scst_raid.o scst_processor.o scst_user.o
diff --git a/scst_local/Makefile b/scst_local/Makefile
index b9b996ac8..62f0521fa 100644
--- a/scst_local/Makefile
+++ b/scst_local/Makefile
@@ -13,6 +13,7 @@ ccflags-y	+= $(call cc-option,-Wextra) -Wno-unused-parameter\
 
 #ccflags-y += -DCONFIG_SCST_LOCAL_DIRECT_PROCESSING
 
+ifneq ($(and $(KBUILD_EXTMOD),$(if $(findstring $(abspath $(srctree)),$(abspath $(KBUILD_EXTMOD))),,true)),)
 -include $(KBUILD_EXTMOD)/../build_mode
 
 echo := $(shell echo "scst_local build mode: $(BUILD_MODE)" >& 2)
@@ -22,6 +23,7 @@ BUILD_MODE_CFLAGS_ = -DCONFIG_SCST_TRACING -DCONFIG_SCST_DEBUG \
 BUILD_MODE_CFLAGS_RELEASE = -DCONFIG_SCST_TRACING
 BUILD_MODE_CFLAGS_PERF =
 ccflags-y += $(BUILD_MODE_CFLAGS_$(BUILD_MODE))
+endif
 
 obj-m	:= scst_local.o
 else
diff --git a/srpt/src/Makefile b/srpt/src/Makefile
index ce70bbd39..b35aa0832 100644
--- a/srpt/src/Makefile
+++ b/srpt/src/Makefile
@@ -2,6 +2,7 @@ LINUXINCLUDE := $(PRE_CFLAGS) $(LINUXINCLUDE)
 CPPFLAGS     := $(PRE_CFLAGS) $(CPPFLAGS)
 ccflags-y    += -I$(KBUILD_EXTMOD)/../../scst/include
 
+ifneq ($(and $(KBUILD_EXTMOD),$(if $(findstring $(abspath $(srctree)),$(abspath $(KBUILD_EXTMOD))),,true)),)
 -include $(KBUILD_EXTMOD)/../../build_mode
 
 echo := $(shell echo "srpt build mode: $(BUILD_MODE)" >& 2)
@@ -11,6 +12,7 @@ BUILD_MODE_CFLAGS_ = -DCONFIG_SCST_TRACING -DCONFIG_SCST_DEBUG \
 BUILD_MODE_CFLAGS_RELEASE = -DCONFIG_SCST_TRACING
 BUILD_MODE_CFLAGS_PERF =
 ccflags-y += $(BUILD_MODE_CFLAGS_$(BUILD_MODE))
+endif
 
 #ccflags-y += -Wextra -Wno-unused-parameter