mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-08-21 14:46:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reimplement dropping of TM requests in a more reliable manner

Browse Source 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5395 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Vladislav Bolkhovitin
2014-03-26 23:51:36 +00:00
parent 87ce86ee2d
commit 8599ec4452
5 changed files with 59 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scst/README
+9 -6
View File
@@ -603,16 +603,19 @@ Every target should have at least the following entries:
* 2 - immediately abort all coming commands and drop all coming TM
commands
* 3 - immediately abort all coming data transfer commands. This is
the most evil mode, because it is not too well handled by many
initiator OS'es, including Linux, so they may never recover from
it.
* 3 - immediately abort all coming data transfer commands.
* 4 - immediately abort all coming data transfer commands and drop all
coming TM commands
CAUTION! With some target drivers modes 2 and 4 can cause internal
resources leaks, so don't abuse those options!
Modes 3 and 4 are the most evil ones, because they are not too well
handled by many initiator OS'es, including Linux, so they may never
recover from it.
Note, dropping TM commands, i.e. not sending response on them,
implemented not for all target drivers. If it's implemented for your
particular target driver or not, you can find out by checking traces
or the target driver's source code.
- cpu_mask - defines CPU affinity mask for threads serving this target.
For threads serving LUNs it is used only for devices with
scst/README_in-tree
+9 -6
View File
@@ -465,16 +465,19 @@ Every target should have at least the following entries:
* 2 - immediately abort all coming commands and drop all coming TM
commands
* 3 - immediately abort all coming data transfer commands. This is
the most evil mode, because it is not too well handled by many
initiator OS'es, including Linux, so they may never recover from
it.
* 3 - immediately abort all coming data transfer commands.
* 4 - immediately abort all coming data transfer commands and drop all
coming TM commands
CAUTION! With some target drivers modes 2 and 4 can cause internal
resources leaks, so don't abuse those options!
Modes 3 and 4 are the most evil ones, because they are not too well
handled by many initiator OS'es, including Linux, so they may never
recover from it.
Note, dropping TM commands, i.e. not sending response on them,
implemented not for all target drivers. If it's implemented for your
particular target driver or not, you can find out by checking traces
or the target driver's source code.
- cpu_mask - defines CPU affinity mask for threads serving this target.
For threads serving LUNs it is used only for devices with
scst/include/scst.h
+13 -6
View File
@@ -2289,6 +2289,7 @@ struct scst_mgmt_cmd {
unsigned int cmd_sn_set:1; /* set, if cmd_sn field is valid */
/* Set if dev handler's task_mgmt_fn_received was called */
unsigned int task_mgmt_fn_received_called:1;
unsigned int mcmd_dropped:1; /* set if mcmd was dropped */
/*
* Number of commands to finish before sending response,
@@ -3717,12 +3718,6 @@ static inline int scst_mgmt_cmd_get_status(struct scst_mgmt_cmd *mcmd)
return mcmd->status;
}
/* Returns mgmt cmd's TM fn */
static inline int scst_mgmt_cmd_get_fn(struct scst_mgmt_cmd *mcmd)
{
return mcmd->fn;
}
static inline void scst_mgmt_cmd_set_status(struct scst_mgmt_cmd *mcmd,
int status)
{
@@ -3732,6 +3727,18 @@ static inline void scst_mgmt_cmd_set_status(struct scst_mgmt_cmd *mcmd,
mcmd->status = status;
}
/* Returns mgmt cmd's TM fn */
static inline int scst_mgmt_cmd_get_fn(struct scst_mgmt_cmd *mcmd)
{
return mcmd->fn;
}
/* Returns true if mgmt cmd should be dropped, i.e. response not sent */
static inline bool scst_mgmt_cmd_dropped(struct scst_mgmt_cmd *mcmd)
{
return mcmd->mcmd_dropped;
}
/*
* Called by dev handler's task_mgmt_fn_*() to notify SCST core that mcmd
* is going to complete asynchronously.
scst/src/scst_targ.c
+1 -3
View File
@@ -5497,13 +5497,11 @@ static int scst_mgmt_cmd_init(struct scst_mgmt_cmd *mcmd)
TRACE_ENTRY();
t = mcmd->sess->acg->acg_black_hole_type;
if (unlikely((t == SCST_ACG_BLACK_HOLE_ALL) ||
(t == SCST_ACG_BLACK_HOLE_DATA_MCMD))) {
TRACE_MGMT_DBG("Dropping mcmd %p (fn %d, initiator %s)", mcmd,
mcmd->fn, mcmd->sess->initiator_name);
mcmd->state = SCST_MCMD_STATE_FINISHED;
goto out;
mcmd->mcmd_dropped = 1;
}
switch (mcmd->fn) {