From 85f3cd4f8778825c5f8c69e5acf8b3e75cac93ee Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Sun, 26 Sep 2010 19:13:32 +0000 Subject: [PATCH] Removed empty Signed-off-by line / elaborated ibmvstgt patch description. git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2284 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- scripts/generate-kernel-patch | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/scripts/generate-kernel-patch b/scripts/generate-kernel-patch index 394eb2c6f..beecbb038 100755 --- a/scripts/generate-kernel-patch +++ b/scripts/generate-kernel-patch @@ -236,11 +236,6 @@ do fi done -if [ "${multiple_patches}" = "false" ]; then - echo "Signed-off-by: ${SIGNED_OFF_BY}" - echo "" -fi - # General kernel patches. @@ -562,18 +557,23 @@ add_file "scst_local/README" "Documentation/scst/README.scst_local" \ [SCSI] ibmvstgt: Port from tgt to SCST The current ibmvstgt and libsrp kernel modules are based on the tgt -infrastructure - these modules need the scsi_tgt kernel module and the tgtd -user space process in order to function properly. This patch modifies the -ibmvstgt and the libsrp kernel modules such that both use the SCST storage -target framework instead of tgt. Note: ibmvstgt is the only user of libsrp. +infrastructure. Both modules need the scsi_tgt kernel module and the tgtd user +space process in order to function properly. This patch modifies the ibmvstgt +and the libsrp kernel modules such that both use the SCST storage target +framework instead of tgt. Porting ibmvstgt to SCST is required for upstream +acceptance of SCST. -This patch introduces one backwards-incompatible change, namely that the -path of the ibmvstgt sysfs attributes is modified. +This patch introduces one backwards-incompatible change, namely that the path +of the ibmvstgt sysfs attributes is modified. This change is unavoidable +because this patch dissociates ibmvstgt target instances from a SCSI host +instance. -Note: this patch does compile, is checkpatch clean and does not introduce any -new sparse warnings. This patch has not been tested in any other way -however. The primary purpose of this patch is to invite feedback about the -chosen approach. +Notes: +- ibmvstgt is the only user of libsrp. +- A 2.6.35 kernel tree with this patch applied does compile cleanly, the patch +itself is checkpatch clean and does not introduce any new sparse warnings. +This patch has not been tested in any other way however. The primary purpose +of this patch is to invite feedback about the chosen approach. Signed-off-by: Bart Van Assche