From 92ef2de4a5f4d2690044eb22826c77aaca18ecef Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Tue, 11 Aug 2009 19:24:30 +0000 Subject: [PATCH] Added a note about the size of struct ib_qp_attr. git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1038 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- srpt/src/ib_srpt.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/srpt/src/ib_srpt.c b/srpt/src/ib_srpt.c index 9b528cdae..939cfe746 100644 --- a/srpt/src/ib_srpt.c +++ b/srpt/src/ib_srpt.c @@ -813,6 +813,10 @@ static int srpt_init_ch_qp(struct srpt_rdma_ch *ch, struct ib_qp *qp) * @qp: queue pair to change the state of. * * Returns zero upon success and a negative value upon failure. + * + * Note: currently a struct ib_qp_attr takes 136 bytes on a 64-bit system. + * If this structure ever becomes larger, it might be necessary to allocate + * it dynamically instead of on the stack. */ static int srpt_ch_qp_rtr(struct srpt_rdma_ch *ch, struct ib_qp *qp) { @@ -839,6 +843,10 @@ out: * @qp: queue pair to change the state of. * * Returns zero upon success and a negative value upon failure. + * + * Note: currently a struct ib_qp_attr takes 136 bytes on a 64-bit system. + * If this structure ever becomes larger, it might be necessary to allocate + * it dynamically instead of on the stack. */ static int srpt_ch_qp_rts(struct srpt_rdma_ch *ch, struct ib_qp *qp) {