From 9e77adb8b829d41679b09f5826b1a189e80170e3 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Thu, 10 Oct 2013 15:10:58 +0000 Subject: [PATCH] scstadmin, SCST.pm: Fix setLunAttribute() error return code git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5063 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- scstadmin/scstadmin.sysfs/scst-0.9.10/lib/SCST/SCST.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scstadmin/scstadmin.sysfs/scst-0.9.10/lib/SCST/SCST.pm b/scstadmin/scstadmin.sysfs/scst-0.9.10/lib/SCST/SCST.pm index 9823f7973..bf8d20ee3 100644 --- a/scstadmin/scstadmin.sysfs/scst-0.9.10/lib/SCST/SCST.pm +++ b/scstadmin/scstadmin.sysfs/scst-0.9.10/lib/SCST/SCST.pm @@ -3388,10 +3388,11 @@ sub setLunAttribute { } $rc = $self->lunExists($driver, $target, $lun, $group); - return SCST_C_GRP_NO_LUN if (!$rc); + return (defined($group) ? SCST_C_GRP_NO_LUN : SCST_C_TGT_NO_LUN) + if (!$rc); return $rc if ($rc > 1); - my $attributes = $self->lunAttributes($driver, $target, $group, $lun); + my $attributes = $self->lunAttributes($driver, $target, $lun, $group); return SCST_C_LUN_BAD_ATTRIBUTES if (!defined($$attributes{$attribute})); return SCST_C_LUN_ATTRIBUTE_STATIC if ($$attributes{$attribute}->{'static'});