From a2664a8d2b3944d6ffd383864ea4735c125b815d Mon Sep 17 00:00:00 2001 From: Stanislaw Gruszka Date: Tue, 14 Apr 2009 20:25:20 +0000 Subject: [PATCH] - Disallow to pass command to low level driver when we user is disabling target mode (protect by disable_sem). - Fix parentheses in unlikely statement. git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@780 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- qla_isp/linux/isp_scst.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qla_isp/linux/isp_scst.c b/qla_isp/linux/isp_scst.c index 44be93a81..eef080453 100644 --- a/qla_isp/linux/isp_scst.c +++ b/qla_isp/linux/isp_scst.c @@ -1108,12 +1108,12 @@ isp_rdy_to_xfer(struct scst_cmd *scst_cmd) } BUS_DBG2(bp, "TMD[%llx] write nbytes %u\n", tmd->cd_tagval, scst_cmd_get_bufflen(scst_cmd)); - up_read(&bc->disable_sem); (*bp->h.r_action)(QIN_TMD_CONT, xact); + up_read(&bc->disable_sem); /* * Did we have an error starting this particular transaction? */ - if (unlikely(xact->td_lflags & (TDFL_ERROR|TDFL_SYNCERROR)) == (TDFL_ERROR|TDFL_SYNCERROR)) { + if (unlikely((xact->td_lflags & (TDFL_ERROR|TDFL_SYNCERROR)) == (TDFL_ERROR|TDFL_SYNCERROR))) { if (xact->td_error == -ENOMEM) { return (SCST_TGT_RES_QUEUE_FULL); } else { @@ -1224,7 +1224,7 @@ out: /* * Did we have an error starting this particular transaction? */ - if (unlikely(xact->td_lflags & (TDFL_ERROR|TDFL_SYNCERROR)) == (TDFL_ERROR|TDFL_SYNCERROR)) { + if (unlikely((xact->td_lflags & (TDFL_ERROR|TDFL_SYNCERROR)) == (TDFL_ERROR|TDFL_SYNCERROR))) { if (xact->td_error == -ENOMEM) { return (SCST_TGT_RES_QUEUE_FULL); } else {