From a67322d28866b7ef09f778c14558ad9673daae3b Mon Sep 17 00:00:00 2001 From: Israel Rukshin Date: Wed, 17 Aug 2016 07:27:19 +0000 Subject: [PATCH] isert: change wrong dev_conn bug on Signed-off-by: Israel Rukshin git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6938 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- iscsi-scst/kernel/isert-scst/isert_login.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/iscsi-scst/kernel/isert-scst/isert_login.c b/iscsi-scst/kernel/isert-scst/isert_login.c index 1dd077537..5dcd0e0a6 100644 --- a/iscsi-scst/kernel/isert-scst/isert_login.c +++ b/iscsi-scst/kernel/isert-scst/isert_login.c @@ -107,6 +107,7 @@ static void isert_kref_release_dev(struct kref *kref) static void isert_dev_release(struct isert_conn_dev *dev) { + sBUG_ON(atomic_read(&dev->kref.refcount) == 0); spin_lock(&isert_listen_dev.conn_lock); kref_put(&dev->kref, isert_kref_release_dev); spin_unlock(&isert_listen_dev.conn_lock); @@ -304,8 +305,8 @@ static void isert_delete_conn_dev(struct isert_conn_dev *conn_dev) isert_del_timer(conn_dev); if (!test_and_set_bit(ISERT_CONN_PASSED, &conn_dev->flags)) { - BUG_ON(conn_dev->conn == NULL); - isert_close_connection(conn_dev->conn); + if (conn_dev->conn) + isert_close_connection(conn_dev->conn); } }