From aa6c6a4c2fc3d025b2cb16ee4ab8533bad00da39 Mon Sep 17 00:00:00 2001 From: Vladislav Bolkhovitin Date: Thu, 13 Apr 2017 22:38:38 +0000 Subject: [PATCH] Change memcpy() to strncpy() because the source name string is not guaranteed to exist as valid addressable memory beyond the NULL byte. Signed-off-by: David Butterfield with small addition to force set last byte NULL git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7109 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- iscsi-scst/usr/target.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/iscsi-scst/usr/target.c b/iscsi-scst/usr/target.c index 9c6898d98..0cb47fe31 100644 --- a/iscsi-scst/usr/target.c +++ b/iscsi-scst/usr/target.c @@ -415,7 +415,8 @@ int target_create(const char *name, struct target **out_target) } memset(target, 0, sizeof(*target)); - memcpy(target->name, name, sizeof(target->name) - 1); + strncpy(target->name, name, sizeof(target->name) - 1); + target->name[sizeof(target->name)-1] = '\0'; params_set_defaults(target->target_params, target_keys); params_set_defaults(target->session_params, session_keys);