mirror of
https://github.com/SCST-project/scst.git
synced 2026-05-16 18:21:27 +00:00
qla2x00t-32gbit: Avoid flush_scheduled_work() usage
Although qla2xxx driver is calling schedule_{,delayed}_work() from 10
locations, I assume that flush_scheduled_work() from qlt_stop_phase1()
needs to flush only works scheduled by qlt_sched_sess_work(), for this loop
continues while "struct qla_tgt"->sess_works_list is not empty.
Link: https://lore.kernel.org/r/133c6723-90b6-5c8b-72b4-cc01eeb3a8c0@I-love.SAKURA.ne.jp
Tested-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 3cb0643a9aae upstream ]
This commit is contained in:
@@ -1574,7 +1574,7 @@ int qlt_stop_phase1(struct qla_tgt *tgt)
|
||||
spin_lock_irqsave(&tgt->sess_work_lock, flags);
|
||||
do {
|
||||
spin_unlock_irqrestore(&tgt->sess_work_lock, flags);
|
||||
flush_scheduled_work();
|
||||
flush_work(&tgt->sess_work);
|
||||
spin_lock_irqsave(&tgt->sess_work_lock, flags);
|
||||
} while (!list_empty(&tgt->sess_works_list));
|
||||
spin_unlock_irqrestore(&tgt->sess_work_lock, flags);
|
||||
|
||||
Reference in New Issue
Block a user