From ca246c4a50cf89a77b603e488af50dc731d9fdb9 Mon Sep 17 00:00:00 2001 From: Vladislav Bolkhovitin Date: Wed, 24 Feb 2016 01:47:02 +0000 Subject: [PATCH] scst: Follow up for r6804 git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6817 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- scst/README | 14 +++++++------- scst/README_in-tree | 14 +++++++------- scst/src/dev_handlers/scst_vdisk.c | 4 +++- 3 files changed, 17 insertions(+), 15 deletions(-) diff --git a/scst/README b/scst/README index f54953803..7f78d8159 100644 --- a/scst/README +++ b/scst/README @@ -1647,14 +1647,14 @@ perform actual path state switching on SET TARGET PORT GROUPS command, for instance, by calling drbdadm. For more information see stpgd README as well as sample script scst_on_stpg. -DRBD compatibility -.................. +DRBD and other replication/failover SW compatibility +.................................................... -DRBD does not allow to open its device on the secondary as well as does -not allow to perform primary to secondary transition, if this device is -open. +DRBD as well as other replication/failover SW does not allow to open its +device on the secondary as well as does not allow to perform primary to +secondary transition, if this device is open. -SCST BLOCKIO handler has all the necessary support for this behavior. If +SCST BLOCKIO handler has all the necessary support for such behavior. If you write new ALUA state in the "state" attribute, SCST BLOCKIO handler before transition closes the open devices' handles and after transition reopens them, if the new state is active or nonoptimized. @@ -1668,7 +1668,7 @@ above). Wait until the blocking finished. 2. Change the ALUA state to "transitioning". At this moment all open file handles will be closed. -3. Perform the DRBD state transition +3. Perform the DRBD or other replication/failover SW state transition 4. Change the ALUA state to your desired secondary state. diff --git a/scst/README_in-tree b/scst/README_in-tree index defac1e6d..5159aea88 100644 --- a/scst/README_in-tree +++ b/scst/README_in-tree @@ -1500,14 +1500,14 @@ perform actual path state switching on SET TARGET PORT GROUPS command, for instance, by calling drbdadm. For more information see stpgd README as well as sample script scst_on_stpg. -DRBD compatibility -.................. +DRBD and other replication/failover SW compatibility +.................................................... -DRBD does not allow to open its device on the secondary as well as does -not allow to perform primary to secondary transition, if this device is -open. +DRBD as well as other replication/failover SW does not allow to open its +device on the secondary as well as does not allow to perform primary to +secondary transition, if this device is open. -SCST BLOCKIO handler has all the necessary support for this behavior. If +SCST BLOCKIO handler has all the necessary support for such behavior. If you write new ALUA state in the "state" attribute, SCST BLOCKIO handler before transition closes the open devices' handles and after transition reopens them, if the new state is active or nonoptimized. @@ -1521,7 +1521,7 @@ above). Wait until the blocking finished. 2. Change the ALUA state to "transitioning". At this moment all open file handles will be closed. -3. Perform the DRBD state transition +3. Perform the DRBD or other replication/failover SW state transition 4. Change the ALUA state to your desired secondary state. diff --git a/scst/src/dev_handlers/scst_vdisk.c b/scst/src/dev_handlers/scst_vdisk.c index 80aad71aa..56f101770 100644 --- a/scst/src/dev_handlers/scst_vdisk.c +++ b/scst/src/dev_handlers/scst_vdisk.c @@ -3617,7 +3617,9 @@ static int blockio_exec(struct scst_cmd *cmd) /* * We should not get here, unless the user space * misconfiguring something, e.g. set optimized - * ALUA state for secondary DRBD device. + * ALUA state for secondary DRBD device. See + * "DRBD and other replication/failover SW + * compatibility" section in SCST README. */ PRINT_WARNING("Closed FD on exec. Secondary DRBD or not " "blocked dev before ALUA state change? "