From cb39459fa8d60e2fd0a14915bb41a07a6d2a6eb6 Mon Sep 17 00:00:00 2001 From: Vladislav Bolkhovitin Date: Wed, 6 Feb 2013 21:41:41 +0000 Subject: [PATCH] sgv_pool_create(): Return NULL if sgv_pool_init() fails The current implementation of sgv_pool_create() returns a dangling pointer if pool allocation succeeds but sgv_pool_init() fails. Modify sgv_pool_create() such that a NULL pointer is returned if that happens. This was detected by Coverity. Signed-off-by: Bart Van Assche git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4756 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- scst/src/scst_mem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/scst/src/scst_mem.c b/scst/src/scst_mem.c index d3f58eb6f..519ca629b 100644 --- a/scst/src/scst_mem.c +++ b/scst/src/scst_mem.c @@ -1670,6 +1670,7 @@ out_unlock: out_free: kfree(pool); + pool = NULL; goto out_unlock; } EXPORT_SYMBOL_GPL(sgv_pool_create);