From ccdb440ae47a5e8085d1b53887e006604c87a667 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Wed, 19 May 2021 14:12:39 +0000 Subject: [PATCH] qla2x00t: Always check the qla2x00_wait_for_hba_online() return value This patch suppresses the following Coverity complaint: CID 364334 (#1 of 1): Unchecked return value (CHECKED_RETURN) 6. check_return: Calling qla2x00_wait_for_hba_online without checking return value (as is done elsewhere 8 out of 10 times). git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9421 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- qla2x00t/qla_attr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qla2x00t/qla_attr.c b/qla2x00t/qla_attr.c index f541a682b..df4b0c7c1 100644 --- a/qla2x00t/qla_attr.c +++ b/qla2x00t/qla_attr.c @@ -159,7 +159,7 @@ qla2x00_store_ini_mode_force_reverse(struct device *dev, set_bit(ISP_ABORT_NEEDED, &base_vha->dpc_flags); qla2xxx_wake_dpc(base_vha); - qla2x00_wait_for_hba_online(vha); + WARN_ON_ONCE(qla2x00_wait_for_hba_online(vha) != QLA_SUCCESS); out: return size; @@ -1096,7 +1096,7 @@ qla2x00_sysfs_write_reset(struct file *file, "Issuing MPI reset.\n"); /* Make sure FC side is not in reset */ - qla2x00_wait_for_hba_online(vha); + WARN_ON_ONCE(qla2x00_wait_for_hba_online(vha) != QLA_SUCCESS); /* Issue MPI reset */ scsi_block_requests(vha->host);