From d20be1897c5c842cc82cd8a91c5c42770b8fdd2c Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Sat, 6 Apr 2019 23:19:19 +0000 Subject: [PATCH] qla2x00t-32gbit: Avoid using the format specifier %*phC Since format specifier %*phC is not available in kernel versions before v3.6, do not use it. See also commit 31550a16a5d2 ("vsprintf: add support of '%*ph[CDN]'") # v3.6. git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8166 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- qla2x00t-32gbit/qla2x00-target/scst_qla2xxx.c | 29 +- qla2x00t-32gbit/qla_dfs.c | 8 +- qla2x00t-32gbit/qla_gs.c | 105 +++---- qla2x00t-32gbit/qla_init.c | 268 +++++++++--------- qla2x00t-32gbit/qla_inline.h | 18 +- qla2x00t-32gbit/qla_iocb.c | 8 +- qla2x00t-32gbit/qla_isr.c | 12 +- qla2x00t-32gbit/qla_mbx.c | 27 +- qla2x00t-32gbit/qla_os.c | 18 +- qla2x00t-32gbit/qla_target.c | 176 ++++++------ 10 files changed, 347 insertions(+), 322 deletions(-) diff --git a/qla2x00t-32gbit/qla2x00-target/scst_qla2xxx.c b/qla2x00t-32gbit/qla2x00-target/scst_qla2xxx.c index 76233876e..9db2e24d0 100644 --- a/qla2x00t-32gbit/qla2x00-target/scst_qla2xxx.c +++ b/qla2x00t-32gbit/qla2x00-target/scst_qla2xxx.c @@ -840,8 +840,8 @@ static void sqa_qla2xxx_free_session(struct fc_port *fcport) TRACE_ENTRY(); - TRACE_MGMT_DBG("sqatgt(%ld/%d): Deleting session %8phC fcid=%02x%02x%02x\n", - vha->host_no, vha->vp_idx, fcport->port_name, + TRACE_MGMT_DBG("sqatgt(%ld/%d): Deleting session %s fcid=%02x%02x%02x\n", + vha->host_no, vha->vp_idx, wwn_to_str(fcport->port_name), fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa); mcmd = kzalloc(sizeof(*mcmd), GFP_ATOMIC); @@ -859,8 +859,9 @@ static void sqa_qla2xxx_free_session(struct fc_port *fcport) wait_for_completion(&c); kfree(mcmd); - TRACE_MGMT_DBG("sqatgt(%ld/%d): Flush cmd done %8phC \n", - vha->host_no, vha->vp_idx, fcport->port_name); + TRACE_MGMT_DBG("sqatgt(%ld/%d): Flush cmd done %s\n", + vha->host_no, vha->vp_idx, + wwn_to_str(fcport->port_name)); } scst_unregister_session(scst_sess, 1, sqa_free_session_done); @@ -871,8 +872,8 @@ static void sqa_qla2xxx_free_session(struct fc_port *fcport) wait_for_completion(&c); } - TRACE_MGMT_DBG("sqatgt(%ld/%d): Unregister completed %8phC done \n", - vha->host_no, vha->vp_idx, fcport->port_name); + TRACE_MGMT_DBG("sqatgt(%ld/%d): Unregister completed %s done \n", + vha->host_no, vha->vp_idx, wwn_to_str(fcport->port_name)); sqa_free_sesess(se_sess); @@ -940,18 +941,20 @@ static int sqa_qla2xxx_check_initiator_node_acl(scsi_qla_host_t *vha, TRACE_ENTRY(); - PRINT_INFO("sqatgt(%ld/%d): Registering initiator: pwwn=%8phC", - vha->host_no, vha->vp_idx, fc_wwpn); + PRINT_INFO("sqatgt(%ld/%d): Registering initiator: pwwn=%s", + vha->host_no, vha->vp_idx, wwn_to_str(fc_wwpn)); se_sess = sqa_alloc_sesess(vha); if (!se_sess) return -ENOMEM; /* Create the SCST session. */ - ini_name = kzalloc(3*WWN_SIZE+2, GFP_KERNEL); + ini_name = kasprintf(GFP_KERNEL, + "%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x", + fc_wwpn[0], fc_wwpn[1], fc_wwpn[2], fc_wwpn[3], + fc_wwpn[4], fc_wwpn[5], fc_wwpn[6], fc_wwpn[7]); if (!ini_name) return -ENOMEM; - sprintf(ini_name, "%8phC", fc_wwpn); memcpy(fcport->port_name, fc_wwpn, sizeof(fcport->port_name)); sqa_tgt = (struct sqa_scst_tgt*)vha->vha_tgt.target_lport_ptr; @@ -1551,7 +1554,7 @@ static void sqa_qla2xxx_add_target(struct scsi_qla_host *vha) TRACE_ENTRY(); - PRINT_INFO("sqatgt: add target %8phC", vha->port_name); + PRINT_INFO("sqatgt: add target %s", wwn_to_str(vha->port_name)); if (!vha->vha_tgt.target_lport_ptr) { mutex_lock(&sqa_mutex); @@ -1929,9 +1932,9 @@ static int sqa_get_initiator_port_transport_id(struct scst_tgt *tgt, } TRACE_DBG("sqatgt(%ld/%d): Creating transport id: target session=%p, " - "initiator=%8phC, fcid=0x%02x%02x%02x, loop=0x%04x", + "initiator=%s, fcid=0x%02x%02x%02x, loop=0x%04x", sess->vha->host_no, sess->vha->vp_idx, sess, - sess->port_name, sess->d_id.b.domain, sess->d_id.b.area, + wwn_to_str(sess->port_name), sess->d_id.b.domain, sess->d_id.b.area, sess->d_id.b.al_pa, sess->loop_id); tr_id_size = 24; diff --git a/qla2x00t-32gbit/qla_dfs.c b/qla2x00t-32gbit/qla_dfs.c index 5819a45ac..5cecfdbb1 100644 --- a/qla2x00t-32gbit/qla_dfs.c +++ b/qla2x00t-32gbit/qla_dfs.c @@ -27,9 +27,9 @@ qla2x00_dfs_tgt_sess_show(struct seq_file *s, void *unused) spin_lock_irqsave(&ha->tgt.sess_lock, flags); list_for_each_entry(sess, &vha->vp_fcports, list) - seq_printf(s, "%02x:%02x:%02x %8phC %d\n", + seq_printf(s, "%02x:%02x:%02x %s %d\n", sess->d_id.b.domain, sess->d_id.b.area, - sess->d_id.b.al_pa, sess->port_name, + sess->d_id.b.al_pa, wwn_to_str(sess->port_name), sess->loop_id); spin_unlock_irqrestore(&ha->tgt.sess_lock, flags); } @@ -94,8 +94,8 @@ qla2x00_dfs_tgt_port_database_show(struct seq_file *s, void *unused) fc_port.loop_id = loop_id; rc = qla24xx_gpdb_wait(vha, &fc_port, 0); - seq_printf(s, "%8phC %02x%02x%02x %d\n", - fc_port.port_name, fc_port.d_id.b.domain, + seq_printf(s, "%s %02x%02x%02x %d\n", + wwn_to_str(fc_port.port_name), fc_port.d_id.b.domain, fc_port.d_id.b.area, fc_port.d_id.b.al_pa, fc_port.loop_id); id_iter += ha->gid_list_info_size; diff --git a/qla2x00t-32gbit/qla_gs.c b/qla2x00t-32gbit/qla_gs.c index c6fdad124..e6bf55b4c 100644 --- a/qla2x00t-32gbit/qla_gs.c +++ b/qla2x00t-32gbit/qla_gs.c @@ -2995,8 +2995,8 @@ void qla24xx_handle_gpsc_event(scsi_qla_host_t *vha, struct event_arg *ea) struct fc_port *fcport = ea->fcport; ql_dbg(ql_dbg_disc, vha, 0x20d8, - "%s %8phC DS %d LS %d rc %d login %d|%d rscn %d|%d lid %d\n", - __func__, fcport->port_name, fcport->disc_state, + "%s %s DS %d LS %d rc %d login %d|%d rscn %d|%d lid %d\n", + __func__, wwn_to_str(fcport->port_name), fcport->disc_state, fcport->fw_login_state, ea->rc, ea->sp->gen2, fcport->login_gen, ea->sp->gen2, fcport->rscn_gen|ea->sp->gen1, fcport->loop_id); @@ -3006,8 +3006,8 @@ void qla24xx_handle_gpsc_event(scsi_qla_host_t *vha, struct event_arg *ea) if (ea->sp->gen2 != fcport->login_gen) { /* target side must have changed it. */ ql_dbg(ql_dbg_disc, vha, 0x20d3, - "%s %8phC generation changed\n", - __func__, fcport->port_name); + "%s %s generation changed\n", + __func__, wwn_to_str(fcport->port_name)); return; } else if (ea->sp->gen1 != fcport->rscn_gen) { return; @@ -3027,9 +3027,8 @@ static void qla24xx_async_gpsc_sp_done(void *s, int res) ct_rsp = &fcport->ct_desc.ct_sns->p.rsp; - ql_dbg(ql_dbg_disc, vha, 0x2053, - "Async done-%s res %x, WWPN %8phC \n", - sp->name, res, fcport->port_name); + ql_dbg(ql_dbg_disc, vha, 0x2053, "Async done-%s res %x, WWPN %s \n", + sp->name, res, wwn_to_str(fcport->port_name)); if (res == QLA_FUNCTION_TIMEOUT) return; @@ -3073,8 +3072,8 @@ static void qla24xx_async_gpsc_sp_done(void *s, int res) } ql_dbg(ql_dbg_disc, vha, 0x2054, - "Async-%s OUT WWPN %8phC speeds=%04x speed=%04x.\n", - sp->name, fcport->fabric_port_name, + "Async-%s OUT WWPN %s speeds=%04x speed=%04x.\n", + sp->name, wwn_to_str(fcport->fabric_port_name), be16_to_cpu(ct_rsp->rsp.gpsc.speeds), be16_to_cpu(ct_rsp->rsp.gpsc.speed)); } @@ -3129,8 +3128,8 @@ int qla24xx_async_gpsc(scsi_qla_host_t *vha, fc_port_t *fcport) sp->done = qla24xx_async_gpsc_sp_done; ql_dbg(ql_dbg_disc, vha, 0x205e, - "Async-%s %8phC hdl=%x loopid=%x portid=%02x%02x%02x.\n", - sp->name, fcport->port_name, sp->handle, + "Async-%s %s hdl=%x loopid=%x portid=%02x%02x%02x.\n", + sp->name, wwn_to_str(fcport->port_name), sp->handle, fcport->loop_id, fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa); @@ -3255,16 +3254,16 @@ void qla24xx_handle_gpnid_event(scsi_qla_host_t *vha, struct event_arg *ea) case DSC_LOGIN_COMPLETE: /* recheck session is still intact. */ ql_dbg(ql_dbg_disc, vha, 0x210d, - "%s %d %8phC revalidate session with ADISC\n", - __func__, __LINE__, fcport->port_name); + "%s %d %s revalidate session with ADISC\n", + __func__, __LINE__, wwn_to_str(fcport->port_name)); data[0] = data[1] = 0; qla2x00_post_async_adisc_work(vha, fcport, data); break; case DSC_DELETED: ql_dbg(ql_dbg_disc, vha, 0x210d, - "%s %d %8phC login\n", __func__, __LINE__, - fcport->port_name); + "%s %d %s login\n", __func__, __LINE__, + wwn_to_str(fcport->port_name)); fcport->d_id = ea->id; qla24xx_fcport_handle_login(vha, fcport); break; @@ -3284,9 +3283,9 @@ void qla24xx_handle_gpnid_event(scsi_qla_host_t *vha, struct event_arg *ea) * conflict with new fcport. */ ql_dbg(ql_dbg_disc, vha, 0xffff, - "%s %d %8phC DS %d\n", + "%s %d %s DS %d\n", __func__, __LINE__, - conflict->port_name, + wwn_to_str(conflict->port_name), conflict->disc_state); conflict->scan_state = QLA_FCPORT_SCAN; @@ -3296,8 +3295,8 @@ void qla24xx_handle_gpnid_event(scsi_qla_host_t *vha, struct event_arg *ea) /* create new fcport */ ql_dbg(ql_dbg_disc, vha, 0x2065, - "%s %d %8phC post new sess\n", - __func__, __LINE__, ea->port_name); + "%s %d %s post new sess\n", + __func__, __LINE__, wwn_to_str(ea->port_name)); qla24xx_post_newsess_work(vha, &ea->id, ea->port_name, NULL, NULL, FC4_TYPE_UNKNOWN); } @@ -3318,14 +3317,20 @@ static void qla2x00_async_gpnid_sp_done(void *s, int res) if (res) ql_dbg(ql_dbg_disc, vha, 0x2066, - "Async done-%s fail res %x rscn gen %d ID %3phC. %8phC\n", - sp->name, res, sp->gen1, ct_req->req.port_id.port_id, - ct_rsp->rsp.gpn_id.port_name); + "Async done-%s fail res %x rscn gen %d ID %02x:%02x:%02x. %s\n", + sp->name, res, sp->gen1, + ct_req->req.port_id.port_id[0], + ct_req->req.port_id.port_id[1], + ct_req->req.port_id.port_id[2], + wwn_to_str(ct_rsp->rsp.gpn_id.port_name)); else ql_dbg(ql_dbg_disc, vha, 0x2066, - "Async done-%s good rscn gen %d ID %3phC. %8phC\n", - sp->name, sp->gen1, ct_req->req.port_id.port_id, - ct_rsp->rsp.gpn_id.port_name); + "Async done-%s good rscn gen %d ID %02x:%02x:%02x. %s\n", + sp->name, sp->gen1, + ct_req->req.port_id.port_id[0], + ct_req->req.port_id.port_id[1], + ct_req->req.port_id.port_id[2], + wwn_to_str(ct_rsp->rsp.gpn_id.port_name)); memset(&ea, 0, sizeof(ea)); memcpy(ea.port_name, ct_rsp->rsp.gpn_id.port_name, WWN_SIZE); @@ -3454,9 +3459,11 @@ int qla24xx_async_gpnid(scsi_qla_host_t *vha, port_id_t *id) sp->u.iocb_cmd.timeout = qla2x00_async_iocb_timeout; sp->done = qla2x00_async_gpnid_sp_done; - ql_dbg(ql_dbg_disc, vha, 0x2067, - "Async-%s hdl=%x ID %3phC.\n", sp->name, - sp->handle, ct_req->req.port_id.port_id); + ql_dbg(ql_dbg_disc, vha, 0x2067, "Async-%s hdl=%x ID %02x:%02x:%02x.\n", + sp->name, sp->handle, + ct_req->req.port_id.port_id[0], + ct_req->req.port_id.port_id[1], + ct_req->req.port_id.port_id[2]); rval = qla2x00_start_sp(sp); if (rval != QLA_SUCCESS) @@ -3505,8 +3512,8 @@ void qla24xx_async_gffid_sp_done(void *s, int res) struct event_arg ea; ql_dbg(ql_dbg_disc, vha, 0x2133, - "Async done-%s res %x ID %x. %8phC\n", - sp->name, res, fcport->d_id.b24, fcport->port_name); + "Async done-%s res %x ID %x. %s\n", + sp->name, res, fcport->d_id.b24, wwn_to_str(fcport->port_name)); fcport->flags &= ~FCF_ASYNC_SENT; ct_rsp = &fcport->ct_desc.ct_sns->p.rsp; @@ -3583,8 +3590,8 @@ int qla24xx_async_gffid(scsi_qla_host_t *vha, fc_port_t *fcport) sp->done = qla24xx_async_gffid_sp_done; ql_dbg(ql_dbg_disc, vha, 0x2132, - "Async-%s hdl=%x %8phC.\n", sp->name, - sp->handle, fcport->port_name); + "Async-%s hdl=%x %s.\n", sp->name, + sp->handle, wwn_to_str(fcport->port_name)); rval = qla2x00_start_sp(sp); if (rval != QLA_SUCCESS) @@ -3716,8 +3723,8 @@ void qla24xx_async_gnnft_done(scsi_qla_host_t *vha, srb_t *sp) if (!found) { ql_dbg(ql_dbg_disc, vha, 0xffff, - "%s %d %8phC post new sess\n", - __func__, __LINE__, rp->port_name); + "%s %d %s post new sess\n", + __func__, __LINE__, wwn_to_str(rp->port_name)); qla24xx_post_newsess_work(vha, &rp->id, rp->port_name, rp->node_name, NULL, rp->fc4type); } @@ -3748,9 +3755,9 @@ void qla24xx_async_gnnft_done(scsi_qla_host_t *vha, srb_t *sp) fcport->logout_on_delete = 0; ql_dbg(ql_dbg_disc, vha, 0x20f0, - "%s %d %8phC post del sess\n", + "%s %d %s post del sess\n", __func__, __LINE__, - fcport->port_name); + wwn_to_str(fcport->port_name)); qlt_schedule_sess_for_deletion(fcport); continue; @@ -4306,8 +4313,9 @@ static void qla2x00_async_gnnid_sp_done(void *s, int res) ea.event = FCME_GNNID_DONE; ql_dbg(ql_dbg_disc, vha, 0x204f, - "Async done-%s res %x, WWPN %8phC %8phC\n", - sp->name, res, fcport->port_name, fcport->node_name); + "Async done-%s res %x, WWPN %s %s\n", + sp->name, res, wwn_to_str(fcport->port_name), + wwn_to_str(fcport->node_name)); qla2x00_fcport_event_handler(vha, &ea); @@ -4359,8 +4367,8 @@ int qla24xx_async_gnnid(scsi_qla_host_t *vha, fc_port_t *fcport) sp->done = qla2x00_async_gnnid_sp_done; ql_dbg(ql_dbg_disc, vha, 0xffff, - "Async-%s - %8phC hdl=%x loopid=%x portid %06x.\n", - sp->name, fcport->port_name, + "Async-%s - %s hdl=%x loopid=%x portid %06x.\n", + sp->name, wwn_to_str(fcport->port_name), sp->handle, fcport->loop_id, fcport->d_id.b24); rval = qla2x00_start_sp(sp); @@ -4398,8 +4406,8 @@ void qla24xx_handle_gfpnid_event(scsi_qla_host_t *vha, struct event_arg *ea) fc_port_t *fcport = ea->fcport; ql_dbg(ql_dbg_disc, vha, 0xffff, - "%s %8phC DS %d LS %d rc %d login %d|%d rscn %d|%d fcpcnt %d\n", - __func__, fcport->port_name, fcport->disc_state, + "%s %s DS %d LS %d rc %d login %d|%d rscn %d|%d fcpcnt %d\n", + __func__, wwn_to_str(fcport->port_name), fcport->disc_state, fcport->fw_login_state, ea->rc, fcport->login_gen, ea->sp->gen2, fcport->rscn_gen, ea->sp->gen1, vha->fcport_count); @@ -4409,8 +4417,8 @@ void qla24xx_handle_gfpnid_event(scsi_qla_host_t *vha, struct event_arg *ea) if (ea->sp->gen2 != fcport->login_gen) { /* target side must have changed it. */ ql_dbg(ql_dbg_disc, vha, 0x20d3, - "%s %8phC generation changed\n", - __func__, fcport->port_name); + "%s %s generation changed\n", + __func__, wwn_to_str(fcport->port_name)); return; } else if (ea->sp->gen1 != fcport->rscn_gen) { return; @@ -4439,8 +4447,9 @@ static void qla2x00_async_gfpnid_sp_done(void *s, int res) ea.event = FCME_GFPNID_DONE; ql_dbg(ql_dbg_disc, vha, 0x204f, - "Async done-%s res %x, WWPN %8phC %8phC\n", - sp->name, res, fcport->port_name, fcport->fabric_port_name); + "Async done-%s res %x, WWPN %s %s\n", + sp->name, res, wwn_to_str(fcport->port_name), + wwn_to_str(fcport->fabric_port_name)); qla2x00_fcport_event_handler(vha, &ea); @@ -4490,8 +4499,8 @@ int qla24xx_async_gfpnid(scsi_qla_host_t *vha, fc_port_t *fcport) sp->done = qla2x00_async_gfpnid_sp_done; ql_dbg(ql_dbg_disc, vha, 0xffff, - "Async-%s - %8phC hdl=%x loopid=%x portid %06x.\n", - sp->name, fcport->port_name, + "Async-%s - %s hdl=%x loopid=%x portid %06x.\n", + sp->name, wwn_to_str(fcport->port_name), sp->handle, fcport->loop_id, fcport->d_id.b24); rval = qla2x00_start_sp(sp); diff --git a/qla2x00t-32gbit/qla_init.c b/qla2x00t-32gbit/qla_init.c index 4ca4f0023..d020aa2ae 100644 --- a/qla2x00t-32gbit/qla_init.c +++ b/qla2x00t-32gbit/qla_init.c @@ -105,8 +105,9 @@ qla2x00_async_iocb_timeout(void *data) if (fcport) { ql_dbg(ql_dbg_disc, fcport->vha, 0x2071, - "Async-%s timeout - hdl=%x portid=%06x %8phC.\n", - sp->name, sp->handle, fcport->d_id.b24, fcport->port_name); + "Async-%s timeout - hdl=%x portid=%06x %s.\n", + sp->name, sp->handle, fcport->d_id.b24, + wwn_to_str(fcport->port_name)); fcport->flags &= ~(FCF_ASYNC_SENT | FCF_ASYNC_ACTIVE); } else { @@ -171,8 +172,8 @@ qla2x00_async_login_sp_done(void *ptr, int res) struct srb_iocb *lio = &sp->u.iocb_cmd; struct event_arg ea; - ql_dbg(ql_dbg_disc, vha, 0x20dd, - "%s %8phC res %d \n", __func__, sp->fcport->port_name, res); + ql_dbg(ql_dbg_disc, vha, 0x20dd, "%s %s res %d \n", __func__, + wwn_to_str(sp->fcport->port_name), res); sp->fcport->flags &= ~(FCF_ASYNC_SENT | FCF_ASYNC_ACTIVE); @@ -245,8 +246,9 @@ qla2x00_async_login(struct scsi_qla_host *vha, fc_port_t *fcport, lio->u.logio.flags |= SRB_LOGIN_SKIP_PRLI; ql_dbg(ql_dbg_disc, vha, 0x2072, - "Async-login - %8phC hdl=%x, loopid=%x portid=%02x%02x%02x " - "retries=%d.\n", fcport->port_name, sp->handle, fcport->loop_id, + "Async-login - %s hdl=%x, loopid=%x portid=%02x%02x%02x " + "retries=%d.\n", wwn_to_str(fcport->port_name), sp->handle, + fcport->loop_id, fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa, fcport->login_retry); @@ -303,10 +305,10 @@ qla2x00_async_logout(struct scsi_qla_host *vha, fc_port_t *fcport) sp->done = qla2x00_async_logout_sp_done; ql_dbg(ql_dbg_disc, vha, 0x2070, - "Async-logout - hdl=%x loop-id=%x portid=%02x%02x%02x %8phC.\n", + "Async-logout - hdl=%x loop-id=%x portid=%02x%02x%02x %s.\n", sp->handle, fcport->loop_id, fcport->d_id.b.domain, - fcport->d_id.b.area, fcport->d_id.b.al_pa, - fcport->port_name); + fcport->d_id.b.area, fcport->d_id.b.al_pa, + wwn_to_str(fcport->port_name)); rval = qla2x00_start_sp(sp); if (rval != QLA_SUCCESS) @@ -390,15 +392,15 @@ void qla24xx_handle_adisc_event(scsi_qla_host_t *vha, struct event_arg *ea) struct fc_port *fcport = ea->fcport; ql_dbg(ql_dbg_disc, vha, 0x20d2, - "%s %8phC DS %d LS %d rc %d login %d|%d rscn %d|%d lid %d\n", - __func__, fcport->port_name, fcport->disc_state, + "%s %s DS %d LS %d rc %d login %d|%d rscn %d|%d lid %d\n", + __func__, wwn_to_str(fcport->port_name), fcport->disc_state, fcport->fw_login_state, ea->rc, fcport->login_gen, ea->sp->gen2, fcport->rscn_gen, ea->sp->gen1, fcport->loop_id); if (ea->data[0] != MBS_COMMAND_COMPLETE) { ql_dbg(ql_dbg_disc, vha, 0x2066, - "%s %8phC: adisc fail: post delete\n", - __func__, ea->fcport->port_name); + "%s %s: adisc fail: post delete\n", + __func__, wwn_to_str(ea->fcport->port_name)); /* deleted = 0 & logout_on_delete = force fw cleanup */ fcport->deleted = 0; fcport->logout_on_delete = 1; @@ -412,8 +414,8 @@ void qla24xx_handle_adisc_event(scsi_qla_host_t *vha, struct event_arg *ea) if (ea->sp->gen2 != ea->fcport->login_gen) { /* target side must have changed it. */ ql_dbg(ql_dbg_disc, vha, 0x20d3, - "%s %8phC generation changed\n", - __func__, ea->fcport->port_name); + "%s %s generation changed\n", + __func__, wwn_to_str(ea->fcport->port_name)); return; } else if (ea->sp->gen1 != ea->fcport->rscn_gen) { qla_rscn_replay(fcport); @@ -445,9 +447,8 @@ qla2x00_async_adisc_sp_done(void *ptr, int res) struct event_arg ea; struct srb_iocb *lio = &sp->u.iocb_cmd; - ql_dbg(ql_dbg_disc, vha, 0x2066, - "Async done-%s res %x %8phC\n", - sp->name, res, sp->fcport->port_name); + ql_dbg(ql_dbg_disc, vha, 0x2066, "Async done-%s res %x %s\n", + sp->name, res, wwn_to_str(sp->fcport->port_name)); sp->fcport->flags &= ~(FCF_ASYNC_SENT | FCF_ASYNC_ACTIVE); @@ -496,8 +497,9 @@ qla2x00_async_adisc(struct scsi_qla_host *vha, fc_port_t *fcport, lio->u.logio.flags |= SRB_LOGIN_RETRIED; ql_dbg(ql_dbg_disc, vha, 0x206f, - "Async-adisc - hdl=%x loopid=%x portid=%06x %8phC.\n", - sp->handle, fcport->loop_id, fcport->d_id.b24, fcport->port_name); + "Async-adisc - hdl=%x loopid=%x portid=%06x %s.\n", + sp->handle, fcport->loop_id, fcport->d_id.b24, + wwn_to_str(fcport->port_name)); rval = qla2x00_start_sp(sp); if (rval != QLA_SUCCESS) @@ -526,8 +528,8 @@ static void qla24xx_handle_gnl_done_event(scsi_qla_host_t *vha, fcport = ea->fcport; ql_dbg(ql_dbg_disc, vha, 0xffff, - "%s %8phC DS %d LS rc %d %d login %d|%d rscn %d|%d lid %d\n", - __func__, fcport->port_name, fcport->disc_state, + "%s %s DS %d LS rc %d %d login %d|%d rscn %d|%d lid %d\n", + __func__, wwn_to_str(fcport->port_name), fcport->disc_state, fcport->fw_login_state, ea->rc, fcport->login_gen, fcport->last_login_gen, fcport->rscn_gen, fcport->last_rscn_gen, vha->loop_id); @@ -550,16 +552,16 @@ static void qla24xx_handle_gnl_done_event(scsi_qla_host_t *vha, return; } else if (fcport->last_login_gen != fcport->login_gen) { ql_dbg(ql_dbg_disc, vha, 0x20e0, - "%s %8phC login gen changed\n", - __func__, fcport->port_name); + "%s %s login gen changed\n", + __func__, wwn_to_str(fcport->port_name)); return; } n = ea->data[0] / sizeof(struct get_name_list_extended); ql_dbg(ql_dbg_disc, vha, 0x20e1, - "%s %d %8phC n %d %02x%02x%02x lid %d \n", - __func__, __LINE__, fcport->port_name, n, + "%s %d %s n %d %02x%02x%02x lid %d \n", + __func__, __LINE__, wwn_to_str(fcport->port_name), n, fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa, fcport->loop_id); @@ -588,8 +590,8 @@ static void qla24xx_handle_gnl_done_event(scsi_qla_host_t *vha, ql_dbg(ql_dbg_disc, vha, 0x20e2, - "%s found %8phC CLS [%x|%x] nvme %d ID[%02x%02x%02x|%02x%02x%02x] lid[%d|%d]\n", - __func__, fcport->port_name, + "%s found %s CLS [%x|%x] nvme %d ID[%02x%02x%02x|%02x%02x%02x] lid[%d|%d]\n", + __func__, wwn_to_str(fcport->port_name), e->current_login_state, fcport->fw_login_state, fcport->fc4f_nvme, id.b.domain, id.b.area, id.b.al_pa, fcport->d_id.b.domain, fcport->d_id.b.area, @@ -605,8 +607,9 @@ static void qla24xx_handle_gnl_done_event(scsi_qla_host_t *vha, (fcport->loop_id != FC_NO_LOOP_ID && fcport->loop_id != loop_id)) { ql_dbg(ql_dbg_disc, vha, 0x20e3, - "%s %d %8phC post del sess\n", - __func__, __LINE__, fcport->port_name); + "%s %d %s post del sess\n", + __func__, __LINE__, + wwn_to_str(fcport->port_name)); qlt_schedule_sess_for_deletion(fcport); return; } @@ -634,8 +637,9 @@ static void qla24xx_handle_gnl_done_event(scsi_qla_host_t *vha, switch (current_login_state) { case DSC_LS_PRLI_COMP: ql_dbg(ql_dbg_disc + ql_dbg_verbose, - vha, 0x20e4, "%s %d %8phC post gpdb\n", - __func__, __LINE__, fcport->port_name); + vha, 0x20e4, "%s %d %s post gpdb\n", + __func__, __LINE__, + wwn_to_str(fcport->port_name)); if ((e->prli_svc_param_word_3[0] & BIT_4) == 0) fcport->port_type = FCT_INITIATOR; @@ -653,8 +657,8 @@ static void qla24xx_handle_gnl_done_event(scsi_qla_host_t *vha, DSC_LS_PORT_UNAVAIL; } ql_dbg(ql_dbg_disc, vha, 0x20e5, - "%s %d %8phC\n", __func__, __LINE__, - fcport->port_name); + "%s %d %s\n", __func__, __LINE__, + wwn_to_str(fcport->port_name)); qla24xx_fcport_handle_login(vha, fcport); break; } @@ -720,9 +724,9 @@ static void qla24xx_handle_gnl_done_event(scsi_qla_host_t *vha, if (conflict_fcport) { ql_dbg(ql_dbg_disc + ql_dbg_verbose, vha, 0x20e5, - "%s %d %8phC post del sess\n", + "%s %d %s post del sess\n", __func__, __LINE__, - conflict_fcport->port_name); + wwn_to_str(conflict_fcport->port_name)); qlt_schedule_sess_for_deletion (conflict_fcport); } @@ -821,8 +825,8 @@ qla24xx_async_gnl_sp_done(void *s, int res) wwn = wwn_to_u64(e->port_name); ql_dbg(ql_dbg_disc + ql_dbg_verbose, vha, 0x20e8, - "%s %8phC %02x:%02x:%02x state %d/%d lid %x \n", - __func__, (void *)&wwn, e->port_id[2], e->port_id[1], + "%s %s %02x:%02x:%02x state %d/%d lid %x \n", + __func__, wwn_to_str((u8*)&wwn), e->port_id[2], e->port_id[1], e->port_id[0], e->current_login_state, e->last_login_state, (loop_id & 0x7fff)); } @@ -869,8 +873,8 @@ qla24xx_async_gnl_sp_done(void *s, int res) if (!found && wwn && !IS_SW_RESV_ADDR(id)) { ql_dbg(ql_dbg_disc, vha, 0x2065, - "%s %d %8phC %06x post new sess\n", - __func__, __LINE__, (u8 *)&wwn, id.b24); + "%s %d %s %06x post new sess\n", + __func__, __LINE__, wwn_to_str((u8 *)&wwn), id.b24); wwnn = wwn_to_u64(e->node_name); qla24xx_post_newsess_work(vha, &id, (u8 *)&wwn, (u8 *)&wwnn, NULL, FC4_TYPE_UNKNOWN); @@ -895,8 +899,8 @@ int qla24xx_async_gnl(struct scsi_qla_host *vha, fc_port_t *fcport) if (!vha->flags.online || (fcport->flags & FCF_ASYNC_SENT)) return rval; - ql_dbg(ql_dbg_disc, vha, 0x20d9, - "Async-gnlist WWPN %8phC \n", fcport->port_name); + ql_dbg(ql_dbg_disc, vha, 0x20d9, "Async-gnlist WWPN %s\n", + wwn_to_str(fcport->port_name)); spin_lock_irqsave(&vha->hw->tgt.sess_lock, flags); fcport->flags |= FCF_ASYNC_SENT; @@ -937,9 +941,8 @@ int qla24xx_async_gnl(struct scsi_qla_host *vha, fc_port_t *fcport) sp->done = qla24xx_async_gnl_sp_done; - ql_dbg(ql_dbg_disc, vha, 0x20da, - "Async-%s - OUT WWPN %8phC hndl %x\n", - sp->name, fcport->port_name, sp->handle); + ql_dbg(ql_dbg_disc, vha, 0x20da, "Async-%s - OUT WWPN %s hndl %x\n", + sp->name, wwn_to_str(fcport->port_name), sp->handle); rval = qla2x00_start_sp(sp); if (rval != QLA_SUCCESS) @@ -978,8 +981,8 @@ void qla24xx_async_gpdb_sp_done(void *s, int res) struct event_arg ea; ql_dbg(ql_dbg_disc, vha, 0x20db, - "Async done-%s res %x, WWPN %8phC mb[1]=%x mb[2]=%x \n", - sp->name, res, fcport->port_name, mb[1], mb[2]); + "Async done-%s res %x, WWPN %s mb[1]=%x mb[2]=%x \n", + sp->name, res, wwn_to_str(fcport->port_name), mb[1], mb[2]); if (res == QLA_FUNCTION_TIMEOUT) { dma_pool_free(sp->vha->hw->s_dma_pool, sp->u.iocb_cmd.u.mbx.in, @@ -1022,9 +1025,8 @@ qla2x00_async_prli_sp_done(void *ptr, int res) struct srb_iocb *lio = &sp->u.iocb_cmd; struct event_arg ea; - ql_dbg(ql_dbg_disc, vha, 0x2129, - "%s %8phC res %d \n", __func__, - sp->fcport->port_name, res); + ql_dbg(ql_dbg_disc, vha, 0x2129, "%s %s res %d \n", __func__, + wwn_to_str(sp->fcport->port_name), res); sp->fcport->flags &= ~FCF_ASYNC_SENT; @@ -1079,8 +1081,9 @@ qla24xx_async_prli(struct scsi_qla_host *vha, fc_port_t *fcport) lio->u.logio.flags |= SRB_LOGIN_NVME_PRLI; ql_dbg(ql_dbg_disc, vha, 0x211b, - "Async-prli - %8phC hdl=%x, loopid=%x portid=%06x retries=%d %s.\n", - fcport->port_name, sp->handle, fcport->loop_id, fcport->d_id.b24, + "Async-prli - %s hdl=%x, loopid=%x portid=%06x retries=%d %s.\n", + wwn_to_str(fcport->port_name), sp->handle, fcport->loop_id, + fcport->d_id.b24, fcport->login_retry, fcport->fc4f_nvme ? "nvme" : "fc"); rval = qla2x00_start_sp(sp); @@ -1163,9 +1166,8 @@ int qla24xx_async_gpdb(struct scsi_qla_host *vha, fc_port_t *fcport, u8 opt) sp->done = qla24xx_async_gpdb_sp_done; - ql_dbg(ql_dbg_disc, vha, 0x20dc, - "Async-%s %8phC hndl %x opt %x\n", - sp->name, fcport->port_name, sp->handle, opt); + ql_dbg(ql_dbg_disc, vha, 0x20dc, "Async-%s %s hndl %x opt %x\n", + sp->name, wwn_to_str(fcport->port_name), sp->handle, opt); rval = qla2x00_start_sp(sp); if (rval != QLA_SUCCESS) @@ -1207,8 +1209,8 @@ void __qla24xx_handle_gpdb_event(scsi_qla_host_t *vha, struct event_arg *ea) * Session is still valid. */ ql_dbg(ql_dbg_disc, vha, 0x20d6, - "%s %d %8phC session revalidate success\n", - __func__, __LINE__, ea->fcport->port_name); + "%s %d %s session revalidate success\n", + __func__, __LINE__, wwn_to_str(ea->fcport->port_name)); ea->fcport->disc_state = DSC_LOGIN_COMPLETE; } spin_unlock_irqrestore(&vha->hw->tgt.sess_lock, flags); @@ -1226,8 +1228,8 @@ void qla24xx_handle_gpdb_event(scsi_qla_host_t *vha, struct event_arg *ea) fcport->flags &= ~FCF_ASYNC_SENT; - ql_dbg(ql_dbg_disc, vha, 0x20d2, - "%s %8phC DS %d LS %d nvme %x rc %d\n", __func__, fcport->port_name, + ql_dbg(ql_dbg_disc, vha, 0x20d2, "%s %s DS %d LS %d nvme %x rc %d\n", + __func__, wwn_to_str(fcport->port_name), fcport->disc_state, pd->current_login_state, fcport->fc4f_nvme, ea->rc); @@ -1242,9 +1244,8 @@ void qla24xx_handle_gpdb_event(scsi_qla_host_t *vha, struct event_arg *ea) if (ea->sp->gen2 != fcport->login_gen) { /* target side must have changed it. */ - ql_dbg(ql_dbg_disc, vha, 0x20d3, - "%s %8phC generation changed\n", - __func__, fcport->port_name); + ql_dbg(ql_dbg_disc, vha, 0x20d3, "%s %s generation changed\n", + __func__, wwn_to_str(fcport->port_name)); return; } else if (ea->sp->gen1 != fcport->rscn_gen) { qla_rscn_replay(fcport); @@ -1270,8 +1271,8 @@ void qla24xx_handle_gpdb_event(scsi_qla_host_t *vha, struct event_arg *ea) case PDS_LOGO_PENDING: case PDS_PORT_UNAVAILABLE: default: - ql_dbg(ql_dbg_disc, vha, 0x20d5, "%s %d %8phC post del sess\n", - __func__, __LINE__, fcport->port_name); + ql_dbg(ql_dbg_disc, vha, 0x20d5, "%s %d %s post del sess\n", + __func__, __LINE__, wwn_to_str(fcport->port_name)); qlt_schedule_sess_for_deletion(fcport); return; } @@ -1313,16 +1314,16 @@ static void qla_chk_n2n_b4_login(struct scsi_qla_host *vha, fc_port_t *fcport) rc = qla2x00_find_new_loop_id(vha, fcport); if (rc) { ql_dbg(ql_dbg_disc, vha, 0x20e6, - "%s %d %8phC post del sess - out of loopid\n", - __func__, __LINE__, fcport->port_name); + "%s %d %s post del sess - out of loopid\n", + __func__, __LINE__, + wwn_to_str(fcport->port_name)); fcport->scan_state = 0; qlt_schedule_sess_for_deletion(fcport); return; } } - ql_dbg(ql_dbg_disc, vha, 0x20bf, - "%s %d %8phC post login\n", - __func__, __LINE__, fcport->port_name); + ql_dbg(ql_dbg_disc, vha, 0x20bf, "%s %d %s post login\n", + __func__, __LINE__, wwn_to_str(fcport->port_name)); qla2x00_post_async_login_work(vha, fcport, NULL); } } @@ -1334,8 +1335,8 @@ int qla24xx_fcport_handle_login(struct scsi_qla_host *vha, fc_port_t *fcport) u16 sec; ql_dbg(ql_dbg_disc + ql_dbg_verbose, vha, 0x20d8, - "%s %8phC DS %d LS %d P %d fl %x confl %p rscn %d|%d login %d lid %d scan %d\n", - __func__, fcport->port_name, fcport->disc_state, + "%s %s DS %d LS %d P %d fl %x confl %p rscn %d|%d login %d lid %d scan %d\n", + __func__, wwn_to_str(fcport->port_name), fcport->disc_state, fcport->fw_login_state, fcport->login_pause, fcport->flags, fcport->conflict, fcport->last_rscn_gen, fcport->rscn_gen, fcport->login_gen, fcport->loop_id, fcport->scan_state); @@ -1382,8 +1383,8 @@ int qla24xx_fcport_handle_login(struct scsi_qla_host *vha, fc_port_t *fcport) qla_post_els_plogi_work(vha, fcport); } else { ql_log(ql_log_info, vha, 0x705d, - "Unable to reach remote port %8phC", - fcport->port_name); + "Unable to reach remote port %s", + wwn_to_str(fcport->port_name)); } } else { qla24xx_post_gnl_work(vha, fcport); @@ -1392,13 +1393,14 @@ int qla24xx_fcport_handle_login(struct scsi_qla_host *vha, fc_port_t *fcport) default: if (wwn == 0) { ql_dbg(ql_dbg_disc, vha, 0xffff, - "%s %d %8phC post GNNID\n", - __func__, __LINE__, fcport->port_name); + "%s %d %s post GNNID\n", + __func__, __LINE__, + wwn_to_str(fcport->port_name)); qla24xx_post_gnnid_work(vha, fcport); } else if (fcport->loop_id == FC_NO_LOOP_ID) { ql_dbg(ql_dbg_disc, vha, 0x20bd, - "%s %d %8phC post gnl\n", - __func__, __LINE__, fcport->port_name); + "%s %d %s post gnl\n", + __func__, __LINE__, wwn_to_str(fcport->port_name)); qla24xx_post_gnl_work(vha, fcport); } else { qla_chk_n2n_b4_login(vha, fcport); @@ -1412,15 +1414,15 @@ int qla24xx_fcport_handle_login(struct scsi_qla_host *vha, fc_port_t *fcport) case ISP_CFG_N: if ((fcport->current_login_state & 0xf) == 0x6) { ql_dbg(ql_dbg_disc, vha, 0x2118, - "%s %d %8phC post GPDB work\n", - __func__, __LINE__, fcport->port_name); + "%s %d %s post GPDB work\n", + __func__, __LINE__, wwn_to_str(fcport->port_name)); fcport->chip_reset = vha->hw->base_qpair->chip_reset; qla24xx_post_gpdb_work(vha, fcport, 0); } else { ql_dbg(ql_dbg_disc, vha, 0x2118, - "%s %d %8phC post NVMe PRLI\n", - __func__, __LINE__, fcport->port_name); + "%s %d %s post NVMe PRLI\n", + __func__, __LINE__, wwn_to_str(fcport->port_name)); qla24xx_post_prli_work(vha, fcport); } break; @@ -1461,8 +1463,8 @@ int qla24xx_fcport_handle_login(struct scsi_qla_host *vha, fc_port_t *fcport) !(sec % 60)) { fcport->sec_since_registration = sec; ql_dbg(ql_dbg_disc, fcport->vha, 0xffff, - "%s %8phC - Slow Rport registration(%d Sec)\n", - __func__, fcport->port_name, sec); + "%s %s - Slow Rport registration(%d Sec)\n", + __func__, wwn_to_str(fcport->port_name), sec); } if (fcport->next_disc_state != DSC_DELETE_PEND) @@ -1502,8 +1504,8 @@ void qla24xx_handle_relogin_event(scsi_qla_host_t *vha, fc_port_t *fcport = ea->fcport; ql_dbg(ql_dbg_disc, vha, 0x2102, - "%s %8phC DS %d LS %d P %d del %d cnfl %p rscn %d|%d login %d|%d fl %x\n", - __func__, fcport->port_name, fcport->disc_state, + "%s %s DS %d LS %d P %d del %d cnfl %p rscn %d|%d login %d|%d fl %x\n", + __func__, wwn_to_str(fcport->port_name), fcport->disc_state, fcport->fw_login_state, fcport->login_pause, fcport->deleted, fcport->conflict, fcport->last_rscn_gen, fcport->rscn_gen, @@ -1522,8 +1524,8 @@ void qla24xx_handle_relogin_event(scsi_qla_host_t *vha, } if (fcport->last_rscn_gen != fcport->rscn_gen) { - ql_dbg(ql_dbg_disc, vha, 0x20e9, "%s %d %8phC post gidpn\n", - __func__, __LINE__, fcport->port_name); + ql_dbg(ql_dbg_disc, vha, 0x20e9, "%s %d %s post gidpn\n", + __func__, __LINE__, wwn_to_str(fcport->port_name)); return; } @@ -1535,9 +1537,8 @@ void qla24xx_handle_relogin_event(scsi_qla_host_t *vha, static void qla_handle_els_plogi_done(scsi_qla_host_t *vha, struct event_arg *ea) { - ql_dbg(ql_dbg_disc, vha, 0x2118, - "%s %d %8phC post PRLI\n", - __func__, __LINE__, ea->fcport->port_name); + ql_dbg(ql_dbg_disc, vha, 0x2118, "%s %d %s post PRLI\n", + __func__, __LINE__, wwn_to_str(ea->fcport->port_name)); qla24xx_post_prli_work(vha, ea->fcport); } @@ -1826,9 +1827,8 @@ qla24xx_handle_prli_done_event(struct scsi_qla_host *vha, struct event_arg *ea) { switch (ea->data[0]) { case MBS_COMMAND_COMPLETE: - ql_dbg(ql_dbg_disc, vha, 0x2118, - "%s %d %8phC post gpdb\n", - __func__, __LINE__, ea->fcport->port_name); + ql_dbg(ql_dbg_disc, vha, 0x2118, "%s %d %s post gpdb\n", + __func__, __LINE__, wwn_to_str(ea->fcport->port_name)); ea->fcport->chip_reset = vha->hw->base_qpair->chip_reset; ea->fcport->logout_on_delete = 1; @@ -1850,15 +1850,15 @@ qla24xx_handle_prli_done_event(struct scsi_qla_host *vha, struct event_arg *ea) if (ea->fcport->n2n_flag) { ql_dbg(ql_dbg_disc, vha, 0x2118, - "%s %d %8phC post fc4 prli\n", - __func__, __LINE__, ea->fcport->port_name); + "%s %d %s post fc4 prli\n", + __func__, __LINE__, wwn_to_str(ea->fcport->port_name)); ea->fcport->fc4f_nvme = 0; ea->fcport->n2n_flag = 0; qla24xx_post_prli_work(vha, ea->fcport); } ql_dbg(ql_dbg_disc, vha, 0x2119, - "%s %d %8phC unhandle event of %x\n", - __func__, __LINE__, ea->fcport->port_name, ea->data[0]); + "%s %d %s unhandle event of %x\n", + __func__, __LINE__, wwn_to_str(ea->fcport->port_name), ea->data[0]); break; } } @@ -1873,8 +1873,8 @@ qla24xx_handle_plogi_done_event(struct scsi_qla_host *vha, struct event_arg *ea) struct fc_port *fcport = ea->fcport; ql_dbg(ql_dbg_disc, vha, 0xffff, - "%s %8phC DS %d LS %d rc %d login %d|%d rscn %d|%d data %x|%x iop %x|%x\n", - __func__, fcport->port_name, fcport->disc_state, + "%s %s DS %d LS %d rc %d login %d|%d rscn %d|%d data %x|%x iop %x|%x\n", + __func__, wwn_to_str(fcport->port_name), fcport->disc_state, fcport->fw_login_state, ea->rc, ea->sp->gen2, fcport->login_gen, ea->sp->gen1, fcport->rscn_gen, ea->data[0], ea->data[1], ea->iop[0], ea->iop[1]); @@ -1882,8 +1882,8 @@ qla24xx_handle_plogi_done_event(struct scsi_qla_host *vha, struct event_arg *ea) if ((fcport->fw_login_state == DSC_LS_PLOGI_PEND) || (fcport->fw_login_state == DSC_LS_PRLI_PEND)) { ql_dbg(ql_dbg_disc, vha, 0x20ea, - "%s %d %8phC Remote is trying to login\n", - __func__, __LINE__, fcport->port_name); + "%s %d %s Remote is trying to login\n", + __func__, __LINE__, wwn_to_str(fcport->port_name)); return; } @@ -1893,14 +1893,14 @@ qla24xx_handle_plogi_done_event(struct scsi_qla_host *vha, struct event_arg *ea) if (ea->sp->gen2 != fcport->login_gen) { /* target side must have changed it. */ ql_dbg(ql_dbg_disc, vha, 0x20d3, - "%s %8phC generation changed\n", - __func__, fcport->port_name); + "%s %s generation changed\n", + __func__, wwn_to_str(fcport->port_name)); set_bit(RELOGIN_NEEDED, &vha->dpc_flags); return; } else if (ea->sp->gen1 != fcport->rscn_gen) { ql_dbg(ql_dbg_disc, vha, 0x20d3, - "%s %8phC RSCN generation changed\n", - __func__, fcport->port_name); + "%s %s RSCN generation changed\n", + __func__, wwn_to_str(fcport->port_name)); qla_rscn_replay(fcport); qlt_schedule_sess_for_deletion(fcport); return; @@ -1915,13 +1915,13 @@ qla24xx_handle_plogi_done_event(struct scsi_qla_host *vha, struct event_arg *ea) */ if (ea->fcport->fc4f_nvme) { ql_dbg(ql_dbg_disc, vha, 0x2117, - "%s %d %8phC post prli\n", - __func__, __LINE__, ea->fcport->port_name); + "%s %d %s post prli\n", + __func__, __LINE__, wwn_to_str(ea->fcport->port_name)); qla24xx_post_prli_work(vha, ea->fcport); } else { ql_dbg(ql_dbg_disc, vha, 0x20ea, - "%s %d %8phC LoopID 0x%x in use with %06x. post gnl\n", - __func__, __LINE__, ea->fcport->port_name, + "%s %d %s LoopID 0x%x in use with %06x. post gnl\n", + __func__, __LINE__, wwn_to_str(ea->fcport->port_name), ea->fcport->loop_id, ea->fcport->d_id.b24); set_bit(ea->fcport->loop_id, vha->hw->loop_id_map); @@ -1936,8 +1936,8 @@ qla24xx_handle_plogi_done_event(struct scsi_qla_host *vha, struct event_arg *ea) } break; case MBS_COMMAND_ERROR: - ql_dbg(ql_dbg_disc, vha, 0x20eb, "%s %d %8phC cmd error %x\n", - __func__, __LINE__, ea->fcport->port_name, ea->data[1]); + ql_dbg(ql_dbg_disc, vha, 0x20eb, "%s %d %s cmd error %x\n", + __func__, __LINE__, wwn_to_str(ea->fcport->port_name), ea->data[1]); ea->fcport->flags &= ~FCF_ASYNC_SENT; ea->fcport->disc_state = DSC_LOGIN_FAILED; @@ -1954,8 +1954,8 @@ qla24xx_handle_plogi_done_event(struct scsi_qla_host *vha, struct event_arg *ea) cid.b.rsvd_1 = 0; ql_dbg(ql_dbg_disc, vha, 0x20ec, - "%s %d %8phC lid %#x in use with pid %06x post gnl\n", - __func__, __LINE__, ea->fcport->port_name, + "%s %d %s lid %#x in use with pid %06x post gnl\n", + __func__, __LINE__, wwn_to_str(ea->fcport->port_name), ea->fcport->loop_id, cid.b24); set_bit(ea->fcport->loop_id, vha->hw->loop_id_map); @@ -1978,13 +1978,13 @@ qla24xx_handle_plogi_done_event(struct scsi_qla_host *vha, struct event_arg *ea) ea->fcport->login_pause = 1; ql_dbg(ql_dbg_disc, vha, 0x20ed, - "%s %d %8phC NPortId %06x inuse with loopid 0x%x. post gidpn\n", - __func__, __LINE__, ea->fcport->port_name, + "%s %d %s NPortId %06x inuse with loopid 0x%x. post gidpn\n", + __func__, __LINE__, wwn_to_str(ea->fcport->port_name), ea->fcport->d_id.b24, lid); } else { ql_dbg(ql_dbg_disc, vha, 0x20ed, - "%s %d %8phC NPortId %06x inuse with loopid 0x%x. sched delete\n", - __func__, __LINE__, ea->fcport->port_name, + "%s %d %s NPortId %06x inuse with loopid 0x%x. sched delete\n", + __func__, __LINE__, wwn_to_str(ea->fcport->port_name), ea->fcport->d_id.b24, lid); qla2x00_clear_loop_id(ea->fcport); @@ -4667,7 +4667,7 @@ qla2x00_rport_del(void *data) if (rport) { ql_dbg(ql_dbg_disc, fcport->vha, 0x210b, "%s %8phN. rport %p roles %x\n", - __func__, fcport->port_name, rport, + __func__, wwn_to_str(fcport->port_name), rport, rport->roles); fc_remote_port_delete(rport); @@ -5089,9 +5089,9 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha) fcport->port_type != FCT_INITIATOR && fcport->port_type != FCT_BROADCAST) { ql_dbg(ql_dbg_disc, vha, 0x20f0, - "%s %d %8phC post del sess\n", + "%s %d %s post del sess\n", __func__, __LINE__, - fcport->port_name); + wwn_to_str(fcport->port_name)); qlt_schedule_sess_for_deletion(fcport); continue; @@ -5142,7 +5142,7 @@ qla2x00_iidma_fcport(scsi_qla_host_t *vha, fc_port_t *fcport) ql_dbg(ql_dbg_disc, vha, 0x2005, "iIDMA adjusted to %s GB/s (%X) on %8phN.\n", qla2x00_get_link_speed_str(ha, fcport->fp_speed), - fcport->fp_speed, fcport->port_name); + fcport->fp_speed, wwn_to_str(fcport->port_name)); } } @@ -5201,7 +5201,7 @@ qla2x00_reg_remote_port(scsi_qla_host_t *vha, fc_port_t *fcport) ql_dbg(ql_dbg_disc, vha, 0x20ee, "%s %8phN. rport %p is %s mode\n", - __func__, fcport->port_name, rport, + __func__, wwn_to_str(fcport->port_name), rport, (fcport->port_type == FCT_TARGET) ? "tgt" : "ini"); fc_remote_port_rolechg(rport, rport_ids.roles); @@ -5228,8 +5228,8 @@ qla2x00_update_fcport(scsi_qla_host_t *vha, fc_port_t *fcport) if (IS_SW_RESV_ADDR(fcport->d_id)) return; - ql_dbg(ql_dbg_disc, vha, 0x20ef, "%s %8phC\n", - __func__, fcport->port_name); + ql_dbg(ql_dbg_disc, vha, 0x20ef, "%s %s\n", + __func__, wwn_to_str(fcport->port_name)); fcport->disc_state = DSC_UPD_FCPORT; fcport->login_retry = vha->hw->login_retry_count; @@ -5284,14 +5284,14 @@ qla2x00_update_fcport(scsi_qla_host_t *vha, fc_port_t *fcport) if (fcport->id_changed) { fcport->id_changed = 0; ql_dbg(ql_dbg_disc, vha, 0x20d7, - "%s %d %8phC post gfpnid fcp_cnt %d\n", - __func__, __LINE__, fcport->port_name, + "%s %d %s post gfpnid fcp_cnt %d\n", + __func__, __LINE__, wwn_to_str(fcport->port_name), vha->fcport_count); qla24xx_post_gfpnid_work(vha, fcport); } else { ql_dbg(ql_dbg_disc, vha, 0x20d7, - "%s %d %8phC post gpsc fcp_cnt %d\n", - __func__, __LINE__, fcport->port_name, + "%s %d %s post gpsc fcp_cnt %d\n", + __func__, __LINE__, wwn_to_str(fcport->port_name), vha->fcport_count); qla24xx_post_gpsc_work(vha, fcport); } @@ -5584,8 +5584,8 @@ qla2x00_find_all_fabric_devs(scsi_qla_host_t *vha) new_fcport->fc4f_nvme = swl[swl_idx].fc4f_nvme; ql_log(ql_log_info, vha, 0x2131, - "FOUND: NVME port %8phC as FC Type 28h\n", - new_fcport->port_name); + "FOUND: NVME port %s as FC Type 28h\n", + wwn_to_str(new_fcport->port_name)); } if (swl[swl_idx].d_id.b.rsvd_1 != 0) { @@ -5688,9 +5688,9 @@ qla2x00_find_all_fabric_devs(scsi_qla_host_t *vha) */ if (qla_tgt_mode_enabled(base_vha)) { ql_dbg(ql_dbg_tgt_mgt, vha, 0xf080, - "port changed FC ID, %8phC" + "port changed FC ID, %s" " old %x:%x:%x (loop_id 0x%04x)-> new %x:%x:%x\n", - fcport->port_name, + wwn_to_str(fcport->port_name), fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa, @@ -5762,9 +5762,9 @@ qla2x00_find_all_fabric_devs(scsi_qla_host_t *vha) fcport->port_type != FCT_INITIATOR && fcport->port_type != FCT_BROADCAST) { ql_dbg(ql_dbg_disc, vha, 0x20f0, - "%s %d %8phC post del sess\n", + "%s %d %s post del sess\n", __func__, __LINE__, - fcport->port_name); + wwn_to_str(fcport->port_name)); qlt_schedule_sess_for_deletion(fcport); continue; } diff --git a/qla2x00t-32gbit/qla_inline.h b/qla2x00t-32gbit/qla_inline.h index 77dae3265..d383ac44d 100644 --- a/qla2x00t-32gbit/qla_inline.h +++ b/qla2x00t-32gbit/qla_inline.h @@ -149,6 +149,20 @@ qla2x00_clean_dsd_pool(struct qla_hw_data *ha, struct crc_context *ctx) INIT_LIST_HEAD(&ctx->dsd_list); } +/* + * Convert a WWN into a string, just like the %8phC format specification. + * Not thread-safe so use this function from debug code only. + */ +static inline const char *wwn_to_str(const u8 port_name[8]) +{ + static char wwn[24]; + + snprintf(wwn, sizeof(wwn), "%02x:%02x:%02x:%02x:%02x:%02x:%02x:%02x", + port_name[0], port_name[1], port_name[2], port_name[3], + port_name[4], port_name[5], port_name[6], port_name[7]); + return wwn; +} + static inline void qla2x00_set_fcport_state(fc_port_t *fcport, int state) { @@ -160,8 +174,8 @@ qla2x00_set_fcport_state(fc_port_t *fcport, int state) /* Don't print state transitions during initial allocation of fcport */ if (old_state && old_state != state) { ql_dbg(ql_dbg_disc, fcport->vha, 0x207d, - "FCPort %8phC state transitioned from %s to %s - " - "portid=%02x%02x%02x.\n", fcport->port_name, + "FCPort %s state transitioned from %s to %s - " + "portid=%02x%02x%02x.\n", wwn_to_str(fcport->port_name), port_state_str[old_state], port_state_str[state], fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa); diff --git a/qla2x00t-32gbit/qla_iocb.c b/qla2x00t-32gbit/qla_iocb.c index 0920cb1f9..a2c7d0f52 100644 --- a/qla2x00t-32gbit/qla_iocb.c +++ b/qla2x00t-32gbit/qla_iocb.c @@ -2778,8 +2778,8 @@ qla2x00_els_dcmd2_iocb_timeout(void *data) int res; ql_dbg(ql_dbg_io + ql_dbg_disc, vha, 0x3069, - "%s hdl=%x ELS Timeout, %8phC portid=%06x\n", - sp->name, sp->handle, fcport->port_name, fcport->d_id.b24); + "%s hdl=%x ELS Timeout, %s portid=%06x\n", + sp->name, sp->handle, wwn_to_str(fcport->port_name), fcport->d_id.b24); /* Abort the exchange */ spin_lock_irqsave(&ha->hardware_lock, flags); @@ -2803,8 +2803,8 @@ qla2x00_els_dcmd2_sp_done(void *ptr, int res) struct qla_work_evt *e; ql_dbg(ql_dbg_disc, vha, 0x3072, - "%s ELS done rc %d hdl=%x, portid=%06x %8phC\n", - sp->name, res, sp->handle, fcport->d_id.b24, fcport->port_name); + "%s ELS done rc %d hdl=%x, portid=%06x %s\n", + sp->name, res, sp->handle, fcport->d_id.b24, wwn_to_str(fcport->port_name)); fcport->flags &= ~(FCF_ASYNC_SENT|FCF_ASYNC_ACTIVE); del_timer(&sp->u.iocb_cmd.timer); diff --git a/qla2x00t-32gbit/qla_isr.c b/qla2x00t-32gbit/qla_isr.c index 2896dc198..392634163 100644 --- a/qla2x00t-32gbit/qla_isr.c +++ b/qla2x00t-32gbit/qla_isr.c @@ -1714,9 +1714,9 @@ qla24xx_logio_entry(scsi_qla_host_t *vha, struct req_que *req, QLA_LOGIO_LOGIN_RETRIED : 0; if (logio->entry_status) { ql_log(ql_log_warn, fcport->vha, 0x5034, - "Async-%s error entry - %8phC hdl=%x" + "Async-%s error entry - %s hdl=%x" "portid=%02x%02x%02x entry-status=%x.\n", - type, fcport->port_name, sp->handle, fcport->d_id.b.domain, + type, wwn_to_str(fcport->port_name), sp->handle, fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa, logio->entry_status); ql_dump_buffer(ql_dbg_async + ql_dbg_buffer, vha, 0x504d, @@ -1727,8 +1727,8 @@ qla24xx_logio_entry(scsi_qla_host_t *vha, struct req_que *req, if (le16_to_cpu(logio->comp_status) == CS_COMPLETE) { ql_dbg(ql_dbg_async, fcport->vha, 0x5036, - "Async-%s complete - %8phC hdl=%x portid=%02x%02x%02x " - "iop0=%x.\n", type, fcport->port_name, sp->handle, + "Async-%s complete - %s hdl=%x portid=%02x%02x%02x " + "iop0=%x.\n", type, wwn_to_str(fcport->port_name), sp->handle, fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa, le32_to_cpu(logio->io_parameter[0])); @@ -1810,8 +1810,8 @@ qla24xx_logio_entry(scsi_qla_host_t *vha, struct req_que *req, } ql_dbg(ql_dbg_async, fcport->vha, 0x5037, - "Async-%s failed - %8phC hdl=%x portid=%02x%02x%02x comp=%x " - "iop0=%x iop1=%x.\n", type, fcport->port_name, + "Async-%s failed - %s hdl=%x portid=%02x%02x%02x comp=%x " + "iop0=%x iop1=%x.\n", type, wwn_to_str(fcport->port_name), sp->handle, fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa, le16_to_cpu(logio->comp_status), diff --git a/qla2x00t-32gbit/qla_mbx.c b/qla2x00t-32gbit/qla_mbx.c index 5400696e1..e01f5f286 100644 --- a/qla2x00t-32gbit/qla_mbx.c +++ b/qla2x00t-32gbit/qla_mbx.c @@ -3849,13 +3849,11 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha, rptid_entry->vp_status, rptid_entry->port_id[2], rptid_entry->port_id[1], rptid_entry->port_id[0]); - ql_dbg(ql_dbg_async, vha, 0x5075, - "Format 1: Remote WWPN %8phC.\n", - rptid_entry->u.f1.port_name); + ql_dbg(ql_dbg_async, vha, 0x5075, "Format 1: Remote WWPN %s.\n", + wwn_to_str(rptid_entry->u.f1.port_name)); - ql_dbg(ql_dbg_async, vha, 0x5075, - "Format 1: WWPN %8phC.\n", - vha->port_name); + ql_dbg(ql_dbg_async, vha, 0x5075, "Format 1: WWPN %s.\n", + wwn_to_str(vha->port_name)); switch (rptid_entry->u.f1.flags & TOPO_MASK) { case TOPO_N2N: @@ -3894,8 +3892,8 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha, vha->d_id.b24, id.b24); } else { ql_dbg(ql_dbg_async, vha, 0x5075, - "Format 1: Remote login - Waiting for WWPN %8phC.\n", - rptid_entry->u.f1.port_name); + "Format 1: Remote login - Waiting for WWPN %s.\n", + wwn_to_str(rptid_entry->u.f1.port_name)); ha->flags.n2n_bigger = 0; } qla24xx_post_newsess_work(vha, &id, @@ -3983,9 +3981,8 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha, rptid_entry->port_id[2], rptid_entry->port_id[1], rptid_entry->port_id[0]); - ql_dbg(ql_dbg_async, vha, 0x5075, - "N2N: Remote WWPN %8phC.\n", - rptid_entry->u.f2.port_name); + ql_dbg(ql_dbg_async, vha, 0x5075, "N2N: Remote WWPN %s.\n", + wwn_to_str(rptid_entry->u.f2.port_name)); /* N2N. direct connect */ ha->current_topology = ISP_CFG_N; @@ -6258,15 +6255,15 @@ int qla24xx_gpdb_wait(struct scsi_qla_host *vha, fc_port_t *fcport, u8 opt) rval = qla24xx_send_mb_cmd(vha, &mc); if (rval != QLA_SUCCESS) { - ql_dbg(ql_dbg_mbx, vha, 0x1193, - "%s: %8phC fail\n", __func__, fcport->port_name); + ql_dbg(ql_dbg_mbx, vha, 0x1193, "%s: %s fail\n", __func__, + wwn_to_str(fcport->port_name)); goto done_free_sp; } rval = __qla24xx_parse_gpdb(vha, fcport, pd); - ql_dbg(ql_dbg_mbx, vha, 0x1197, "%s: %8phC done\n", - __func__, fcport->port_name); + ql_dbg(ql_dbg_mbx, vha, 0x1197, "%s: %s done\n", + __func__, wwn_to_str(fcport->port_name)); done_free_sp: if (pd) diff --git a/qla2x00t-32gbit/qla_os.c b/qla2x00t-32gbit/qla_os.c index 08d72d2c3..27a47f5d6 100644 --- a/qla2x00t-32gbit/qla_os.c +++ b/qla2x00t-32gbit/qla_os.c @@ -5074,8 +5074,8 @@ void qla24xx_create_new_sess(struct scsi_qla_host *vha, struct qla_work_evt *e) uint8_t free_fcport = 0; ql_dbg(ql_dbg_disc, vha, 0xffff, - "%s %d %8phC enter\n", - __func__, __LINE__, e->u.new_sess.port_name); + "%s %d %s enter\n", + __func__, __LINE__, wwn_to_str(e->u.new_sess.port_name)); spin_lock_irqsave(&vha->hw->tgt.sess_lock, flags); fcport = qla2x00_find_fcport_by_wwpn(vha, e->u.new_sess.port_name, 1); @@ -5111,8 +5111,8 @@ void qla24xx_create_new_sess(struct scsi_qla_host *vha, struct qla_work_evt *e) WWN_SIZE); } else { ql_dbg(ql_dbg_disc, vha, 0xffff, - "%s %8phC mem alloc fail.\n", - __func__, e->u.new_sess.port_name); + "%s %s mem alloc fail.\n", + __func__, wwn_to_str(e->u.new_sess.port_name)); if (pla) kmem_cache_free(qla_tgt_plogi_cachep, pla); @@ -5126,9 +5126,9 @@ void qla24xx_create_new_sess(struct scsi_qla_host *vha, struct qla_work_evt *e) if (tfcp) { /* should rarily happen */ ql_dbg(ql_dbg_disc, vha, 0xffff, - "%s %8phC found existing fcport b4 add. DS %d LS %d\n", - __func__, tfcp->port_name, tfcp->disc_state, - tfcp->fw_login_state); + "%s %s found existing fcport b4 add. DS %d LS %d\n", + __func__, wwn_to_str(tfcp->port_name), + tfcp->disc_state, tfcp->fw_login_state); free_fcport = 1; } else { @@ -5182,8 +5182,8 @@ void qla24xx_create_new_sess(struct scsi_qla_host *vha, struct qla_work_evt *e) * We have a conflict fcport with same NportID. */ ql_dbg(ql_dbg_disc, vha, 0xffff, - "%s %8phC found conflict b4 add. DS %d LS %d\n", - __func__, tfcp->port_name, tfcp->disc_state, + "%s %s found conflict b4 add. DS %d LS %d\n", + __func__, wwn_to_str(tfcp->port_name), tfcp->disc_state, tfcp->fw_login_state); switch (tfcp->disc_state) { diff --git a/qla2x00t-32gbit/qla_target.c b/qla2x00t-32gbit/qla_target.c index cd703947c..f0d00c864 100644 --- a/qla2x00t-32gbit/qla_target.c +++ b/qla2x00t-32gbit/qla_target.c @@ -587,9 +587,8 @@ void qla2x00_async_nack_sp_done(void *s, int res) struct scsi_qla_host *vha = sp->vha; unsigned long flags; - ql_dbg(ql_dbg_disc, vha, 0x20f2, - "Async done-%s res %x %8phC type %d\n", - sp->name, res, sp->fcport->port_name, sp->type); + ql_dbg(ql_dbg_disc, vha, 0x20f2, "Async done-%s res %x %s type %d\n", + sp->name, res, wwn_to_str(sp->fcport->port_name), sp->type); spin_lock_irqsave(&vha->hw->tgt.sess_lock, flags); sp->fcport->flags &= ~FCF_ASYNC_SENT; @@ -674,8 +673,8 @@ int qla24xx_async_notify_ack(scsi_qla_host_t *vha, fc_port_t *fcport, sp->done = qla2x00_async_nack_sp_done; ql_dbg(ql_dbg_disc, vha, 0x20f4, - "Async-%s %8phC hndl %x %s\n", - sp->name, fcport->port_name, sp->handle, c); + "Async-%s %s hndl %x %s\n", + sp->name, wwn_to_str(fcport->port_name), sp->handle, c); rval = qla2x00_start_sp(sp); if (rval != QLA_SUCCESS) @@ -774,16 +773,16 @@ void qlt_fc_port_added(struct scsi_qla_host *vha, fc_port_t *fcport) if (!kref_get_unless_zero(&sess->sess_kref)) { ql_dbg(ql_dbg_disc, vha, 0x2107, - "%s: kref_get fail sess %8phC \n", - __func__, sess->port_name); + "%s: kref_get fail sess %s \n", + __func__, wwn_to_str(sess->port_name)); spin_unlock_irqrestore(&ha->tgt.sess_lock, flags); return; } ql_dbg(ql_dbg_tgt_mgt, vha, 0xf04c, - "qla_target(%u): %ssession for port %8phC " + "qla_target(%u): %ssession for port %s " "(loop ID %d) reappeared\n", vha->vp_idx, - sess->local ? "local " : "", sess->port_name, sess->loop_id); + sess->local ? "local " : "", wwn_to_str(sess->port_name), sess->loop_id); ql_dbg(ql_dbg_tgt_mgt, vha, 0xf007, "Reappeared sess %p\n", sess); @@ -795,9 +794,8 @@ void qlt_fc_port_added(struct scsi_qla_host *vha, fc_port_t *fcport) if (sess && sess->local) { ql_dbg(ql_dbg_tgt_mgt, vha, 0xf04d, - "qla_target(%u): local session for " - "port %8phC (loop ID %d) became global\n", vha->vp_idx, - fcport->port_name, sess->loop_id); + "qla_target(%u): local session for port %s (loop ID %d) became global\n", + vha->vp_idx, wwn_to_str(fcport->port_name), sess->loop_id); sess->local = 0; } ha->tgt.tgt_ops->put_sess(sess); @@ -818,9 +816,9 @@ qlt_plogi_ack_find_add(struct scsi_qla_host *vha, port_id_t *id, list_for_each_entry(pla, &vha->plogi_ack_list, list) { if (pla->id.b24 == id->b24) { ql_dbg(ql_dbg_disc + ql_dbg_verbose, vha, 0x210d, - "%s %d %8phC Term INOT due to new INOT", + "%s %d %s Term INOT due to new INOT", __func__, __LINE__, - pla->iocb.u.isp24.port_name); + wwn_to_str(pla->iocb.u.isp24.port_name)); qlt_send_term_imm_notif(vha, &pla->iocb, 1); memcpy(&pla->iocb, iocb, sizeof(pla->iocb)); return pla; @@ -857,8 +855,8 @@ void qlt_plogi_ack_unref(struct scsi_qla_host *vha, return; ql_dbg(ql_dbg_disc, vha, 0x5089, - "Sending PLOGI ACK to wwn %8phC s_id %02x:%02x:%02x loop_id %#04x" - " exch %#x ox_id %#x\n", iocb->u.isp24.port_name, + "Sending PLOGI ACK to wwn %s s_id %02x:%02x:%02x loop_id %#04x" + " exch %#x ox_id %#x\n", wwn_to_str(iocb->u.isp24.port_name), iocb->u.isp24.port_id[2], iocb->u.isp24.port_id[1], iocb->u.isp24.port_id[0], le16_to_cpu(iocb->u.isp24.nport_handle), @@ -898,10 +896,10 @@ qlt_plogi_ack_link(struct scsi_qla_host *vha, struct qlt_plogi_ack_t *pla, pla->ref_count++; ql_dbg(ql_dbg_tgt_mgt, vha, 0xf097, - "Linking sess %p [%d] wwn %8phC with PLOGI ACK to wwn %8phC" + "Linking sess %p [%d] wwn %s with PLOGI ACK to wwn %s" " s_id %02x:%02x:%02x, ref=%d pla %p link %d\n", - sess, link, sess->port_name, - iocb->u.isp24.port_name, iocb->u.isp24.port_id[2], + sess, link, wwn_to_str(sess->port_name), + wwn_to_str(iocb->u.isp24.port_name), iocb->u.isp24.port_id[2], iocb->u.isp24.port_id[1], iocb->u.isp24.port_id[0], pla->ref_count, pla, link); @@ -985,9 +983,10 @@ void qlt_free_session_done(struct work_struct *work) sess->plogi_link[QLT_PLOGI_LINK_SAME_WWN]; ql_dbg(ql_dbg_tgt_mgt, vha, 0xf084, - "%s: se_sess %p / sess %p from port %8phC loop_id %#04x" + "%s: se_sess %p / sess %p from port %s loop_id %#04x" " s_id %02x:%02x:%02x logout %d keep %d els_logo %d\n", - __func__, sess->se_sess, sess, sess->port_name, sess->loop_id, + __func__, sess->se_sess, sess, wwn_to_str(sess->port_name), + sess->loop_id, sess->d_id.b.domain, sess->d_id.b.area, sess->d_id.b.al_pa, sess->logout_on_delete, sess->keep_nport_handle, sess->send_els_logo); @@ -1094,18 +1093,20 @@ void qlt_free_session_done(struct work_struct *work) if (con) { iocb = &con->iocb; ql_dbg(ql_dbg_tgt_mgt, vha, 0xf099, - "se_sess %p / sess %p port %8phC is gone," - " %s (ref=%d), releasing PLOGI for %8phC (ref=%d)\n", - sess->se_sess, sess, sess->port_name, + "se_sess %p / sess %p port %s is gone," + " %s (ref=%d), releasing PLOGI for %s (ref=%d)\n", + sess->se_sess, sess, + wwn_to_str(sess->port_name), own ? "releasing own PLOGI" : "no own PLOGI pending", own ? own->ref_count : -1, - iocb->u.isp24.port_name, con->ref_count); + wwn_to_str(iocb->u.isp24.port_name), + con->ref_count); qlt_plogi_ack_unref(vha, con); sess->plogi_link[QLT_PLOGI_LINK_CONFLICT] = NULL; } else { ql_dbg(ql_dbg_tgt_mgt, vha, 0xf09a, - "se_sess %p / sess %p port %8phC is gone, %s (ref=%d)\n", - sess->se_sess, sess, sess->port_name, + "se_sess %p / sess %p port %s is gone, %s (ref=%d)\n", + sess->se_sess, sess, wwn_to_str(sess->port_name), own ? "releasing own PLOGI" : "no own PLOGI pending", own ? own->ref_count : -1); @@ -1121,8 +1122,8 @@ void qlt_free_session_done(struct work_struct *work) spin_unlock_irqrestore(&ha->tgt.sess_lock, flags); ql_dbg(ql_dbg_tgt_mgt, vha, 0xf001, - "Unregistration of sess %p %8phC finished fcp_cnt %d\n", - sess, sess->port_name, vha->fcport_count); + "Unregistration of sess %p %s finished fcp_cnt %d\n", + sess, wwn_to_str(sess->port_name), vha->fcport_count); if (tgt && (tgt->sess_count == 0)) wake_up_all(&tgt->waitQ); @@ -1159,8 +1160,8 @@ void qlt_unreg_sess(struct fc_port *sess) unsigned long flags; ql_dbg(ql_dbg_disc, sess->vha, 0x210a, - "%s sess %p for deletion %8phC\n", - __func__, sess, sess->port_name); + "%s sess %p for deletion %s\n", + __func__, sess, wwn_to_str(sess->port_name)); spin_lock_irqsave(&sess->vha->work_lock, flags); if (sess->free_pending) { @@ -1221,8 +1222,8 @@ static int qlt_reset(struct scsi_qla_host *vha, void *iocb, int mcmd) } ql_dbg(ql_dbg_tgt, vha, 0xe047, - "scsi(%ld): resetting (session %p from port %8phC mcmd %x, " - "loop_id %d)\n", vha->host_no, sess, sess->port_name, + "scsi(%ld): resetting (session %p from port %s mcmd %x, " + "loop_id %d)\n", vha->host_no, sess, wwn_to_str(sess->port_name), mcmd, loop_id); return qlt_issue_task_mgmt(sess, 0, mcmd, iocb, QLA24XX_MGMT_SEND_NACK); @@ -1268,8 +1269,8 @@ void qlt_schedule_sess_for_deletion(struct fc_port *sess) if (sess->sec_since_registration < sec && sec && !(sec % 5)) { sess->sec_since_registration = sec; ql_dbg(ql_dbg_disc, sess->vha, 0xffff, - "%s %8phC : Slow Rport registration(%d Sec)\n", - __func__, sess->port_name, sec); + "%s %s : Slow Rport registration(%d Sec)\n", + __func__, wwn_to_str(sess->port_name), sec); } return; default: @@ -1289,8 +1290,8 @@ void qlt_schedule_sess_for_deletion(struct fc_port *sess) qla24xx_chk_fcp_state(sess); ql_dbg(ql_dbg_tgt, sess->vha, 0xe001, - "Scheduling sess %p for deletion %8phC\n", - sess, sess->port_name); + "Scheduling sess %p for deletion %s\n", + sess, wwn_to_str(sess->port_name)); INIT_WORK(&sess->del_work, qla24xx_delete_sess_fn); WARN_ON(!queue_work(sess->vha->hw->wq, &sess->del_work)); @@ -1377,8 +1378,8 @@ static struct fc_port *qlt_create_sess( if (fcport->se_sess) { if (!kref_get_unless_zero(&sess->sess_kref)) { ql_dbg(ql_dbg_disc, vha, 0x20f6, - "%s: kref_get_unless_zero failed for %8phC\n", - __func__, sess->port_name); + "%s: kref_get_unless_zero failed for %s\n", + __func__, wwn_to_str(sess->port_name)); return NULL; } return fcport; @@ -1399,8 +1400,8 @@ static struct fc_port *qlt_create_sess( if (ha->tgt.tgt_ops->check_initiator_node_acl(vha, &fcport->port_name[0], sess) < 0) { ql_dbg(ql_dbg_tgt_mgt, vha, 0xf015, - "(%d) %8phC check_initiator_node_acl failed\n", - vha->vp_idx, fcport->port_name); + "(%d) %s check_initiator_node_acl failed\n", + vha->vp_idx, wwn_to_str(fcport->port_name)); return NULL; } else { kref_init(&fcport->sess_kref); @@ -1410,8 +1411,8 @@ static struct fc_port *qlt_create_sess( */ if (!kref_get_unless_zero(&sess->sess_kref)) { ql_dbg(ql_dbg_disc, vha, 0x20f7, - "%s: kref_get_unless_zero failed for %8phC\n", - __func__, sess->port_name); + "%s: kref_get_unless_zero failed for %s\n", + __func__, wwn_to_str(sess->port_name)); return NULL; } @@ -1429,9 +1430,9 @@ static struct fc_port *qlt_create_sess( vha->vha_tgt.qla_tgt->sess_count); ql_dbg(ql_dbg_tgt_mgt, vha, 0xf04b, - "qla_target(%d): %ssession for wwn %8phC (loop_id %d, " + "qla_target(%d): %ssession for wwn %s (loop_id %d, " "s_id %x:%x:%x, confirmed completion %ssupported) added\n", - vha->vp_idx, local ? "local " : "", fcport->port_name, + vha->vp_idx, local ? "local " : "", wwn_to_str(fcport->port_name), fcport->loop_id, sess->d_id.b.domain, sess->d_id.b.area, sess->d_id.b.al_pa, sess->conf_compl_supported ? "" : "not "); @@ -1469,8 +1470,8 @@ qlt_fc_port_deleted(struct scsi_qla_host *vha, fc_port_t *fcport, int max_gen) spin_unlock_irqrestore(&vha->hw->tgt.sess_lock, flags); ql_dbg(ql_dbg_tgt_mgt, vha, 0xf092, "Ignoring stale deletion request for se_sess %p / sess %p" - " for port %8phC, req_gen %d, sess_gen %d\n", - sess->se_sess, sess, sess->port_name, max_gen, + " for port %s, req_gen %d, sess_gen %d\n", + sess->se_sess, sess, wwn_to_str(sess->port_name), max_gen, sess->generation); return; } @@ -2408,8 +2409,8 @@ void qlt_xmit_tm_rsp(struct qla_tgt_mgmt_cmd *mcmd) case ELS_PRLO: case ELS_TPRLO: ql_dbg(ql_dbg_disc, vha, 0x2106, - "TM response logo %phC status %#x state %#x", - mcmd->sess->port_name, mcmd->fc_tm_rsp, + "TM response logo %s status %#x state %#x", + wwn_to_str(mcmd->sess->port_name), mcmd->fc_tm_rsp, mcmd->flags); qlt_schedule_sess_for_deletion(mcmd->sess); break; @@ -4131,8 +4132,9 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, */ cmd->sess->send_els_logo = 1; ql_dbg(ql_dbg_disc, vha, 0x20f8, - "%s %d %8phC post del sess\n", - __func__, __LINE__, cmd->sess->port_name); + "%s %d %s post del sess\n", + __func__, __LINE__, + wwn_to_str(cmd->sess->port_name)); qlt_schedule_sess_for_deletion(cmd->sess); } @@ -4506,8 +4508,8 @@ static int qlt_handle_cmd_for_atio(struct scsi_qla_host *vha, */ if (!kref_get_unless_zero(&sess->sess_kref)) { ql_dbg(ql_dbg_tgt_mgt, vha, 0xf004, - "%s: kref_get fail, %8phC oxid %x \n", - __func__, sess->port_name, + "%s: kref_get fail, %s oxid %x \n", + __func__, wwn_to_str(sess->port_name), be16_to_cpu(atio->u.isp24.fcp_hdr.ox_id)); return -EFAULT; } @@ -4722,12 +4724,12 @@ void qlt_logo_completion_handler(fc_port_t *fcport, int rc) if (rc != MBS_COMMAND_COMPLETE) { ql_dbg(ql_dbg_tgt_mgt, fcport->vha, 0xf093, "%s: se_sess %p / sess %p from" - " port %8phC loop_id %#04x s_id %02x:%02x:%02x" + " port %s loop_id %#04x s_id %02x:%02x:%02x" " LOGO failed: %#x\n", __func__, fcport->se_sess, fcport, - fcport->port_name, fcport->loop_id, + wwn_to_str(fcport->port_name), fcport->loop_id, fcport->d_id.b.domain, fcport->d_id.b.area, fcport->d_id.b.al_pa, rc); } @@ -4895,9 +4897,9 @@ static int qlt_handle_login(struct scsi_qla_host *vha, pla = qlt_plogi_ack_find_add(vha, &port_id, iocb); if (!pla) { ql_dbg(ql_dbg_disc + ql_dbg_verbose, vha, 0xffff, - "%s %d %8phC Term INOT due to mem alloc fail", + "%s %d %s Term INOT due to mem alloc fail", __func__, __LINE__, - iocb->u.isp24.port_name); + wwn_to_str(iocb->u.isp24.port_name)); qlt_send_term_imm_notif(vha, iocb, 1); goto out; } @@ -4911,8 +4913,8 @@ static int qlt_handle_login(struct scsi_qla_host *vha, if (!sess) { pla->ref_count++; ql_dbg(ql_dbg_disc, vha, 0xffff, - "%s %d %8phC post new sess\n", - __func__, __LINE__, iocb->u.isp24.port_name); + "%s %d %s post new sess\n", + __func__, __LINE__, wwn_to_str(iocb->u.isp24.port_name)); if (iocb->u.isp24.status_subcode == ELS_PLOGI) qla24xx_post_newsess_work(vha, &port_id, iocb->u.isp24.port_name, @@ -4941,8 +4943,8 @@ static int qlt_handle_login(struct scsi_qla_host *vha, !(sec % 5)) { sess->sec_since_registration = sec; ql_dbg(ql_dbg_disc, vha, 0xffff, - "%s %8phC - Slow Rport registration (%d Sec)\n", - __func__, sess->port_name, sec); + "%s %s - Slow Rport registration (%d Sec)\n", + __func__, wwn_to_str(sess->port_name), sec); } if (!conflict_sess) @@ -4977,8 +4979,8 @@ static int qlt_handle_login(struct scsi_qla_host *vha, ql_dbg(ql_dbg_disc, vha, 0x20f9, - "%s %d %8phC DS %d\n", - __func__, __LINE__, sess->port_name, sess->disc_state); + "%s %d %s DS %d\n", + __func__, __LINE__, wwn_to_str(sess->port_name), sess->disc_state); switch (sess->disc_state) { case DSC_DELETED: @@ -5007,9 +5009,8 @@ static int qlt_handle_login(struct scsi_qla_host *vha, sess->keep_nport_handle = ((sess->loop_id == loop_id) && (sess->d_id.b24 == port_id.b24)); - ql_dbg(ql_dbg_disc, vha, 0x20f9, - "%s %d %8phC post del sess\n", - __func__, __LINE__, sess->port_name); + ql_dbg(ql_dbg_disc, vha, 0x20f9, "%s %d %s post del sess\n", + __func__, __LINE__, wwn_to_str(sess->port_name)); qlt_schedule_sess_for_deletion(sess); @@ -5045,11 +5046,11 @@ static int qlt_24xx_handle_els(struct scsi_qla_host *vha, loop_id = le16_to_cpu(iocb->u.isp24.nport_handle); ql_dbg(ql_dbg_disc, vha, 0xf026, - "qla_target(%d): Port ID: %02x:%02x:%02x ELS opcode: 0x%02x lid %d %8phC\n", - vha->vp_idx, iocb->u.isp24.port_id[2], - iocb->u.isp24.port_id[1], iocb->u.isp24.port_id[0], - iocb->u.isp24.status_subcode, loop_id, - iocb->u.isp24.port_name); + "qla_target(%d): Port ID: %02x:%02x:%02x ELS opcode: 0x%02x lid %d %s\n", + vha->vp_idx, iocb->u.isp24.port_id[2], + iocb->u.isp24.port_id[1], iocb->u.isp24.port_id[0], + iocb->u.isp24.status_subcode, loop_id, + wwn_to_str(iocb->u.isp24.port_name)); /* res = 1 means ack at the end of thread * res = 0 means ack async/later. @@ -5066,9 +5067,9 @@ static int qlt_24xx_handle_els(struct scsi_qla_host *vha, if (sess && sess->plogi_link[QLT_PLOGI_LINK_SAME_WWN]) { ql_dbg(ql_dbg_disc, vha, 0xffff, - "%s %d %8phC Term PRLI due to PLOGI ACK not completed\n", + "%s %d %s Term PRLI due to PLOGI ACK not completed\n", __func__, __LINE__, - iocb->u.isp24.port_name); + wwn_to_str(iocb->u.isp24.port_name)); qlt_send_term_imm_notif(vha, iocb, 1); break; } @@ -5098,8 +5099,9 @@ static int qlt_24xx_handle_els(struct scsi_qla_host *vha, break; default: ql_dbg(ql_dbg_tgt_mgt, vha, 0xf09b, - "PRLI with conflicting sess %p port %8phC\n", - conflict_sess, conflict_sess->port_name); + "PRLI with conflicting sess %p port %s\n", + conflict_sess, + wwn_to_str(conflict_sess->port_name)); conflict_sess->fw_login_state = DSC_LS_PORT_UNAVAIL; qlt_send_term_imm_notif(vha, iocb, 1); @@ -5133,8 +5135,8 @@ static int qlt_24xx_handle_els(struct scsi_qla_host *vha, !(sec % 5)) { sess->sec_since_registration = sec; ql_dbg(ql_dbg_disc, sess->vha, 0xffff, - "%s %8phC : Slow Rport registration(%d Sec)\n", - __func__, sess->port_name, sec); + "%s %s : Slow Rport registration(%d Sec)\n", + __func__, wwn_to_str(sess->port_name), sec); } qlt_send_term_imm_notif(vha, iocb, 1); return 0; @@ -5194,8 +5196,8 @@ static int qlt_24xx_handle_els(struct scsi_qla_host *vha, if (ha->current_topology != ISP_CFG_F) { if (sess) { ql_dbg(ql_dbg_disc, vha, 0x20fa, - "%s %d %8phC post nack\n", - __func__, __LINE__, sess->port_name); + "%s %d %s post nack\n", + __func__, __LINE__, wwn_to_str(sess->port_name)); qla24xx_post_nack_work(vha, sess, iocb, SRB_NACK_PRLI); res = 0; @@ -5207,8 +5209,8 @@ static int qlt_24xx_handle_els(struct scsi_qla_host *vha, } else { if (sess) { ql_dbg(ql_dbg_disc, vha, 0x20fb, - "%s %d %8phC post nack\n", - __func__, __LINE__, sess->port_name); + "%s %d %s post nack\n", + __func__, __LINE__, wwn_to_str(sess->port_name)); qla24xx_post_nack_work(vha, sess, iocb, SRB_NACK_PRLI); res = 0; @@ -6235,8 +6237,8 @@ static fc_port_t *qlt_get_port_database(struct scsi_qla_host *vha, qla24xx_sched_upd_fcport(fcport); } else { ql_dbg(ql_dbg_disc, vha, 0x20ff, - "%s %d %8phC post gpsc fcp_cnt %d\n", - __func__, __LINE__, fcport->port_name, vha->fcport_count); + "%s %d %s post gpsc fcp_cnt %d\n", + __func__, __LINE__, wwn_to_str(fcport->port_name), vha->fcport_count); qla24xx_post_gpsc_work(vha, fcport); } } @@ -6361,8 +6363,8 @@ static void qlt_abort_work(struct qla_tgt *tgt, if (!kref_get_unless_zero(&sess->sess_kref)) { ql_dbg(ql_dbg_tgt_tmr, vha, 0xf01c, - "%s: kref_get fail %8phC \n", - __func__, sess->port_name); + "%s: kref_get fail %s \n", + __func__, wwn_to_str(sess->port_name)); sess = NULL; goto out_term2; } @@ -6425,8 +6427,8 @@ static void qlt_tmr_work(struct qla_tgt *tgt, if (!kref_get_unless_zero(&sess->sess_kref)) { ql_dbg(ql_dbg_tgt_tmr, vha, 0xf020, - "%s: kref_get fail %8phC\n", - __func__, sess->port_name); + "%s: kref_get fail %s\n", + __func__, wwn_to_str(sess->port_name)); goto out_term2; } }