From 0f817a40ef0557af7a9fa02e76fd730131cf1b40 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Tue, 7 Sep 2021 15:51:56 +0000 Subject: [PATCH 1/2] fcst: Remove one occurrence of __attribute__((packed)) Remove this occurrence because it is not necessary and because checkpatch complains about it. git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9573 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- fcst/ft_sess.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fcst/ft_sess.c b/fcst/ft_sess.c index 1c5142c96..99762bc3b 100644 --- a/fcst/ft_sess.c +++ b/fcst/ft_sess.c @@ -348,7 +348,9 @@ int ft_get_transport_id(struct scst_tgt *tgt, struct scst_session *scst_sess, u8 __resv1[7]; __be64 port_name; /* N_Port Name */ u8 __resv2[8]; - } __attribute__((__packed__)) *id; + } *id; + + static_assert(sizeof(*id) == 24); if (!scst_sess) return SCSI_TRANSPORTID_PROTOCOLID_FCP2; From 573e4f21f3d3179407fa01b04c03211d4da4781f Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Wed, 8 Sep 2021 02:47:22 +0000 Subject: [PATCH 2/2] isert-scst: Enclose complex values in parentheses git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9574 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- iscsi-scst/kernel/isert-scst/iser.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/iscsi-scst/kernel/isert-scst/iser.h b/iscsi-scst/kernel/isert-scst/iser.h index 9dbadf816..c543c8b38 100644 --- a/iscsi-scst/kernel/isert-scst/iser.h +++ b/iscsi-scst/kernel/isert-scst/iser.h @@ -269,8 +269,8 @@ struct isert_global { struct workqueue_struct *conn_wq; }; -#define _ptr_to_u64(p) (u64)(unsigned long)(p) -#define _u64_to_ptr(v) (void *)(unsigned long)(v) +#define _ptr_to_u64(p) ((u64)(unsigned long)(p)) +#define _u64_to_ptr(v) ((void *)(unsigned long)(v)) /* global iser scope */ int isert_global_init(void);