From d47959241365b87dd41ac9201adc5e5dd6defada Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Tue, 5 May 2015 14:53:12 +0200 Subject: [PATCH] iscsiadm: Fix strerror() argument Detected by Coverity. Signed-off-by: Bart Van Assche --- iscsi-scst/usr/iscsi_adm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/iscsi-scst/usr/iscsi_adm.c b/iscsi-scst/usr/iscsi_adm.c index c29aa5f79..1f53ceb5f 100644 --- a/iscsi-scst/usr/iscsi_adm.c +++ b/iscsi-scst/usr/iscsi_adm.c @@ -147,7 +147,7 @@ static int iscsid_request_send(int fd, struct iscsi_adm_req *req) if (ret != sizeof(*req)) { err = (ret < 0) ? -errno : -EIO; fprintf(stderr, "%s failed: written %d, to write %d, " - "error: %s\n", __func__, ret, err, strerror(err)); + "error: %s\n", __func__, ret, err, strerror(-err)); } else err = 0; @@ -173,7 +173,7 @@ static int iscsid_response_recv(int fd, struct iscsi_adm_req *req, void *rsp_dat if (ret != sizeof(rsp) + sizeof(*req)) { err = (ret < 0) ? -errno : -EIO; fprintf(stderr, "readv failed: read %d instead of %d (%s)\n", - ret, (int)(sizeof(rsp) + sizeof(*req)), strerror(err)); + ret, (int)(sizeof(rsp) + sizeof(*req)), strerror(-err)); } else err = rsp.err; @@ -182,7 +182,7 @@ static int iscsid_response_recv(int fd, struct iscsi_adm_req *req, void *rsp_dat if (ret != rsp_data_sz) { err = (ret < 0) ? -errno : -EIO; fprintf(stderr, "read failed: read %d instead of %d (%s)\n", - ret, (int)rsp_data_sz, strerror(err)); + ret, (int)rsp_data_sz, strerror(-err)); } }