From d70b1e39c0b859f66a5bd06db95c44a5a4e4c546 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Wed, 17 Jun 2015 00:20:21 +0000 Subject: [PATCH] iscsi-scstd: Fix a dereference-before-null-check Detected by Coverity. git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6366 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- iscsi-scst/usr/session.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/iscsi-scst/usr/session.c b/iscsi-scst/usr/session.c index fe25b1c05..9886cfe42 100644 --- a/iscsi-scst/usr/session.c +++ b/iscsi-scst/usr/session.c @@ -172,11 +172,11 @@ void session_free(struct session *session) { log_debug(1, "Freeing session sid %#"PRIx64, session->sid.id64); - kernel_session_destroy(session->target->tid, session->sid.id64); - if (session->target) { struct target *target = session->target; + kernel_session_destroy(target->tid, session->sid.id64); + target->sessions_count--; log_debug(1, "target %s, sessions_count %d", target->name, target->sessions_count);