From dbc253a3143bc16fd76ab692ae5d9e18885237a3 Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Thu, 2 May 2019 03:22:24 +0000 Subject: [PATCH] qla2xxx-32gbit: Remove qla_tgt_cmd.data_work and qla_tgt_cmd.data_work_free The 'data_work' and 'data_work_free' member variables are set but never used. Hence remove both member variables. See also commit 6bcbb3174caa ("qla2xxx: Fix incorrect tcm_qla2xxx_free_cmd use during TMR ABORT (v2)"). git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8319 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- qla2x00t-32gbit/qla2x00-target/scst_qla2xxx.c | 4 ---- qla2x00t-32gbit/qla_target.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/qla2x00t-32gbit/qla2x00-target/scst_qla2xxx.c b/qla2x00t-32gbit/qla2x00-target/scst_qla2xxx.c index 5bb75e321..a0f1e1771 100644 --- a/qla2x00t-32gbit/qla2x00-target/scst_qla2xxx.c +++ b/qla2x00t-32gbit/qla2x00-target/scst_qla2xxx.c @@ -507,9 +507,7 @@ static void sqa_qla2xxx_handle_data(struct qla_tgt_cmd *cmd) TRACE_ENTRY(); spin_lock_irqsave(&cmd->cmd_lock, flags); - cmd->data_work =1; if (cmd->aborted) { - cmd->data_work_free = 1; spin_unlock_irqrestore(&cmd->cmd_lock, flags); scst_set_cmd_error(scst_cmd, @@ -1477,8 +1475,6 @@ static int sqa_target_release(struct scst_tgt *scst_tgt) return 0; } -#define DATA_WORK_NOT_FREE(_cmd) (_cmd->data_work && !_cmd->data_work_free) - static int sqa_xmit_response(struct scst_cmd *scst_cmd) { int xmit_type = QLA_TGT_XMIT_DATA, res, residual=0; diff --git a/qla2x00t-32gbit/qla_target.h b/qla2x00t-32gbit/qla_target.h index 18813c8f4..cee4e9cb5 100644 --- a/qla2x00t-32gbit/qla_target.h +++ b/qla2x00t-32gbit/qla_target.h @@ -930,8 +930,6 @@ struct qla_tgt_cmd { unsigned int cmd_sent_to_fw:1; unsigned int cmd_in_wq:1; unsigned int aborted:1; - unsigned int data_work:1; - unsigned int data_work_free:1; unsigned int released:1; struct scatterlist *sg; /* cmd data buffer SG vector */