From dd4907ea62225d9487b7252167fa695dccb043b5 Mon Sep 17 00:00:00 2001 From: Vladislav Bolkhovitin Date: Fri, 9 Nov 2012 02:11:59 +0000 Subject: [PATCH] scst_pres: Introduce kmemdup() The scst_pr_add_registrant() implementation can be made a little more brief by using kmemdup() instead of kmalloc() + memcpy(). Signed-off-by: Bart Van Assche git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4610 d57e44dd-8a1f-0410-8b47-8ef2f437770f --- scst/src/scst_pres.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scst/src/scst_pres.c b/scst/src/scst_pres.c index 503e2a4d9..557368b99 100644 --- a/scst/src/scst_pres.c +++ b/scst/src/scst_pres.c @@ -406,13 +406,13 @@ static struct scst_dev_registrant *scst_pr_add_registrant( goto out; } - reg->transport_id = kmalloc(tid_size(transport_id), gfp_flags); + reg->transport_id = kmemdup(transport_id, tid_size(transport_id), + gfp_flags); if (reg->transport_id == NULL) { PRINT_ERROR("%s", "Unable to allocate initiator port " "transport id"); goto out_free; } - memcpy(reg->transport_id, transport_id, tid_size(transport_id)); reg->rel_tgt_id = rel_tgt_id; reg->key = key;