From dff213dc8ef01e56553dc45eb13acc9d558837bd Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Wed, 29 Apr 2015 15:43:02 +0200 Subject: [PATCH] scst_debug(): Avoid that debug_print_with_prefix() overflows the output buffer Detected by Coverity. Signed-off-by: Bart Van Assche --- scst/src/scst_debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scst/src/scst_debug.c b/scst/src/scst_debug.c index 40b8f54dd..88acf74e9 100644 --- a/scst/src/scst_debug.c +++ b/scst/src/scst_debug.c @@ -75,11 +75,11 @@ int debug_print_with_prefix(unsigned long trace_flag, const char *severity, spin_lock_irqsave(&trace_buf_lock, flags); - strcpy(trace_buf, severity); + strlcpy(trace_buf, severity, TRACE_BUF_SIZE); i = strlen(trace_buf); if (trace_flag & TRACE_PID) - i += snprintf(&trace_buf[i], TRACE_BUF_SIZE, "[%d]: ", pid); + i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, "[%d]: ", pid); if (prefix != NULL) i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, "%s: ", prefix);