mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-08-17 20:56:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

scstadmin: Eliminate use of uninitialized value in numeric error

Browse Source 
Using scstadmin to reload a configuration with fewer targets can result
in a "Use of uninitialized value in numeric ne" error.  Rectify by adding
a check for the undefined value and handling the situation (by disabling
the target in question, unless the driver is copy_manager).
This commit is contained in:
Brian Meagher
2024-01-30 10:55:25 +03:00
committed by Gleb Chesnokov
parent 2f9a82bb87
commit f4f8da8b4d
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scstadmin/scstadmin.sysfs/scstadmin
+11 -4
View File
@@ -2831,10 +2831,17 @@ sub applyConfigEnableTargets {
my $t_attributes; my $t_attributes;
($t_attributes, $errorString) = $SCST->targetAttributes($driver, $target); ($t_attributes, $errorString) = $SCST->targetAttributes($driver, $target);
if (defined($$t_attributes{'enabled'}) && if (defined($$attributes{'enabled'})) {
($$t_attributes{'enabled'}->{'value'} != $$attributes{'enabled'})) { if (defined($$t_attributes{'enabled'}) &&
setTargetAttribute($driver, $target, 'enabled', $$attributes{'enabled'}); ($$t_attributes{'enabled'}->{'value'} != $$attributes{'enabled'})) {
$changes++; setTargetAttribute($driver, $target, 'enabled', $$attributes{'enabled'});
$changes++;
}
} else {
if ($driver ne 'copy_manager') {
setTargetAttribute($driver, $target, 'enabled', 0);
$changes++;
}
} }
} }
} }