mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-17 02:31:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

scst: Suppress a false positive Coverity memory corruption complaint

Browse Source 
This patch suppresses the following Coverity complaint:

CID 119689 (#1 of 1): Out-of-bounds access (OVERRUN)
overrun-buffer-arg: Overrunning struct type scst_event of 64 bytes by
passing it to a function which accesses it at byte offset 3135 using
argument 64UL + payload_len (which evaluates to 3136). [Note: The source
code implementation of the function has been overridden by a builtin model.]



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8760 d57e44dd-8a1f-0410-8b47-8ef2f437770f
This commit is contained in:
Bart Van Assche
2020-01-04 17:46:07 +00:00
parent 2c530f79af
commit ffd85476ae
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
scst/src/scst_event.c
View File

@@ -567,10 +567,10 @@ out:
/* /*
* scst_event_mutex supposed to be held. Caller supposed to free returned * scst_event_mutex supposed to be held. Caller supposed to free returned
* out_event_entry using kfree(). This function returnes event_entry, not * out_event_entry using kfree(). This function returns event_entry, not
* plain event, because this entry can then be queued in some list. * plain event, because this entry can then be queued in some list.
*/ */
static int scst_event_get_event_from_user(void __user *arg, static int scst_event_get_event_from_user(struct scst_event_user __user *arg,
struct scst_event_entry **out_event_entry) struct scst_event_entry **out_event_entry)
{ {
int res, rc, event_entry_len; int res, rc, event_entry_len;
@@ -579,7 +579,7 @@ static int scst_event_get_event_from_user(void __user *arg,
TRACE_ENTRY(); TRACE_ENTRY();
res = get_user(payload_len, (uint32_t __user *)arg); res = get_user(payload_len, &arg->max_event_size);
if (res != 0) { if (res != 0) {
PRINT_ERROR("Failed to get payload len: %d", res); PRINT_ERROR("Failed to get payload len: %d", res);
goto out; goto out;
@@ -606,14 +606,22 @@ static int scst_event_get_event_from_user(void __user *arg,
TRACE_MEM("Allocated event entry %p", event_entry); TRACE_MEM("Allocated event entry %p", event_entry);
rc = copy_from_user(&event_entry->event, arg, rc = copy_from_user((u8 *)event_entry +
sizeof(event_entry->event) + payload_len); offsetof(typeof(*event_entry), event), arg,
event_entry_len);
if (rc != 0) { if (rc != 0) {
PRINT_ERROR("Failed to copy %d user's bytes", rc); PRINT_ERROR("Failed to copy %d user's bytes", rc);
res = -EFAULT; res = -EFAULT;
goto out_free; goto out_free;
} }
/* payload_len has been recopied, so recheck it. */
if (event_entry->event.payload_len != event_entry_len) {
PRINT_ERROR("Payload len changed while being read");
res = -EINVAL;
goto out_free;
}
event_entry->event.issuer_name[sizeof(event_entry->event.issuer_name)-1] = '\0'; event_entry->event.issuer_name[sizeof(event_entry->event.issuer_name)-1] = '\0';
TRACE_DBG("user event: event_code %d, issuer_name %s", TRACE_DBG("user event: event_code %d, issuer_name %s",