8786 Commits

Author SHA1 Message Date
Bart Van Assche
5afbc1222d Fixed the following checkpatch warning by removing a blank line:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1164 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-03 06:59:51 +00:00
Vladislav Bolkhovitin
c3a6195342 Possible NULL pointer dereference in vdisk_fsync() noticed by Andrzej Hajderek <andrzej@hajderek.pl> fixed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1162 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-02 12:36:41 +00:00
Vladislav Bolkhovitin
aaac2c07f9 Forgotten copyrights updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1160 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-01 11:01:11 +00:00
Vladislav Bolkhovitin
34ac184d39 - New scst_user IOCTL SCST_USER_PREALLOC_BUFFER added
- New scst_user option sgv_disable_clustered_pool added
 - fileio_tgt updated to use those new facilities
 - Scst_user docs updated
 - sgv_pool_get() and sgv_pool_put() made exported
 - AENs sense buffer override fixed



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1159 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-30 18:35:24 +00:00
Vladislav Bolkhovitin
273acf1fec Logging improved
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1158 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-30 18:24:18 +00:00
Vladislav Bolkhovitin
9bac8a7ddd Extended latency statistics
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1157 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-29 20:35:22 +00:00
Vladislav Bolkhovitin
21aeb806ff Patch from Smadar Gonen <smadar.gn@gmail.com> implementing extended latency statistics.
Intermediate commit, don't use it!



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1156 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-29 20:30:17 +00:00
Mark Buechler
7a0239179d - By default, don't issue a LIP after a group assignment change.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1155 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-28 13:38:31 +00:00
Bart Van Assche
994b61e39b Added more error injection code.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1154 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-26 15:51:58 +00:00
Bart Van Assche
916dee314f Another bug fix for aborting SCST commands: commands in state
SRPT_STATE_NEW are now aborted properly too. Until now aborting an
SCST command that had state SRPT_STATE_NEW triggered a sBUG_ON()
statement in scst_tgt_cmd_done().


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1153 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-26 12:56:20 +00:00
Bart Van Assche
ffaac4ff69 Added to repository.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1152 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-26 11:45:59 +00:00
Bart Van Assche
1776360956 Added kernel version 2.6.31.1.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1151 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-26 11:39:58 +00:00
Bart Van Assche
90bfe40444 Fixed the following checkpatch complaints:
- ERROR: open brace '{' following struct go on the same line
- ERROR: return is not a function, parentheses are not required
- ERROR: that open brace { should be on the previous line
- WARNING: %Ld/%Lu are not-standard C, use %lld/%llu
- WARNING: braces {} are not necessary for single statement blocks


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1150 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-26 08:54:42 +00:00
Bart Van Assche
a7c8b82516 Converted GNU-style to C99-style initializer list because checkpatch
does not recognize the former and complains about it.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1149 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-26 08:39:18 +00:00
Bart Van Assche
4d9c7babaf Fixed checkpatch complaints about whitespace.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1148 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-26 08:37:27 +00:00
Vladislav Bolkhovitin
f9182e3b00 Not completed documenting how to workaround Windows READ CAPACITY(16) bug completed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1147 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-25 19:39:25 +00:00
Vladislav Bolkhovitin
93e8178a4f - Sense handling cleanup
- How to workaround Windows READ CAPACITY(16) bug documented



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1146 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-25 18:57:10 +00:00
Vladislav Bolkhovitin
b22067d540 Update for 2.6.31
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1145 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-25 18:31:33 +00:00
Vladislav Bolkhovitin
b5f9085222 - Fixes wrong DMA data direction
- Micro performance improvement



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1144 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-25 18:20:13 +00:00
Mark Buechler
af3245ca0a - Only retry creating a temp group name the max possible names
to prevent an infinite loop. Since we're using rand() here,
  it's possible we could exit the loop with no unique name.     
  However, this is pretty unlikely considering thousands
  if temp group names would have to already exist.
- Fail out if we can't come up with a temp group name and just
  use the original specified.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1143 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-25 14:11:43 +00:00
Mark Buechler
35a00370ae - Print a friendly warning if -issuelip (or it's config option) is used
and the target drives lacks support for it.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1142 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-25 14:00:08 +00:00
Mark Buechler
300922e6c5 - Regenerate temp group name should the current one already exist.
- Include temp group renames in the change count.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1141 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-25 13:56:06 +00:00
Bart Van Assche
0ff548a598 Fixed a typo in the documentation: replaced ipsrpdm by ibsrpdm.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1140 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-25 08:00:00 +00:00
Bart Van Assche
267f3b1f79 Only report that a command already got aborted when SCSI management
debugging has been enabled.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1139 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-24 18:42:22 +00:00
Bart Van Assche
3540d6b53d Updated kernel versions 2.6.27.34 and 2.6.30.7 to 2.6.27.35 and 2.6.30.8 respectively.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1138 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-24 18:33:07 +00:00
Vladislav Bolkhovitin
395c59cd3a Spell fixes, including "restransmitting" noticed by Gal Rosen <galr@storwize.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1137 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-23 19:14:02 +00:00
Mark Buechler
ce8b9745c4 - Update example scst.conf file to reflect the new [OPTIONS] section.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1136 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-23 18:45:53 +00:00
Mark Buechler
a868ed7221 - Minor cleanup to new -issuelip functionality.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1135 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-23 18:05:47 +00:00
Mark Buechler
4d1e8f84c7 Changes for 1.0.10
- Added new [OPTIONS] section to config file.             
- Added new ISSUE_LIP option for fc targets to issue a LIP after group
  assignment changes.
- Added new KEEP_CONFIG option to keep all options when overwriting a   
  configuration file with -writeconfig.
- General cleanup.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1134 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-23 17:44:53 +00:00
Mark Buechler
c4e0b280c1 - If target-oriented access control mode is used, Default_ groups will first be created
as temporary groups and later renamed.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1133 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-23 15:39:08 +00:00
Mark Buechler
40f337bba6 - Added items to the ToDo list.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1132 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-23 15:00:29 +00:00
Mark Buechler
4be7ffa4da - Replace a device on a given LUN when applying the configuration instead of removing
the old device and assigning the new one.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1131 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-23 14:58:19 +00:00
Bart Van Assche
393c423380 Excluded qla2x00t from local build because compiling it is only possible after having modified the local kernel headers.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1130 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-23 07:03:29 +00:00
Bart Van Assche
2a01729d4d Builds again when CONFIG_SCST_DEBUG has not been defined.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1129 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-23 06:50:49 +00:00
Bart Van Assche
18fcb11be3 Added error injection code: the kernel parameter processing_delay_in_us
allows to control by how much the srpt_completion() function (which runs
in interrupt context) will be delayed.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1128 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-22 19:18:45 +00:00
Bart Van Assche
192e2eff4f Added qla2x00t to the nightly build.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1127 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-22 18:27:54 +00:00
Bart Van Assche
59e5d0410c More whitespace-only changes that fix several checkpatch errors.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1126 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-22 18:26:33 +00:00
Bart Van Assche
f582bf72d3 Removed trailing whitespace.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1125 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-22 18:07:18 +00:00
Vladislav Bolkhovitin
a6b332d795 - Grammar fixes suggested by Richard Sharpe <realrichardsharpe@gmail.com>
- Minor cleanups



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1124 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-22 06:56:28 +00:00
Bart Van Assche
9adc308a2a Since it is normal that the SCST core calls srpt_xmit_response() for
a command that has already been aborted, changed the message that
reports this from an error message to an informational message.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1123 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-21 18:43:15 +00:00
Vladislav Bolkhovitin
150aec02e5 Users page added
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1122 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-21 12:55:54 +00:00
Bart Van Assche
81bf548098 - Added command-line option -j, which allows to use fio for measuring
I/O times instead of dd.
- For asynchronous (buffered) write tests with dd, switched from
  sync-after-every-write to sync-at-end.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1121 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-20 12:11:12 +00:00
Dotan Barak
069d3ef3f1 Incorporate last patch submitted for task management retry.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1120 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-19 20:18:03 +00:00
Bart Van Assche
d9abf60c23 Fixed typo in an error message.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1119 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-19 19:01:30 +00:00
Bart Van Assche
1afa718390 Ported the OFED 1.5 commit http://www.openfabrics.org/git/?p=ofed_1_5/linux-2.6.git;a=commitdiff;h=ce223537aeb05c9e4c36eab2b509fb98a33ba359:
replaced dma_*map* calls by ib_dma_*map* calls. Added the conversion
of dma_sync_single_for_device() to ib_dma_sync_single_for_device().
This only changes the behavior of SRPT for those IB interfaces whose
driver implements the ib_dma_mapping_ops operations.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1118 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-19 18:22:22 +00:00
Bart Van Assche
9381444e7d Applied a modified version of OFED commit http://www.openfabrics.org/git/?p=ofed_1_5/linux-2.6.git;a=commitdiff;h=6b20b3fb9b51722f382d6bfe333ec5bb5c216e9f.
The OFED commit made a.o. ib_srpt.c compile on 2.6.30 and later kernels.
Although the SCST ib_srpt.c code already compiles on a 2.6.30 kernel, this
commit has been ported to SCST because the source code of the OFED
implementation is cleaner. This commit does not change any functionality
of SCST's SRPT.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1117 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-19 16:40:01 +00:00
Bart Van Assche
f048bf9956 Changed a PRINT_ERROR() statement into a PRINT_INFO() statement because
this statement is triggered during the normal logout / relogin procedure.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1116 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-18 19:03:24 +00:00
Bart Van Assche
0a7c9e1f67 Potential fix for the following kernel bug report:
------------[ cut here ]------------
 ib_srpt: srpt_xmit_response: tag= 26 channel in bad state 2
 scst: ***ERROR***: Target driver ib_srpt xmit_response() returned fatal error
 ib_srpt: srpt_xmit_response: tag= 38 channel in bad state 2
 scst: ***ERROR***: Target driver ib_srpt xmit_response() returned fatal error
 ib_srpt: srpt_xmit_response: tag= 27 channel in bad state 2
<repeated many times>
 kernel BUG at /root/scst/scst/src/scst_targ.c:3089!
 invalid opcode: 0000 [1] SMP
 CPU 0
...
 RIP: 0010:[<ffffffffa04759f6>]  [<ffffffffa04759f6>] scst_tgt_cmd_done+0x26/0x30 [scst]
 RSP: 0018:ffff88039ad27b50  EFLAGS: 00010297
 RAX: 0000000000000200 RBX: ffff8803ad9c68f8 RCX: 0000000000000000
 RDX: 00000000ffffffff RSI: 0000000000000000 RDI: ffff8803ad9c68f8
 RBP: ffff88039ad27b50 R08: 0000000000000000 R09: 0000000000000000
 R10: ffff88039ad277c0 R11: ffff88041ad278cf R12: ffff8803c2972180
 R13: ffff88039ada0000 R14: 0000000000000001 R15: ffff8803fb00c2b0
 FS:  0000000000000000(0000) GS:ffffffff807dd000(0000) knlGS:0000000000000000
 CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
 CR2: 00007f9281e64000 CR3: 0000000000201000 CR4: 00000000000006e0
 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
 Process ib_cm/0 (pid: 8299, threadinfo ffff88039ad26000, task ffff88039ad40000)
 Stack:  ffff88039ad27b80 ffffffffa04c0c47 ffff88039a8db900 ffff8803c2972180
  ffff8803fb00c240 ffff8803fb00c284 ffff88039ad27bc0 ffffffffa04c0d93
  ffff88042a4959c0 ffff88042a9d7800 ffff88042544da00 ffff88042a9d7898
 Call Trace:
  [<ffffffffa04c0c47>] srpt_abort_scst_cmd+0xd7/0x160 [ib_srpt]
  [<ffffffffa04c0d93>] srpt_release_channel+0xc3/0x190 [ib_srpt]
  [<ffffffffa04c0e82>] srpt_find_and_release_channel+0x22/0x30 [ib_srpt]
  [<ffffffffa04c227d>] srpt_cm_handler+0x6d/0xbb8 [ib_srpt]
  [<ffffffff80247526>] ? try_to_wake_up+0x126/0x2f0
  [<ffffffff802476fd>] ? default_wake_function+0xd/0x10
  [<ffffffff80267106>] ?  autoremove_wake_function+0x16/0x40
  [<ffffffff8023c99a>] ? __wake_up_common+0x5a/0x90
  [<ffffffff8023dece>] ? __wake_up+0x4e/0x70
  [<ffffffff80263271>] ? __queue_work+0x41/0x50
  [<ffffffff8026331d>] ? queue_work_on+0x4d/0x60
  [<ffffffff8026344f>] ? queue_work+0x1f/0x30
  [<ffffffff8026350d>] ? queue_delayed_work+0x2d/0x40
  [<ffffffffa0373255>] ? wait_for_response+0xd5/0xe0 [ib_mad]
  [<ffffffffa04b4e07>] cm_process_work+0x27/0x130 [ib_cm]
  [<ffffffffa04b5cf1>] cm_drep_handler+0xf1/0x180 [ib_cm]
  [<ffffffffa04b7790>] ? cm_work_handler+0x0/0x1b8 [ib_cm]
  [<ffffffffa04b7895>] cm_work_handler+0x105/0x1b8 [ib_cm]
  [<ffffffffa04b7790>] ? cm_work_handler+0x0/0x1b8 [ib_cm]
  [<ffffffff802628c2>] run_workqueue+0xc2/0x1a0
  [<ffffffff80262bcf>] worker_thread+0xaf/0x130
  [<ffffffff802670f0>] ? autoremove_wake_function+0x0/0x40
  [<ffffffff80262b20>] ? worker_thread+0x0/0x130
  [<ffffffff80266cbe>] kthread+0x4e/0x90
  [<ffffffff80213c99>] child_rip+0xa/0x11
  [<ffffffff80266c70>] ? kthread+0x0/0x90
  [<ffffffff80213c8f>] ? child_rip+0x0/0x11
 Code: 00 00 00 00 00 55 48 89 e5 e8 a7 cc d9 df 83 7f 28 78 75 17 80 67 2d f7 c7 47 28 0d 00 00 00 ba 01 00 00 00 e8 8c fc ff ff c9 c3 <0f> 0b eb fe 66 0f 1f 44 00 00 55 48 89 e5 41 54 53 e8 74 cc d9
 RIP  [<ffffffffa04759f6>] scst_tgt_cmd_done+0x26/0x30 [scst]
  RSP <ffff88039ad27b50>
 ---[ end trace a7f20725e9471e16 ]---


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1115 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-18 18:58:55 +00:00
Vladislav Bolkhovitin
cb7a5d9ee0 - More web fixes from Daniel Fernandes <dfernandes1978@hotmail.com>
- sponsorship.html removed



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1114 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-18 12:03:06 +00:00
Vladislav Bolkhovitin
9a57947a5e Patch from Mark Buechler <mark.buechler@gmail.com> adding io_context patch for 2.6.26 kernel
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1113 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-18 10:33:12 +00:00