8786 Commits

Author SHA1 Message Date
Bart Van Assche
8de9eb487a scstadmin: Fix -resync_dev
Fix the following failure:

    # scstadmin -resync_dev volume01
    Collecting current configuration: done.
            -> Making requested changes.
            -> WARNING: Device 'volume01' lacks the settable attribute 'resync_size', ignoring.
            -> Done.
    All done.

This patch fixes a regression that was introduced by r8171 (commit
aedcfc5997 ("scstadmin: Avoid that Perl complains about undefined values
for write-only attributes") # v3.4.

Reported-by: Marc Smith <msmith626@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8915 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 20:45:26 +00:00
Bart Van Assche
3b9d078113 Merge branch 'svn-trunk' 2020-05-14 09:40:28 -07:00
Bart Van Assche
d045ff5e26 srpt: Make zero-copy mode compatible with the scst_user device handler
The scst_user device handler allocates its own data buffers. If ib_srpt
uses zero-copy mode, copy data as required between the device handler and
zero-copy buffer.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8914 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 16:40:05 +00:00
Bart Van Assche
198cb64c8d scstadmin: Make test 06 more robust
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8913 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 16:37:18 +00:00
Bart Van Assche
29548a4ad7 scst: Remove the on_alua_state_change_*() callback functions
Remove these callback functions because:
- Since the introduction of the 'active' attribute, these callback functions
  are no longer essential. See also commit 9d21169f8c ("scst: implement
  BLOCKIO devices "active" attribute").
- The current implementation may break I/O. The following ALUA configuration
  is sufficient to break I/O (because a remote group with state 'standby'
  occurs last):

DEVICE_GROUP dgroup1 {
	DEVICE disk01

	TARGET_GROUP tgroup1 {
		group_id 256
		preferred 1
		state active
		TARGET scst_local_tgt
	}
	TARGET_GROUP tgroup2 {
		group_id 257
		state standby
		TARGET scst_local_tgt_remote {
			rel_tgt_id 7
		}
	}
}

See also commit 2b202209ca ("ALUA DRBD compatibility").



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8912 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 16:36:30 +00:00
Bart Van Assche
80d2dac38e vdisk_blockio: Remove support for unaligned buffers
Submitting an unaligned buffer is a bug. Additionally, the patch that added
support for unaligned buffers negatively affected performance of the ib_srpt
and scst_local drivers.

This patch reverts 85f8ac3a1e ("vdisk_blockio: Add support for unaligned
buffers").



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8911 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 16:27:32 +00:00
Bart Van Assche
7d63eaf0ce scstadmin: If modifying an SCST attribute fails, report why it fails
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8910 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 16:23:57 +00:00
Bart Van Assche
c6da74b1a7 Merge branch 'svn-trunk' 2020-05-13 14:27:20 -07:00
Bart Van Assche
041ef55247 scripts/kernel-functions: Fix the RHEL 6.x build
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8909 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 21:27:11 +00:00
Bart Van Assche
12a94137ca Merge branch 'svn-trunk' 2020-05-13 13:52:37 -07:00
Bart Van Assche
57d9df0717 scst: Remove an empty function
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8908 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 20:52:23 +00:00
Bart Van Assche
b1687999ba Merge branch 'svn-trunk' 2020-05-13 13:48:41 -07:00
Bart Van Assche
bcdfc28dd8 iscsi-scst: Add a hint what to look for if no userspace process is connected
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
[ bvanassche: edited description and patch ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8907 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 20:48:12 +00:00
Bart Van Assche
c91c6d5e1f Merge branch 'svn-trunk' 2020-05-13 13:46:56 -07:00
Konstantin Kharlamov
054c738f63 iscsi-scst: Add a hint what to look for if no userspace process is connected
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
[ bvanassche: edited description and patch ]
2020-05-13 13:46:41 -07:00
Konstantin Kharlamov
af1dfc9873 iscsi-scst: Remove unnecessary %s format modifiers
See also https://github.com/bvanassche/scst/pull/18.

Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>

git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8903 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 13:46:20 -07:00
Bart Van Assche
115ec5be90 scripts/kernel-functions: Only apply RHEL patches on RHEL kernels
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8906 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 20:37:30 +00:00
Bart Van Assche
858f50e4d3 scstadmin: Improve robustness
Instead of only interpreting the empty string as "no argument passed", also
consider 'undef' as "no argument passed".


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8905 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 17:24:35 +00:00
Bart Van Assche
ee0328f6f7 scst: Drop support for scst_register_target(..., NULL)
Support for autogenerated target names was declared obsolete in 2011. Remove
support for autogenerated target names. See also commit 21d503cbb7
("Autogenerated SCST target names made deprecated").


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8904 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 17:23:14 +00:00
Bart Van Assche
08ba5d8f1a iscsi-scst: Remove unnecessary %s format modifiers
See also https://github.com/bvanassche/scst/pull/18.

Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8903 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-12 14:57:00 +00:00
Bart Van Assche
90f5d5f5bf Merge branch 'svn-trunk' 2020-05-11 18:04:49 -07:00
Bart Van Assche
95893200f2 scst_user: Fix a recently introduced coding style issue
See also commit b2facc91c9 ("scst/src/dev_handlers/scst_user: Simplify dev_user_reply_get_multi()").



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8902 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-12 01:04:32 +00:00
Bart Van Assche
e9f065b375 Merge branch 'svn-trunk' 2020-05-11 13:38:33 -07:00
Bart Van Assche
58a1ea5bd7 scripts/generate-kernel-patch: Use read instead of readarray and fix shellcheck warnings
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8901 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-11 20:38:25 +00:00
Bart Van Assche
056f426165 scripts/kernel-functions: Make this script compatible with bash versions that do not support readarray
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8900 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-11 20:37:43 +00:00
Bart Van Assche
9429a9930f scripts/rhel-rpm-functions: Use ${...//...} instead of setting the IFS variable
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8899 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-11 20:36:04 +00:00
Bart Van Assche
bec6dfbec1 Merge branch 'svn-trunk' 2020-05-10 13:47:42 -07:00
Bart Van Assche
04b4ee34fe scripts/run-regression-tests: Fix the CentOS 6.x build
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8894 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 20:47:33 +00:00
Bart Van Assche
41cad5fdcc Merge branch 'svn-trunk' 2020-05-10 12:00:52 -07:00
Bart Van Assche
f40d96c8a0 scripts/run-regression-tests: Make the CentOS build less noisy
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8893 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 19:00:39 +00:00
Bart Van Assche
ab4f2f5077 scripts/generate-kernel-patch: Use the generic drivers Makefile for CentOS 6.x
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8892 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 18:59:38 +00:00
Bart Van Assche
3d066f3ea1 Merge branch 'svn-trunk' 2020-05-10 11:58:14 -07:00
Bart Van Assche
30488c97b9 nightly/conf/nightly.conf: Add CentOS kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8891 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 18:39:34 +00:00
Bart Van Assche
8485b98f05 scripts/kernel-functions: Suppress RHEL warnings about module_init() / module_exit()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8890 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 18:38:58 +00:00
Bart Van Assche
676b1717fb scripts/specialize-patch: More bug fixes for RHEL / CentOS kernels
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8889 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 18:37:03 +00:00
Bart Van Assche
7b764b1499 fcst: Suppress sparse warnings
This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8888 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 18:36:21 +00:00
Bart Van Assche
4c279af06d Merge branch 'svn-trunk' 2020-05-09 15:57:06 -07:00
Bart Van Assche
1195daa855 scripts/specialize-patch: Fix RHEL kernel version checks
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8887 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:56:56 +00:00
Bart Van Assche
24b832098b scst: Fix the build against a RHEL 8 debug kernel
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8886 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:55:21 +00:00
Bart Van Assche
6773f8e9a5 scripts/run-regression-tests: Add support for distro kernels
A few examples of how to run the regression tests against a distro kernel:

scripts/run-regression-tests -l 4.18.0-147.5.1.el8_1^CentOS^8.1.1911-nc
scripts/run-regression-tests -l 4.18.0-80.11.2.el8_0^CentOS^8.0.1905-nc
scripts/run-regression-tests -l 3.10.0-1127.el7^CentOS^7.8.2003-nc
scripts/run-regression-tests -l 3.10.0-1062.18.1.el7^CentOS^7.7.1908-nc
scripts/run-regression-tests -l 3.10.0-957.27.2.el7^CentOS^7.6.1810-nc
scripts/run-regression-tests -l 3.10.0-862.14.4.el7^CentOS^7.5.1804-nc



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8885 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:54:47 +00:00
Bart Van Assche
b3b658bd09 scripts/generate-kernel-patch: Make several paths absolute
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8884 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:48:23 +00:00
Bart Van Assche
24caf06381 scripts/rhel-rpm-functions: Add more URLs
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8883 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:47:45 +00:00
Bart Van Assche
5b1a15d3c9 scstadmin/init.d/scst: Simplify sed expressions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8882 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:46:59 +00:00
Bart Van Assche
17a0091804 scstadmin/init.d/scst: Fix shellcheck warnings
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8881 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:46:02 +00:00
Bart Van Assche
5400331606 scripts/rhel-rpm-functions: Restore this file by reverting r8111
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8880 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 19:38:33 +00:00
Bart Van Assche
096e812053 Merge branch 'svn-trunk' 2020-05-09 08:12:39 -07:00
Bart Van Assche
f4ce28b5ab scst/include/backport.h: Unbreak the build on RHEL 7 / CentOS 7
Fixes: 5ebd20d839 ("scst/include/backport.h: Backport cpu_to_be32_array()")


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8879 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 15:11:29 +00:00
Bart Van Assche
289ae036e5 qla2x00t-32gbit: Fix a compiler warning triggered by kernel versions before v4.10
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8878 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 15:11:05 +00:00
Bart Van Assche
701428c1d0 Merge branch 'svn-trunk' 2020-05-08 08:32:25 -07:00
Bart Van Assche
5a99fa9a8c qla2x00t-32gbit: Move the trace/events/qla.h include file
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8877 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-08 15:32:10 +00:00