8786 Commits

Author SHA1 Message Date
Bart Van Assche
1d55adb06e Merge branch 'svn-trunk' 2019-06-07 19:06:54 -07:00
Bart Van Assche
ceafec13e9 iscsi-scst/Makefile: Avoid that 'make' reports an error if InfiniBand support is disabled in the kernel
Reported-by: Goran Bruns <goeran.bruns@gmx.de>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8419 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-08 01:56:34 +00:00
Bart Van Assche
939acc9359 Merge branch 'svn-trunk' 2019-06-05 17:51:43 -07:00
Bart Van Assche
d0d2544f7a qla2x00t-32gbit: Simplify the event handling code, part 2
This patch reworks commit 0ed0d35395 ("qla2x00t-32gbit: Fix PRLI and
PLOGI handling" / r8351).


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8418 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-05 21:01:46 +00:00
Bart Van Assche
34c8d73fc6 qla2x00t-32gbit: Simplify the event handling code
This patch reworks commit 0ed0d35395 ("qla2x00t-32gbit: Fix PRLI and
PLOGI handling" / r8351).



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8417 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-05 20:54:47 +00:00
Bart Van Assche
7ef1a7ea89 qla2x00t*: Declare PCI bus mode speed name arrays const
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8416 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-05 20:49:33 +00:00
Bart Van Assche
49b3d59e57 qla2x00t-32gbit: Remove double assignment in qla2x00_update_fcport
Remove double assignment in qla2x00_update_fcport().

Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[bvanassche: ported this patch to the SCST tree]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8415 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-05 20:48:52 +00:00
Bart Van Assche
832df7e200 Merge branch 'svn-trunk' 2019-06-02 20:34:25 -07:00
Bart Van Assche
c4793a793d qla2x00t-32gbit: display FC-NVMe port roles
Currently the FC-NVMe driver is leveraging the SCSI FC transport class to
access the remote ports. Which means that all FC-NVMe remote ports will be
visible to the fc transport layer, but due to missing definitions the port
roles will always be 'unknown'.  This patch adds the missing definitions to
the fc transport class to that the port roles are correctly displayed.

Signed-off-by: Hannes Reinecke <hare@suse.de>
[ bvanassche: Ported this patch to SCST ]

See also upstream commit a6a6d0589ac4 ("scsi: scsi_transport_fc: nvme:
display FC-NVMe port roles") # v5.2-rc1.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8414 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-03 03:34:16 +00:00
Bart Van Assche
c57c30b22f Merge branch 'svn-trunk' 2019-06-02 19:59:09 -07:00
Bart Van Assche
acc9f21ed7 qla2x00t-32gbit: Introduce qla2x00_els_dcmd2_free()
This patch does not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8413 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-03 02:56:23 +00:00
Bart Van Assche
c163f7b261 qla2x00t-32gbit: Make qlt_handle_abts_completion() more robust
Avoid that this function crashes if mcmd == NULL.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8412 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-03 02:55:47 +00:00
Bart Van Assche
2b5161a84d qla2x00t-32gbit: Remove a superfluous forward declaration
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8411 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-03 02:55:23 +00:00
Bart Van Assche
5de0e0b19f qla2x00t-32gbit: Remove two superfluous variable initializations
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8410 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-03 02:54:23 +00:00
Bart Van Assche
933bce2727 qla2x00t-32gbit/qla_nx.h: Remove two superfluous include directives
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8409 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-03 02:53:54 +00:00
Bart Van Assche
b4330f3d3e qla2x00t-32gbit: Synchronize ql_dump_buffer() definition with the upstream code
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8408 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-03 02:53:30 +00:00
Bart Van Assche
38235c85af Merge branch 'svn-trunk' 2019-06-02 08:48:23 -07:00
Bart Van Assche
ef98056164 scripts/specialize-patch: Expand HAVE_DEV_ATTR_MAX_RECV_SGE
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8407 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-02 15:48:12 +00:00
Bart Van Assche
d0062bc142 Merge branch 'svn-trunk' 2019-06-02 08:06:16 -07:00
Bart Van Assche
4c74d8a2c7 scripts/generate-kernel-patch: Remove obsolete download_kernel() calls
See also 0dceefe878 ("qla2x00t, scripts: Introduce download_and_extract_kernel_tree()") / r8117.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8406 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-06-02 15:01:46 +00:00
Bart Van Assche
eaec7f86fd nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8405 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-31 14:24:26 +00:00
Bart Van Assche
8a5c21469f Merge branch 'svn-trunk' 2019-05-30 19:07:34 -07:00
Bart Van Assche
2b06968569 qla2x00t-32gbit/Makefile_in-tree: Remove -Wno-format-truncation
Now that the strncpy() calls have been converted, remove -Wno-format-truncation.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8404 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-31 02:03:24 +00:00
Bart Van Assche
da5d9c509e Merge branch 'svn-trunk' 2019-05-30 18:57:13 -07:00
Bart Van Assche
c03d826b95 scst/include/backport.h: Modifications for script/specialize-patch
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8403 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-31 01:56:57 +00:00
Bart Van Assche
0344c58941 qla2x00t-32gbit: Use tabs instead of spaces for indentation
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8402 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-31 01:45:27 +00:00
Bart Van Assche
01e4a661ff qla2x00t-32gbit: Improve coding style conformance
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8401 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-31 01:44:41 +00:00
Bart Van Assche
6d83909e39 Merge branch 'svn-trunk' 2019-05-30 18:23:47 -07:00
Bart Van Assche
4af058edd4 srpt: Fix the build against Oracle Linux + MOFED
Disable DTrace when building against MOFED to avoid hitting compatibility
issue between DTrace and MOFED.

Signed-off-by: Sergey Gorenko <sergeygo@mellanox.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8400 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-31 01:23:20 +00:00
Bart Van Assche
506aac2508 iscsi-scst: Detect at compile time whether or not max_recv_sge is available
Signed-off-by: Sergey Gorenko <sergeygo@mellanox.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8399 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-31 01:21:49 +00:00
Bart Van Assche
629ac1c75d Merge branch 'svn-trunk' 2019-05-30 06:55:31 -07:00
Bart Van Assche
4486fd014e scst/include/backport.h: Fix build against MOFED >= 4.5 for lk < v4.18
Avoid that the following error is reported when building SCST against
a Linux kernel older than v4.18 combined with MOFED >= 4.5:

scst/include/backport.h:910:21: error: redefinition of 'kvcalloc'
 static inline void *kvcalloc(size_t n, size_t size, gfp_t flags)
                     ^
In file included from ./include/linux/highmem.h:8:0,
                 from ./include/linux/bio.h:21,
                 from ./scst/include/backport.h:24,
                 from ./scst/include/scst_debug.h:42,
                 from isert-scst/isert_dbg.h:29,
                 from isert-scst/iser_global.c:40:
/usr/src/ofa_kernel/default/include/linux/mm.h:78:21: note: previous definition of 'kvcalloc' was here
 static inline void *kvcalloc(size_t n, size_t size, gfp_t flags)
                     ^

Signed-off-by: Sergey Gorenko <sergeygo@mellanox.com>
[bvanassche: renamed MOFED_*_VERSION INTO MOFED_*]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8398 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-30 13:42:42 +00:00
Bart Van Assche
8e862c6d9b iscsi-scst, srpt: Restore MOFED_MAJOR and MOFED_MINOR definitions
This patch reverts commit bcdb25e550 (r7363).


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8397 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-30 13:41:27 +00:00
Bart Van Assche
d6e7007e1f Merge branch 'svn-trunk' 2019-05-30 06:29:29 -07:00
Bart Van Assche
aa91d1cd95 iscsi-scst: Work around a compatibility problem between MOFED and DTRACE
When building against Oracle Linux + MOFED the build fails unless if
DTrace is disabled. Hence disable DTrace for the isert-scst module if
MOFED is detected.

Signed-off-by: Sergey Gorenko <sergeygo@mellanox.com>
[ bvanassche: Left out one empty OFED_CONFIG assignment ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8396 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-30 03:14:44 +00:00
Bart Van Assche
984aaa3069 Merge branch 'svn-trunk' 2019-05-29 19:56:36 -07:00
Bart Van Assche
163e34b548 scripts/kernel-functions: Fix download_and_extract_kernel_tree()
Use grep to check whether or not 'git tag' succeeded since the exit status
of 'git tag' is always zero.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8395 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-30 02:46:35 +00:00
Bart Van Assche
5f827f32e5 Merge branch 'svn-trunk' 2019-05-27 15:41:48 -07:00
Bart Van Assche
4cce3cad73 qla2x00t-32gbit: Remove two superfluous tests
Since qlt_remove_target() only calls qlt_release() if
vha->vha_tgt.qla_tgt != NULL, checking that pointer inside qlt_release()
is not necessary. This patch avoids that Coverity reports the following:

CID 188348 (#1 of 1): Dereference after null check (FORWARD_NULL)
var_deref_model: Passing null pointer &vha->vha_tgt.qla_tgt->tgt_list_entry
to list_del, which dereferences it.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8394 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-27 22:41:01 +00:00
Bart Van Assche
7b3518ec10 qla2x00t-32gbit: Change the return type of qla2x00_update_ms_fdmi_iocb() into void
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8393 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-27 22:40:25 +00:00
Bart Van Assche
fc878306ad qla27xx_get_active_image(): Check secondary image if reading primary image fails
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8392 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-27 22:40:00 +00:00
Bart Van Assche
8e4c0dfb6b qla2x00t-32gbit: Change the return type of qla24xx_read_flash_dword()
Return a QLA_* status code instead of returning a pointer. This patch does
not change any functionality.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8391 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-27 22:39:36 +00:00
Bart Van Assche
16dab87783 qla2x00t-32gbit: Always check qla24xx_soft_reset() return value
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8390 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-27 22:39:03 +00:00
Bart Van Assche
96214a8a1f qla2x00t-32gbit: Use memcpy(), strlcpy() and snprintf() instead of strncpy()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8389 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-27 22:38:25 +00:00
Bart Van Assche
3c4662cb57 qla2x00t-32gbit: Check output buffer size while generating the PCI info string
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8388 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-27 22:37:30 +00:00
Bart Van Assche
5c2147135c qla2x00t: Use strlcpy() and snprintf() instead of strncpy()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8387 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-27 22:17:08 +00:00
Bart Van Assche
cf5c7c4093 qla2x00t-32gbit: Always check the return value of qla2x00_eh_wait_for_pending_commands()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8386 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-27 22:13:59 +00:00
Bart Van Assche
3eedf81cdb qla2x00t: Always check the return value of qla2x00_eh_wait_for_pending_commands()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8385 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-27 22:13:35 +00:00
Bart Van Assche
1119dc4736 qla2x00t-32gbit: Respect ha->model_number buffer size in qla2x00_set_model_info()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8384 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-27 22:13:05 +00:00
Bart Van Assche
0d173dbca4 qla2x00t-32gbit: Declare fourth qla2x00_set_model_info() argument const
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8383 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-05-27 22:12:29 +00:00