8786 Commits

Author SHA1 Message Date
Yan Burman
bd70a2eb27 isert: Fix race between disconnect handler and read by iscsi-scstd
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5896 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-30 08:17:02 +00:00
Bart Van Assche
2c18cd82ed scst: Add scripts/rebuild-rhel-kernel-rpm to the SCST release archive
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5895 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-28 09:16:37 +00:00
Bart Van Assche
7507b77063 ib_srpt: Rework the max_sge computation changes from r5795
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5894 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-27 15:29:29 +00:00
Bart Van Assche
efa1a763a6 ib_srpt: Log reject reason
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5893 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-27 15:24:17 +00:00
Bart Van Assche
d51ecb0e2a ib_srpt: Add support for immediate data
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5892 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-27 15:19:21 +00:00
Bart Van Assche
1657c7db3b scst.h: Add uintptr_t
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5891 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-27 15:18:58 +00:00
Vladislav Bolkhovitin
a42056e75a Cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5890 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-27 04:36:33 +00:00
Bart Van Assche
e7e2e4e17c scripts/specialize-patch: Reduce noise in nightly build output
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5889 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-26 19:42:10 +00:00
Bart Van Assche
a41cf8bc0a scripts/specialize-patch: Support blanks around numbers inside parentheses
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5888 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-26 16:25:57 +00:00
Bart Van Assche
b37c988337 ib_srpt: Make the send queue full messages more informational
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5887 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-26 14:39:51 +00:00
Bart Van Assche
548ea345b5 Build fixes for RHEL 6.6 kernel 2.6.32-504
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5886 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-26 13:38:52 +00:00
Bart Van Assche
9707f85c0b Fix kernel 3.17 checkpatch warnings about 'long long unsigned'
Avoid that checkpatch reports the following warning:

WARNING: type 'long long unsigned' should be specified in 'unsigned long long' order.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5885 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-26 08:16:44 +00:00
Bart Van Assche
d8c750993d nightly build: Add kernel 3.17
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5884 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-26 08:07:08 +00:00
Bart Van Assche
2fb7c084d7 Add kernel 3.17 build infrastructure
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5883 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-26 08:05:09 +00:00
Vladislav Bolkhovitin
e13aa6622d Update for kernels 3.17.x
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5882 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-26 07:02:17 +00:00
Bart Van Assche
4e645536a2 ib_srpt: Add support for HCA's that do not support SRQ
Based on a patch provided by Parav Pandit <Parav.Pandit@Emulex.Com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5881 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-24 17:59:14 +00:00
Bart Van Assche
51834ae6bb nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5880 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-22 11:12:29 +00:00
Bart Van Assche
bfaad5fabf scripts/generate-release-archive: Accept an optional list of file names
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5879 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-19 00:20:20 +00:00
Bart Van Assche
dd5561c93a srpt/Makefile: Add double quotes around a path
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5878 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-19 00:17:41 +00:00
Yan Burman
1238c3e88c isert: Add missing copyright notice
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5876 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-17 08:46:33 +00:00
Bart Van Assche
0501afbc6c nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5875 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 17:58:07 +00:00
Yan Burman
6c2a375768 Merged revisions 5833-5835,5844,5847-5856 via svnmerge from
svn+ssh://yanb123@svn.code.sf.net/p/scst/svn/trunk

........
  r5833 | bvassche | 2014-10-07 08:02:20 +0200 (Tue, 07 Oct 2014) | 1 line
  
  nightly build: Update kernel versions
........
  r5834 | bvassche | 2014-10-10 18:36:24 +0200 (Fri, 10 Oct 2014) | 1 line
  
  nightly build: Update kernel versions
........
  r5835 | bvassche | 2014-10-10 18:36:59 +0200 (Fri, 10 Oct 2014) | 1 line
  
  nightly build: Update kernel versions
........
  r5844 | vlnb | 2014-10-17 04:13:17 +0200 (Fri, 17 Oct 2014) | 3 lines
  
  iSER web updates
........
  r5847 | vlnb | 2014-10-17 04:22:23 +0200 (Fri, 17 Oct 2014) | 19 lines
  
  scst_vdisk: Remove a superfluous cast
  
  The 'iov_base' member of 'struct iovec' is declared in
  <uapi/linux/uio.h> with type 'void __user *'. Adding an integer
  to a void pointer has the same effect as adding an integer to
  a char pointer in the C language. This means that it is safe to
  remove the cast in front of the eiv->iov_base pointer.
  
  Please note that a similar construct already exists in the iSCSI
  target driver. From the nthread.c source file:
  
  			iop->iov_base += rest;
  			iop->iov_len -= rest;
  
  This patch does not change any functionality.
  
  Signed-off-by: Bart Van Assche <bvanassche@acm.org>
........
  r5848 | vlnb | 2014-10-17 04:24:07 +0200 (Fri, 17 Oct 2014) | 12 lines
  
  scst_vdisk: Reduce number of casts
  
  Since 'address' points at kernel space memory, change its type
  from uint8_t __user * into uint8_t *. This change reduces the
  number of casts between uint8_t __user * to uint8_t * in
  fileio_exec_write().
  
  This patch does not change any functionality.
  
  Signed-off-by: Bart Van Assche <bvanassche@acm.org>
........
  r5849 | vlnb | 2014-10-17 04:30:12 +0200 (Fri, 17 Oct 2014) | 10 lines
  
  scst_vdisk, MODE SELECT(10): Interpret both bytes of the BLOCK DESCRIPTOR LENGTH field
  
  While the BLOCK DESCRIPTOR LENGTH field spans a single byte in the
  Mode parameter header(6), the size of this field in the Mode parameter
  header(10) is two bytes. Interpret both bytes while executing a MODE
  SELECT(10) command.
  
  Signed-off-by: Bart Van Assche <bvanassche@acm.org>
........
  r5850 | vlnb | 2014-10-17 04:32:28 +0200 (Fri, 17 Oct 2014) | 8 lines
  
  scst/README: Document the lun<X> sysfs attributes
  
  The sessions/<sess>/lun<X> sysfs attribute "active_commands" is not
  yet documented. Hence add documentation for that sysfs attribute.
  
  Signed-off-by: Bart Van Assche <bvanassche@acm.org>
........
  r5851 | vlnb | 2014-10-17 04:35:01 +0200 (Fri, 17 Oct 2014) | 12 lines
  
  scst, iscsi-scst: Add thread_pid attribute
  
  For SCST devices with a short name determining which SCST command
  threads serve a given LUN requires an (expensive) walk of the
  process table. For SCST devices with a long name it is not possible
  to determine unambiguously which command threads serve a given
  LUN. Hence add a thread_pid sysfs attribute that makes it easy to
  figure out which command threads serve a LUN.
  
  Signed-off-by: Bart Van Assche <bvanassche@acm.org>
........
  r5852 | bvassche | 2014-10-18 10:56:23 +0200 (Sat, 18 Oct 2014) | 5 lines
  
  iscsi-scst: Make iscsi_thread_pool locking more fine-grained
  
  Protect iscsi_thread_pool.threads_list via tp_mutex instead of
  scst_mutex.
........
  r5853 | bvassche | 2014-10-24 09:12:39 +0200 (Fri, 24 Oct 2014) | 1 line
  
  nightly build: Update kernel versions
........
  r5854 | bvassche | 2014-11-01 10:30:20 +0200 (Sat, 01 Nov 2014) | 1 line
  
  nightly build: Update kernel versions
........
  r5855 | vlnb | 2014-11-15 03:44:06 +0200 (Sat, 15 Nov 2014) | 3 lines
  
  Ease severity of reporting unsupported REPORT LUNS SELECT REPORT value
........
  r5856 | vlnb | 2014-11-15 03:55:27 +0200 (Sat, 15 Nov 2014) | 3 lines
  
  Report RX data digest failures by default
........


git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5873 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:51:38 +00:00
Yan Burman
a37e20d3c3 isert: Remove extra paranoid check
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5872 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:25:14 +00:00
Yan Burman
6b3d77bc37 isert: Fix page leak if alloc_page fails
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5871 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:25:01 +00:00
Yan Burman
28781d1545 isert: Fix potential overrun detected by coverity
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5870 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:24:50 +00:00
Yan Burman
091bc739a7 isert: Silence coverity false positive
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5869 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:24:38 +00:00
Yan Burman
9236ef4ef8 isert: Do not leak workqueues if ib_create_cq failed
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5868 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:24:27 +00:00
Yan Burman
7716502b38 isert: Document performance considerations for iSER
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5867 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:24:15 +00:00
Yan Burman
270559b509 isert: Fix use-after-free when killing iscsi-scstd
Our portal may be destroyed while there are connections alive.
This means we are doing list_del() from list_head that no longer exists

Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5866 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:24:04 +00:00
Yan Burman
88339b14dd isert: Remove unused field
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5865 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:23:54 +00:00
Yan Burman
06fc2591ae isert: Fix crash on device removal when iscsi-scstd is started with explicit address
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5864 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:23:43 +00:00
Yan Burman
6a258d3629 isert: Make sure we decrement CQ QP counters if QP creation fails
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5863 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:23:31 +00:00
Yan Burman
f784590bb8 isert: Fix closing devices when connection allocation fails
We need to dereference isert_device structures whether
we created them or not if connection creation fails

Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5862 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:23:20 +00:00
Yan Burman
348224a808 isert: Warn user of potential compilation issue
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5861 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:23:09 +00:00
Yan Burman
679f7487db isert: Add support for rdma_cm private data as required by Annex A12 of the IB spec
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5860 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:22:58 +00:00
Yan Burman
2cfd09c8de isert: Fix resource leak upon unreachable event
Unreachable event caused by crash of initiator while in
connection establishment flow, would cause leak of connections.

Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5859 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-16 13:22:42 +00:00
Vladislav Bolkhovitin
d698f6c1bd Report RX data digest failures by default
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5856 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-15 01:55:27 +00:00
Vladislav Bolkhovitin
e03561da68 Ease severity of reporting unsupported REPORT LUNS SELECT REPORT value
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5855 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-15 01:44:06 +00:00
Bart Van Assche
d163d91f9f nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5854 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-11-01 08:30:20 +00:00
Bart Van Assche
51767a2239 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5853 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-10-24 07:12:39 +00:00
Bart Van Assche
23bfab0626 iscsi-scst: Make iscsi_thread_pool locking more fine-grained
Protect iscsi_thread_pool.threads_list via tp_mutex instead of
scst_mutex.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5852 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-10-18 08:56:23 +00:00
Vladislav Bolkhovitin
827e5b1461 scst, iscsi-scst: Add thread_pid attribute
For SCST devices with a short name determining which SCST command
threads serve a given LUN requires an (expensive) walk of the
process table. For SCST devices with a long name it is not possible
to determine unambiguously which command threads serve a given
LUN. Hence add a thread_pid sysfs attribute that makes it easy to
figure out which command threads serve a LUN.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5851 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-10-17 02:35:01 +00:00
Vladislav Bolkhovitin
a17fde27f9 scst/README: Document the lun<X> sysfs attributes
The sessions/<sess>/lun<X> sysfs attribute "active_commands" is not
yet documented. Hence add documentation for that sysfs attribute.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5850 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-10-17 02:32:28 +00:00
Vladislav Bolkhovitin
6ae28a0494 scst_vdisk, MODE SELECT(10): Interpret both bytes of the BLOCK DESCRIPTOR LENGTH field
While the BLOCK DESCRIPTOR LENGTH field spans a single byte in the
Mode parameter header(6), the size of this field in the Mode parameter
header(10) is two bytes. Interpret both bytes while executing a MODE
SELECT(10) command.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5849 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-10-17 02:30:12 +00:00
Vladislav Bolkhovitin
07e56dc160 scst_vdisk: Reduce number of casts
Since 'address' points at kernel space memory, change its type
from uint8_t __user * into uint8_t *. This change reduces the
number of casts between uint8_t __user * to uint8_t * in
fileio_exec_write().

This patch does not change any functionality.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5848 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-10-17 02:24:07 +00:00
Vladislav Bolkhovitin
f2fd09d3b2 scst_vdisk: Remove a superfluous cast
The 'iov_base' member of 'struct iovec' is declared in
<uapi/linux/uio.h> with type 'void __user *'. Adding an integer
to a void pointer has the same effect as adding an integer to
a char pointer in the C language. This means that it is safe to
remove the cast in front of the eiv->iov_base pointer.

Please note that a similar construct already exists in the iSCSI
target driver. From the nthread.c source file:

			iop->iov_base += rest;
			iop->iov_len -= rest;

This patch does not change any functionality.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5847 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-10-17 02:22:23 +00:00
Vladislav Bolkhovitin
9b679522d0 Docs cleanups and updates
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5845 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-10-17 02:16:08 +00:00
Vladislav Bolkhovitin
5e5d9a8164 iSER web updates
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5844 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-10-17 02:13:17 +00:00
Yan Burman
6b38638e71 isert: Remove unneeded if in the fast path
Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5842 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-10-13 12:33:30 +00:00
Yan Burman
dc27d29167 isert: Fix small memory leak on module unload
We were leaking portal structure upon module unload

Signed-off-by: Yan Burman <yanb@mellanox.com>

git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5841 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-10-13 12:33:20 +00:00